From d404d60c32942e273bbb41026b21055596f831e5 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Wed, 28 Aug 2024 14:07:59 +0200
Subject: [PATCH] Add extra tests

---
 .../src/api/routes/tests/viewV2.spec.ts       | 37 +++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts
index 84dfc39d43..a8c8d77558 100644
--- a/packages/server/src/api/routes/tests/viewV2.spec.ts
+++ b/packages/server/src/api/routes/tests/viewV2.spec.ts
@@ -929,7 +929,16 @@ describe.each([
     })
   })
 
-    describe("read", () => {
+    describe.each([
+      ["from view api", (view: ViewV2) => config.api.viewV2.get(view.id)],
+      [
+        "from table",
+        async (view: ViewV2) => {
+          const table = await config.api.table.get(view.tableId)
+          return (table.views || {})[view.name]
+        },
+      ],
+    ])("read (%s)", (_, getDelegate) => {
       let table: Table
       let tableId: string
 
@@ -966,8 +975,7 @@ describe.each([
           },
         })
 
-        expect((await config.api.table.get(tableId)).views).toEqual({
-          [view.name]: {
+        expect(await getDelegate(view)).toEqual({
             ...view,
             schema: {
               id: { ...table.schema["id"], visible: true },
@@ -975,6 +983,29 @@ describe.each([
               two: { ...table.schema["two"], visible: true },
               three: { ...table.schema["three"], visible: false },
             },
+        })
+      })
+
+      it("does not include columns removed from the table", async () => {
+        const view = await config.api.viewV2.create({
+          tableId,
+          name: generator.guid(),
+          schema: {
+            id: { visible: true },
+            one: { visible: true },
+            two: { visible: true },
+          },
+        })
+        const table = await config.api.table.get(tableId)
+        const { one: _, ...newSchema } = table.schema
+        await config.api.table.save({ ...table, schema: newSchema })
+
+        expect(await getDelegate(view)).toEqual({
+          ...view,
+          schema: {
+            id: { ...table.schema["id"], visible: true },
+            two: { ...table.schema["two"], visible: true },
+            three: { ...table.schema["three"], visible: false },
           },
         })
       })