From d68d449f1f02b853119c1c4c5cf6c2af37229d88 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Mon, 4 Sep 2023 12:11:59 +0200
Subject: [PATCH] DRY

---
 .../backend/DataTable/modals/ManageAccessModal.svelte | 11 ++++++++---
 packages/server/src/sdk/app/permissions/index.ts      |  7 +------
 packages/types/src/sdk/permissions.ts                 |  6 ++++++
 3 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/packages/builder/src/components/backend/DataTable/modals/ManageAccessModal.svelte b/packages/builder/src/components/backend/DataTable/modals/ManageAccessModal.svelte
index c7120bd1ab..161757c570 100644
--- a/packages/builder/src/components/backend/DataTable/modals/ManageAccessModal.svelte
+++ b/packages/builder/src/components/backend/DataTable/modals/ManageAccessModal.svelte
@@ -1,4 +1,5 @@
 <script>
+  import { PermissionSource } from "@budibase/types"
   import { roles, permissions as permissionsStore } from "stores/backend"
   import {
     Label,
@@ -17,9 +18,11 @@
   export let resourceId
   export let permissions
 
+  const inheritedRoleId = "inherited"
+
   async function changePermission(level, role) {
     try {
-      if (role === "inherited") {
+      if (role === inheritedRoleId) {
         await permissionsStore.remove({
           level,
           role,
@@ -45,14 +48,16 @@
     (p, [level, roleInfo]) => {
       p[level] = {
         selectedValue:
-          roleInfo.permissionType === "INHERITED" ? "inherited" : roleInfo.role,
+          roleInfo.permissionType === PermissionSource.INHERITED
+            ? inheritedRoleId
+            : roleInfo.role,
         options: [...get(roles)],
       }
 
       if (roleInfo.inheritablePermission) {
         p[level].inheritOption = roleInfo.inheritablePermission
         p[level].options.unshift({
-          _id: "inherited",
+          _id: inheritedRoleId,
           name: `Inherit (${
             get(roles).find(x => x._id === roleInfo.inheritablePermission).name
           })`,
diff --git a/packages/server/src/sdk/app/permissions/index.ts b/packages/server/src/sdk/app/permissions/index.ts
index f122714822..53f6756ae1 100644
--- a/packages/server/src/sdk/app/permissions/index.ts
+++ b/packages/server/src/sdk/app/permissions/index.ts
@@ -3,6 +3,7 @@ import { features } from "@budibase/pro"
 import {
   DocumentType,
   PermissionLevel,
+  PermissionSource,
   PlanType,
   Role,
   VirtualDocumentType,
@@ -49,12 +50,6 @@ export async function resourceActionAllowed({
   }
 }
 
-enum PermissionSource {
-  EXPLICIT = "EXPLICIT",
-  INHERITED = "INHERITED",
-  BASE = "BASE",
-}
-
 type ResourcePermissions = Record<
   string,
   { role: string; type: PermissionSource }
diff --git a/packages/types/src/sdk/permissions.ts b/packages/types/src/sdk/permissions.ts
index a33d4985ee..8d031bcf66 100644
--- a/packages/types/src/sdk/permissions.ts
+++ b/packages/types/src/sdk/permissions.ts
@@ -17,3 +17,9 @@ export enum PermissionType {
   QUERY = "query",
   VIEW = "view",
 }
+
+export enum PermissionSource {
+  EXPLICIT = "EXPLICIT",
+  INHERITED = "INHERITED",
+  BASE = "BASE",
+}