From df2b86ec4b52afb4eb81f916a08c4ec892f512c8 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Tue, 23 Aug 2022 15:08:39 +0100 Subject: [PATCH] Fix view form block not showing data and move size setting to general section --- packages/client/manifest.json | 37 ++++++++++--------- .../components/app/blocks/FormBlock.svelte | 4 +- 2 files changed, 21 insertions(+), 20 deletions(-) diff --git a/packages/client/manifest.json b/packages/client/manifest.json index 4dff6a7632..dea3014922 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -4399,11 +4399,12 @@ }, { "type": "text", - "label": "Row ID to update", + "label": "Row ID", "key": "rowId", "dependsOn": { "setting": "actionType", - "value": "Update" + "value": "Create", + "invert": true } }, { @@ -4412,6 +4413,22 @@ "key": "title", "nested": true }, + { + "type": "select", + "label": "Size", + "key": "size", + "options": [ + { + "label": "Medium", + "value": "spectrum--medium" + }, + { + "label": "Large", + "value": "spectrum--large" + } + ], + "defaultValue": "spectrum--medium" + }, { "section": true, "name": "Fields", @@ -4437,22 +4454,6 @@ } ] }, - { - "type": "select", - "label": "Size", - "key": "size", - "options": [ - { - "label": "Medium", - "value": "spectrum--medium" - }, - { - "label": "Large", - "value": "spectrum--large" - } - ], - "defaultValue": "spectrum--medium" - }, { "type": "boolean", "label": "Disabled", diff --git a/packages/client/src/components/app/blocks/FormBlock.svelte b/packages/client/src/components/app/blocks/FormBlock.svelte index 4770a9907a..da0abaeb06 100644 --- a/packages/client/src/components/app/blocks/FormBlock.svelte +++ b/packages/client/src/components/app/blocks/FormBlock.svelte @@ -90,7 +90,7 @@ // using a create form, we just want a fake array so that our repeater // will actually render the form, but data doesn't matter. $: dataProvider = - actionType === "Update" + actionType !== "Create" ? `{{ literal ${safe(providerId)} }}` : { rows: [{}] } @@ -133,7 +133,7 @@