Test extra cases

packages/types/src/api/web/global/scim/users.ts

@@ -1,6 +1,6 @@
 import { ScimResource, ScimMeta, ScimPatchOperation } from "scim-patch"
 
-type BooleanString = boolean | "True" | "False"
+type BooleanString = boolean | "True" | "true" | "False" | "false"
 
 export interface ScimUserResponse extends ScimResource {
   schemas: ["urn:ietf:params:scim:schemas:core:2.0:User"]

packages/worker/src/api/routes/global/tests/scim/users.spec.ts

@@ -396,23 +396,26 @@ describe("/api/global/scim/v2/users", () => {
       expect(persistedUser).toEqual(expectedScimUser)
     })
 
-    it("can deactive an active user", async () => {
+    it.each([false, "false", "False"])(
-      const body: ScimUpdateRequest = {
+      "can deactive an active user (sending %s)",
-        schemas: ["urn:ietf:params:scim:api:messages:2.0:PatchOp"],
+      async activeValue => {
-        Operations: [{ op: "Replace", path: "active", value: "False" }],
+        const body: ScimUpdateRequest = {
+          schemas: ["urn:ietf:params:scim:api:messages:2.0:PatchOp"],
+          Operations: [{ op: "Replace", path: "active", value: activeValue }],
+        }
+
+        const response = await patchScimUser({ id: user.id, body })
+
+        const expectedScimUser: ScimUserResponse = {
+          ...user,
+          active: false,
+        }
+        expect(response).toEqual(expectedScimUser)
+
+        const persistedUser = await config.api.scimUsersAPI.find(user.id)
+        expect(persistedUser).toEqual(expectedScimUser)
       }
-
+    )
-      const response = await patchScimUser({ id: user.id, body })
-
-      const expectedScimUser: ScimUserResponse = {
-        ...user,
-        active: false,
-      }
-      expect(response).toEqual(expectedScimUser)
-
-      const persistedUser = await config.api.scimUsersAPI.find(user.id)
-      expect(persistedUser).toEqual(expectedScimUser)
-    })
 
     it("supports updating unmapped fields", async () => {
       const body: ScimUpdateRequest = {