MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Backed out reactivity for Binding panel per discussion. Pending some UX discussion

This commit is contained in:
Dean 2024-08-13 16:40:48 +01:00
parent b321eabb50
commit e2c491ef96
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/builder/src/components/common/bindings/BindingPanel.svelte
View File

@ -67,10 +67,6 @@
let targetMode = null let targetMode = null
let expressionResult let expressionResult
let evaluating = false let evaluating = false
let mounted = false
// Value updates must be reprocessed to avoid timing issues
$: processUpdate(value, mounted)
$: useSnippets = allowSnippets && !$licensing.isFreePlan $: useSnippets = allowSnippets && !$licensing.isFreePlan
$: editorModeOptions = getModeOptions(allowHBS, allowJS) $: editorModeOptions = getModeOptions(allowHBS, allowJS)
@ -98,13 +94,6 @@
} }
} }
const processUpdate = value => {
if (!mounted) return
let isJS = value?.startsWith?.("{{ js ")
jsValue = isJS ? value : null
hbsValue = isJS ? null : value
}
const getHBSCompletions = bindingCompletions => { const getHBSCompletions = bindingCompletions => {
return [ return [
hbAutocomplete([ hbAutocomplete([
@ -277,8 +266,6 @@
// Set the initial side panel // Set the initial side panel
sidePanel = sidePanelOptions[0] sidePanel = sidePanelOptions[0]
mounted = true
}) })
</script> </script>