From e8e4f064a56cff92482b5180784c1d28149c1a24 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Fri, 2 Aug 2024 13:14:33 +0200
Subject: [PATCH] Fix invalid

---
 packages/server/src/utilities/schema.ts | 47 ++++++++++++++-----------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/packages/server/src/utilities/schema.ts b/packages/server/src/utilities/schema.ts
index 2613190b9c..32a5761e22 100644
--- a/packages/server/src/utilities/schema.ts
+++ b/packages/server/src/utilities/schema.ts
@@ -96,6 +96,7 @@ export function validate(
         return
       } else if (
         [FieldType.STRING].includes(columnType) &&
+        !columnData &&
         helpers.schema.isRequired(constraints)
       ) {
         results.schemaValidation[columnName] = false
@@ -215,29 +216,33 @@ function isValidBBReference(
   subtype: BBReferenceFieldSubType,
   isRequired: boolean
 ): boolean {
-  if (type === FieldType.BB_REFERENCE_SINGLE) {
-    if (!data) {
-      return !isRequired
-    }
-    const user = parseJsonExport<{ _id: string }>(data)
-    return db.isGlobalUserID(user._id)
-  }
-
-  switch (subtype) {
-    case BBReferenceFieldSubType.USER:
-    case BBReferenceFieldSubType.USERS: {
-      const userArray = parseJsonExport<{ _id: string }[]>(data)
-      if (!Array.isArray(userArray)) {
-        return false
+  try {
+    if (type === FieldType.BB_REFERENCE_SINGLE) {
+      if (!data) {
+        return !isRequired
       }
-
-      const constainsWrongId = userArray.find(
-        user => !db.isGlobalUserID(user._id)
-      )
-      return !constainsWrongId
+      const user = parseJsonExport<{ _id: string }>(data)
+      return db.isGlobalUserID(user._id)
     }
-    default:
-      throw utils.unreachable(subtype)
+
+    switch (subtype) {
+      case BBReferenceFieldSubType.USER:
+      case BBReferenceFieldSubType.USERS: {
+        const userArray = parseJsonExport<{ _id: string }[]>(data)
+        if (!Array.isArray(userArray)) {
+          return false
+        }
+
+        const constainsWrongId = userArray.find(
+          user => !db.isGlobalUserID(user._id)
+        )
+        return !constainsWrongId
+      }
+      default:
+        throw utils.unreachable(subtype)
+    }
+  } catch {
+    return false
   }
 }