From ec67b162b8b5c1943c634ba7650ddfc11a3add46 Mon Sep 17 00:00:00 2001 From: Michael Drury Date: Thu, 1 Jun 2023 14:10:07 +0100 Subject: [PATCH] There has been an issue with open source contributors being able to perform CI runs for their PRs - this is related to the addition of the pro checkout/submodule recursion in a recent update. Changing it to not use the contributors personal access token, but to instead use the github access token so that it can always be checked out and tested again the specified pro version. --- .github/workflows/budibase_ci.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/budibase_ci.yml b/.github/workflows/budibase_ci.yml index 4e0bc8b3a9..d915a7f0ad 100644 --- a/.github/workflows/budibase_ci.yml +++ b/.github/workflows/budibase_ci.yml @@ -16,7 +16,6 @@ on: env: BRANCH: ${{ github.event.pull_request.head.ref }} BASE_BRANCH: ${{ github.event.pull_request.base.ref}} - PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} jobs: lint: @@ -37,7 +36,7 @@ jobs: - uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Use Node.js 14.x uses: actions/setup-node@v3 with: @@ -55,7 +54,7 @@ jobs: - uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Use Node.js 14.x uses: actions/setup-node@v3 with: @@ -75,7 +74,7 @@ jobs: - uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Use Node.js 14.x uses: actions/setup-node@v3 with: @@ -95,7 +94,7 @@ jobs: - uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Use Node.js 14.x uses: actions/setup-node@v3 with: @@ -110,7 +109,7 @@ jobs: - uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Use Node.js 14.x uses: actions/setup-node@v3 with: @@ -134,7 +133,7 @@ jobs: uses: actions/checkout@v3 with: submodules: true - token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} fetch-depth: 0 - name: Check submodule run: |