diff --git a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
index 4fd2f40391..d09faa34c9 100644
--- a/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
+++ b/packages/builder/src/components/automation/SetupPanel/AutomationBlockSetup.svelte
@@ -38,13 +38,15 @@
export let testData
export let schemaProperties
export let isTestModal = false
+
let webhookModal
let drawer
- let tempFilters = lookForFilters(schemaProperties) || []
let fillWidth = true
let codeBindingOpen = false
let inputData
+ $: filters = lookForFilters(schemaProperties) || []
+ $: tempFilters = filters
$: stepId = block.stepId
$: bindings = getAvailableBindings(
block || $automationStore.selectedBlock,
@@ -222,16 +224,17 @@
{:else if value.customType === "filters"}
Define filters
-
+
(tempFilters = e.detail)}
/>
{:else if value.customType === "password"}
diff --git a/packages/builder/src/components/backend/DataTable/DataTable.svelte b/packages/builder/src/components/backend/DataTable/DataTable.svelte
index 7cb368830e..6a135b5428 100644
--- a/packages/builder/src/components/backend/DataTable/DataTable.svelte
+++ b/packages/builder/src/components/backend/DataTable/DataTable.svelte
@@ -25,6 +25,7 @@
import { API } from "api"
let hideAutocolumns = true
+ let filters
$: isUsersTable = $tables.selected?._id === TableNames.USERS
$: type = $tables.selected?.type
@@ -102,8 +103,9 @@
// Fetch data whenever filters change
const onFilter = e => {
+ filters = e.detail
fetch.update({
- filter: e.detail,
+ filter: filters,
})
}
@@ -178,6 +180,7 @@
{#key id}
diff --git a/packages/builder/src/components/backend/DataTable/buttons/TableFilterButton.svelte b/packages/builder/src/components/backend/DataTable/buttons/TableFilterButton.svelte
index 633c7e1ad1..be9c6259c6 100644
--- a/packages/builder/src/components/backend/DataTable/buttons/TableFilterButton.svelte
+++ b/packages/builder/src/components/backend/DataTable/buttons/TableFilterButton.svelte
@@ -8,9 +8,10 @@
export let disabled = false
const dispatch = createEventDispatcher()
- let modal
- let tempValue = filters || []
+ let modal
+
+ $: tempValue = filters || []
$: schemaFields = Object.values(schema || {})
@@ -34,8 +35,9 @@
(tempValue = e.detail)}
/>
diff --git a/packages/builder/src/components/design/settings/controls/FilterEditor/FilterDrawer.svelte b/packages/builder/src/components/design/settings/controls/FilterEditor/FilterDrawer.svelte
index 019a61a3bf..58b95b7248 100644
--- a/packages/builder/src/components/design/settings/controls/FilterEditor/FilterDrawer.svelte
+++ b/packages/builder/src/components/design/settings/controls/FilterEditor/FilterDrawer.svelte
@@ -17,22 +17,30 @@
import { generate } from "shortid"
import { LuceneUtils, Constants } from "@budibase/frontend-core"
import { getFields } from "helpers/searchFields"
- import { createEventDispatcher, onMount } from "svelte"
-
- const dispatch = createEventDispatcher()
- const { OperatorOptions } = Constants
- const { getValidOperatorsForType } = LuceneUtils
+ import { createEventDispatcher } from "svelte"
export let schemaFields
export let filters = []
export let bindings = []
export let panel = ClientBindingPanel
export let allowBindings = true
- export let allOr = false
export let fillWidth = false
export let tableId
- $: dispatch("change", filters)
+ const dispatch = createEventDispatcher()
+ const { OperatorOptions } = Constants
+ const { getValidOperatorsForType } = LuceneUtils
+ const KeyedFieldRegex = /\d[0-9]*:/g
+ const behaviourOptions = [
+ { value: "and", label: "Match all of the following filters" },
+ { value: "or", label: "Match any of the following filters" },
+ ]
+
+ let rawFilters
+ let matchAny = false
+
+ $: parseFilters(filters)
+ $: dispatch("change", enrichFilters(rawFilters, matchAny))
$: enrichedSchemaFields = getFields(
schemaFields || [],
{ allowLinks: true },
@@ -41,14 +49,41 @@
$: fieldOptions = enrichedSchemaFields.map(field => field.name) || []
$: valueTypeOptions = allowBindings ? ["Value", "Binding"] : ["Value"]
- let behaviourValue
- const behaviourOptions = [
- { value: "and", label: "Match all of the following filters" },
- { value: "or", label: "Match any of the following filters" },
- ]
+ // Remove field key prefixes and determine whether to use the "match all"
+ // or "match any" behaviour
+ const parseFilters = filters => {
+ matchAny = filters?.find(filter => filter.operator === "allOr") != null
+ rawFilters = (filters || [])
+ .filter(filter => filter.operator !== "allOr")
+ .map(filter => {
+ const { field } = filter
+ let newFilter = { ...filter }
+ delete newFilter.allOr
+ if (typeof field === "string" && field.match(KeyedFieldRegex) != null) {
+ const parts = field.split(":")
+ parts.shift()
+ newFilter.field = parts.join(":")
+ }
+ return newFilter
+ })
+ }
+
+ // Add field key prefixes and a special metadata filter object to indicate
+ // whether to use the "match all" or "match any" behaviour
+ const enrichFilters = (rawFilters, matchAny) => {
+ let count = 1
+ return rawFilters
+ .filter(filter => filter.field)
+ .map(filter => ({
+ ...filter,
+ field: `${count++}:${filter.field}`,
+ }))
+ .concat(matchAny ? [{ operator: "allOr" }] : [])
+ }
+
const addFilter = () => {
- filters = [
- ...filters,
+ rawFilters = [
+ ...rawFilters,
{
id: generate(),
field: null,
@@ -60,13 +95,13 @@
}
const removeFilter = id => {
- filters = filters.filter(field => field.id !== id)
+ rawFilters = rawFilters.filter(field => field.id !== id)
}
const duplicateFilter = id => {
- const existingFilter = filters.find(filter => filter.id === id)
+ const existingFilter = rawFilters.find(filter => filter.id === id)
const duplicate = { ...existingFilter, id: generate() }
- filters = [...filters, duplicate]
+ rawFilters = [...rawFilters, duplicate]
}
const getSchema = filter => {
@@ -133,32 +168,28 @@
const schema = enrichedSchemaFields.find(x => x.name === field)
return schema?.constraints?.inclusion || []
}
-
- onMount(() => {
- behaviourValue = allOr ? "or" : "and"
- })
- {#if !filters?.length}
+ {#if !rawFilters?.length}
Add your first filter expression.
{:else}
Results are filtered to only those which match all of the following
constraints.
{/if}
- {#if filters?.length}
+ {#if rawFilters?.length}
@@ -167,7 +198,7 @@
- {#each filters as filter, idx}
+ {#each rawFilters as filter, idx}