MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9629 from Budibase/fix/formula-column-edit 

Reactivity fix for the Create/Edit column modal.
This commit is contained in:
deanhannigan 2023-02-10 09:00:55 +00:00 committed by GitHub
parent 8eeb766976 4c013df676
commit ed5bb5e7cc
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/builder/src/components/backend/DataTable/modals/CreateEditColumn.svelte
View File

@ -75,16 +75,20 @@
editableColumn.constraints.presence = { allowEmpty: false } editableColumn.constraints.presence = { allowEmpty: false }
} }
$: if (field && !savingColumn) { const initialiseField = (field, savingColumn) => {
editableColumn = cloneDeep(field) if (field && !savingColumn) {
originalName = editableColumn.name ? editableColumn.name + "" : null editableColumn = cloneDeep(field)
linkEditDisabled = originalName != null originalName = editableColumn.name ? editableColumn.name + "" : null
isCreating = originalName == null linkEditDisabled = originalName != null
primaryDisplay = isCreating = originalName == null
$tables.selected.primaryDisplay == null || primaryDisplay =
$tables.selected.primaryDisplay === editableColumn.name $tables.selected.primaryDisplay == null ||
$tables.selected.primaryDisplay === editableColumn.name
}
} }
$: initialiseField(field, savingColumn)
$: checkConstraints(editableColumn) $: checkConstraints(editableColumn)
$: required = !!editableColumn?.constraints?.presence || primaryDisplay $: required = !!editableColumn?.constraints?.presence || primaryDisplay
$: uneditable = $: uneditable =
@ -583,7 +587,12 @@
title="Formula" title="Formula"
label="Formula" label="Formula"
value={editableColumn.formula} value={editableColumn.formula}
on:change={e => (editableColumn.formula = e.detail)} on:change={e => {
editableColumn = {
...editableColumn,
formula: e.detail,
}
}}
bindings={getBindings({ table })} bindings={getBindings({ table })}
allowJS allowJS
/> />