Lint and test fixes

This commit is contained in:
Conor_Mack 2020-06-17 17:44:47 +01:00
parent f9448f14a1
commit efb80347c6
2 changed files with 4 additions and 4 deletions

View File

@ -132,14 +132,14 @@ export const hexaToHSVA = (hex, alpha = "FF") => {
export const rgbaToHSVA = rgba => { export const rgbaToHSVA = rgba => {
const [r, g, b, a = 1] = rgba const [r, g, b, a = 1] = rgba
let hsv = _rgbToHSV([r, g, b]) let hsv = _rgbToHSV([r, g, b])
return [...hsv, a] return [...hsv, a].map(x => parseFloat(x))
} }
export const hslaToHSVA = ([h, s, l, a = 1]) => { export const hslaToHSVA = ([h, s, l, a = 1]) => {
let sat = s.replace(/%/, "") let sat = s.replace(/%/, "")
let lum = l.replace(/%/, "") let lum = l.replace(/%/, "")
let hsv = _hslToHSV([h, sat, lum]) let hsv = _hslToHSV([h, sat, lum])
return [...hsv, a] return [...hsv, a].map(x => parseFloat(x))
} }
export const hsvaToHexa = (hsva, asString = false) => { export const hsvaToHexa = (hsva, asString = false) => {

View File

@ -54,7 +54,7 @@ describe("convertHsvaToFormat - convert from hsva to format", () => {
test("Convert to hsla", () => { test("Convert to hsla", () => {
expect(convertHsvaToFormat([264, 68.63, 100, 1], "hsl")).toBe( expect(convertHsvaToFormat([264, 68.63, 100, 1], "hsl")).toBe(
"hsla(264,100,65.7,1)" "hsla(264,100%,66%,1)"
) )
}) })
}) })
@ -93,7 +93,7 @@ describe("Get Color Format", () => {
}) })
test("Testing hsla value with alpha", () => { test("Testing hsla value with alpha", () => {
expect(getColorFormat("hsla(150, 60, 50, 0.5)")).toBe("hsl") expect(getColorFormat("hsla(150, 60%, 50%, 0.5)")).toBe("hsl")
}) })
test("Testing hsl value with incorrectly provided alpha", () => { test("Testing hsl value with incorrectly provided alpha", () => {