From de944480da676891b1ff2a50fcc4beb42ad2b08a Mon Sep 17 00:00:00 2001
From: Maurits Lourens <maurits.lourens@gmail.com>
Date: Tue, 17 Aug 2021 23:57:11 +0200
Subject: [PATCH 1/2] update the name of the datasource

---
 .../bbui/src/ActionMenu/ActionMenu.svelte     |  7 ++-
 .../modals/UpdateDatasourceModal.svelte       | 62 +++++++++++++++++++
 .../popovers/EditDatasourcePopover.svelte     |  4 ++
 .../builder/src/stores/backend/datasources.js | 11 +++-
 .../server/src/api/controllers/datasource.js  | 22 +++++++
 packages/server/src/api/routes/datasource.js  |  5 ++
 6 files changed, 107 insertions(+), 4 deletions(-)
 create mode 100644 packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte

diff --git a/packages/bbui/src/ActionMenu/ActionMenu.svelte b/packages/bbui/src/ActionMenu/ActionMenu.svelte
index 45bb65b527..1c05021d12 100644
--- a/packages/bbui/src/ActionMenu/ActionMenu.svelte
+++ b/packages/bbui/src/ActionMenu/ActionMenu.svelte
@@ -23,8 +23,11 @@
     dropdown.show()
   }
 
-  const openMenu = () => {
-    if (!disabled) show()
+  const openMenu = (event) => {
+    if (!disabled) {
+      event.stopPropagation()
+      show()
+    }
   }
 
   setContext("actionMenu", { show, hide })
diff --git a/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte b/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte
new file mode 100644
index 0000000000..44148ebb6e
--- /dev/null
+++ b/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte
@@ -0,0 +1,62 @@
+<script>
+  import { datasources } from "stores/backend"
+  import { notifications } from "@budibase/bbui"
+  import { Input, ModalContent, Modal } from "@budibase/bbui"
+  import analytics from "analytics"
+
+  let error = ""
+  let modal
+  let name
+
+  export let datasource
+  export let onCancel = undefined
+
+  export const show = () => {
+    name = datasource?.name
+    modal.show()
+  }
+  export const hide = () => {
+    modal.hide()
+  }
+
+  function checkValid(evt) {
+    const datasourceName = evt.target.value
+    if (
+      $datasources?.list.some(ds => ds.name === datasourceName)
+    ) {
+      error = `Datasource with name ${datasourceName} already exists. Please choose another name.`
+      return
+    }
+    error = ""
+  }
+
+  async function updateDatasource() {
+    const updatedDatasource = {
+      ...datasource,
+      name,
+    }
+    await datasources.save(updatedDatasource)
+    notifications.success(`Datasource ${name} updated successfully.`)
+    analytics.captureEvent("Datasource Updated", updatedDatasource)
+    hide()
+  }
+</script>
+
+<Modal bind:this={modal} on:hide={onCancel}>
+  <ModalContent
+    title="Update Datasource"
+    size="L"
+    confirmText="Update"
+    onConfirm={updateDatasource}
+    disabled={error || !name || !datasource?.type}
+  >
+    <Input
+      data-cy="datasource-name-input"
+      label="Datasource Name"
+      on:input={checkValid}
+      bind:value={name}
+      {error}
+    />
+  </ModalContent>
+</Modal>
+
diff --git a/packages/builder/src/components/backend/DatasourceNavigator/popovers/EditDatasourcePopover.svelte b/packages/builder/src/components/backend/DatasourceNavigator/popovers/EditDatasourcePopover.svelte
index 71a85f38fb..7f2f104278 100644
--- a/packages/builder/src/components/backend/DatasourceNavigator/popovers/EditDatasourcePopover.svelte
+++ b/packages/builder/src/components/backend/DatasourceNavigator/popovers/EditDatasourcePopover.svelte
@@ -4,10 +4,12 @@
   import { notifications } from "@budibase/bbui"
   import { ActionMenu, MenuItem, Icon } from "@budibase/bbui"
   import ConfirmDialog from "components/common/ConfirmDialog.svelte"
+  import UpdateDatasourceModal from "components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte"
 
   export let datasource
 
   let confirmDeleteDialog
+  let updateDatasourceDialog
 
   async function deleteDatasource() {
     const wasSelectedSource = $datasources.selected
@@ -24,6 +26,7 @@
   <div slot="control" class="icon">
     <Icon size="S" hoverable name="MoreSmallList" />
   </div>
+  <MenuItem icon="Edit" on:click={updateDatasourceDialog.show}>Update</MenuItem>
   <MenuItem icon="Delete" on:click={confirmDeleteDialog.show}>Delete</MenuItem>
 </ActionMenu>
 
@@ -37,6 +40,7 @@
   <i>{datasource.name}?</i>
   This action cannot be undone.
 </ConfirmDialog>
+<UpdateDatasourceModal {datasource} bind:this={updateDatasourceDialog} />
 
 <style>
   div.icon {
diff --git a/packages/builder/src/stores/backend/datasources.js b/packages/builder/src/stores/backend/datasources.js
index bb4a94b63b..5c6ed3f2cb 100644
--- a/packages/builder/src/stores/backend/datasources.js
+++ b/packages/builder/src/stores/backend/datasources.js
@@ -59,9 +59,16 @@ export function createDatasourcesStore() {
       return json
     },
     save: async datasource => {
-      let url = "/api/datasources"
+      let response
+      if (datasource._id) {
+        response = await api.put(
+          `/api/datasources/${datasource._id}`,
+          datasource
+        )
+      } else {
+        response = await api.post("/api/datasources", datasource)
+      }
 
-      const response = await api.post(url, datasource)
       const json = await response.json()
 
       if (response.status !== 200) {
diff --git a/packages/server/src/api/controllers/datasource.js b/packages/server/src/api/controllers/datasource.js
index dabd5a6e96..df1cf7b40e 100644
--- a/packages/server/src/api/controllers/datasource.js
+++ b/packages/server/src/api/controllers/datasource.js
@@ -57,6 +57,28 @@ exports.buildSchemaFromDb = async function (ctx) {
   ctx.body = datasource
 }
 
+exports.update = async function (ctx) {
+  const db = new CouchDB(ctx.appId)
+  const datasourceId = ctx.params.datasourceId
+  const datasource = await db.get(datasourceId)
+  datasource.name = ctx.request.body.name
+
+  const response = await db.put(datasource)
+  datasource._rev = response.rev
+
+  // Drain connection pools when configuration is changed
+  if (datasource.source) {
+    const source = integrations[datasource.source]
+    if (source && source.pool) {
+      await source.pool.end()
+    }
+  }
+
+  ctx.status = 200
+  ctx.message = "Datasource saved successfully."
+  ctx.body = datasource
+}
+
 exports.save = async function (ctx) {
   const db = new CouchDB(ctx.appId)
   const plus = ctx.request.body.plus
diff --git a/packages/server/src/api/routes/datasource.js b/packages/server/src/api/routes/datasource.js
index e645cccd2b..ab5289176a 100644
--- a/packages/server/src/api/routes/datasource.js
+++ b/packages/server/src/api/routes/datasource.js
@@ -66,6 +66,11 @@ router
     authorized(PermissionTypes.TABLE, PermissionLevels.READ),
     datasourceController.find
   )
+  .put(
+    "/api/datasources/:datasourceId",
+    authorized(PermissionTypes.TABLE, PermissionLevels.READ),
+    datasourceController.update
+  )
   .post(
     "/api/datasources/query",
     authorized(PermissionTypes.TABLE, PermissionLevels.READ),

From 3b099d945a5c3d0c5edfe0e20112d99ee6d4a206 Mon Sep 17 00:00:00 2001
From: Maurits Lourens <maurits.lourens@gmail.com>
Date: Wed, 18 Aug 2021 00:04:54 +0200
Subject: [PATCH 2/2] fix lint issues

---
 packages/bbui/src/ActionMenu/ActionMenu.svelte               | 2 +-
 .../DatasourceNavigator/modals/UpdateDatasourceModal.svelte  | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/packages/bbui/src/ActionMenu/ActionMenu.svelte b/packages/bbui/src/ActionMenu/ActionMenu.svelte
index 1c05021d12..08425e8f59 100644
--- a/packages/bbui/src/ActionMenu/ActionMenu.svelte
+++ b/packages/bbui/src/ActionMenu/ActionMenu.svelte
@@ -23,7 +23,7 @@
     dropdown.show()
   }
 
-  const openMenu = (event) => {
+  const openMenu = event => {
     if (!disabled) {
       event.stopPropagation()
       show()
diff --git a/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte b/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte
index 44148ebb6e..561548fb59 100644
--- a/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte
+++ b/packages/builder/src/components/backend/DatasourceNavigator/modals/UpdateDatasourceModal.svelte
@@ -21,9 +21,7 @@
 
   function checkValid(evt) {
     const datasourceName = evt.target.value
-    if (
-      $datasources?.list.some(ds => ds.name === datasourceName)
-    ) {
+    if ($datasources?.list.some(ds => ds.name === datasourceName)) {
       error = `Datasource with name ${datasourceName} already exists. Please choose another name.`
       return
     }
@@ -59,4 +57,3 @@
     />
   </ModalContent>
 </Modal>
-