From f2e78ec4d500ae03b3bd1e2530c9e0893fdefe91 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Mon, 7 Oct 2024 16:39:44 +0100 Subject: [PATCH] Don't check required fields at all for calculation views. --- packages/server/src/sdk/app/views/index.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/server/src/sdk/app/views/index.ts b/packages/server/src/sdk/app/views/index.ts index 32fd696f20..fe2360f9d0 100644 --- a/packages/server/src/sdk/app/views/index.ts +++ b/packages/server/src/sdk/app/views/index.ts @@ -114,7 +114,11 @@ async function guardViewSchema( } await checkReadonlyFields(table, view) - checkRequiredFields(table, view) + + if (!helpers.views.isCalculationView(view)) { + checkRequiredFields(table, view) + } + checkDisplayField(view) } @@ -178,7 +182,7 @@ function checkRequiredFields( continue } - if (!helpers.views.isCalculationView(view) && !viewSchemaField?.visible) { + if (!viewSchemaField?.visible) { throw new HTTPError( `You can't hide "${field.name}" because it is a required field.`, 400 @@ -186,7 +190,6 @@ function checkRequiredFields( } if ( - viewSchemaField && helpers.views.isBasicViewField(viewSchemaField) && viewSchemaField.readonly ) {