MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make sure the user cannot enter the same column name as the old column for the migrated column.

This commit is contained in:
Sam Rose 2023-10-24 17:33:49 +01:00
parent d3670ddf21
commit f4c6ab7f48
No known key found for this signature in database
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/frontend-core/src/components/grid/cells/HeaderCell.svelte
View File

@ -18,7 +18,6 @@
export let orderable = true export let orderable = true
const { const {
API,
reorder, reorder,
isReordering, isReordering,
isResizing, isResizing,

10
packages/frontend-core/src/components/grid/controls/MigrationModal.svelte
View File

@ -12,6 +12,7 @@
export let column export let column
let newColumnName = `${column.schema.name} (migrated)` let newColumnName = `${column.schema.name} (migrated)`
$: newAndOldNameMatch = column.schema.name === newColumnName
const migrateUserColumn = async () => { const migrateUserColumn = async () => {
let subtype = "users" let subtype = "users"
@ -43,6 +44,7 @@
confirmText="Continue" confirmText="Continue"
cancelText="Cancel" cancelText="Cancel"
onConfirm={migrateUserColumn} onConfirm={migrateUserColumn}
disabled={newAndOldNameMatch}
size="M" size="M"
> >
This operation will kick off a migration of the column "{column.schema.name}" This operation will kick off a migration of the column "{column.schema.name}"
@ -54,5 +56,11 @@
header="Are you sure?" header="Are you sure?"
message="This will leave bindings which utilised the user relationship column in a state where they will need to be updated to use the new column instead." message="This will leave bindings which utilised the user relationship column in a state where they will need to be updated to use the new column instead."
/> />
<Input bind:value={newColumnName} label="New column name" /> <Input
bind:value={newColumnName}
label="New column name"
error={newAndOldNameMatch
? "New column name can't be the same as the existing column name"
: undefined}
/>
</ModalContent> </ModalContent>