Follow-up PR to bigint fixes.

packages/server/src/api/controllers/datasource.ts

@@ -23,13 +23,11 @@ import {
   Table,
   RowValue,
   DynamicVariable,
-  QueryJsonRequest,
 } from "@budibase/types"
 import sdk from "../../sdk"
 import { builderSocket } from "../../websockets"
 import { isEqual } from "lodash"
 import { processTable } from "../../sdk/app/tables/getters"
-import { makeExternalQuery } from "../../integrations/base/query"
 
 export async function fetch(ctx: UserCtx) {
   ctx.body = await sdk.datasources.fetch()

packages/server/src/integrations/base/query.ts

@@ -1,27 +1,39 @@
-import { DatasourcePlusQueryResponse, QueryJson } from "@budibase/types"
+import {
+  DatasourcePlusQueryResponse,
+  EnrichedQueryJson,
+  QueryJson,
+} from "@budibase/types"
 import { getIntegration } from "../index"
 import sdk from "../../sdk"
 import { enrichQueryJson } from "../../sdk/app/rows/utils"
 
+function isEnriched(
+  json: QueryJson | EnrichedQueryJson
+): json is EnrichedQueryJson {
+  return "datasource" in json
+}
+
 export async function makeExternalQuery(
-  json: QueryJson
+  json: QueryJson | EnrichedQueryJson
 ): Promise<DatasourcePlusQueryResponse> {
-  const enrichedJson = await enrichQueryJson(json)
+  if (!isEnriched(json)) {
-  if (!enrichedJson.datasource) {
+    json = await enrichQueryJson(json)
+    if (json.datasource) {
+      json.datasource = await sdk.datasources.enrich(json.datasource)
+    }
+  }
+
+  if (!json.datasource) {
     throw new Error("No datasource provided for external query")
   }
 
-  enrichedJson.datasource = await sdk.datasources.enrich(
+  const Integration = await getIntegration(json.datasource.source)
-    enrichedJson.datasource
-  )
-
-  const Integration = await getIntegration(enrichedJson.datasource.source)
 
   // query is the opinionated function
   if (!Integration.prototype.query) {
     throw "Datasource does not support query."
   }
 
-  const integration = new Integration(enrichedJson.datasource.config)
+  const integration = new Integration(json.datasource.config)
-  return integration.query(enrichedJson)
+  return integration.query(json)
 }

packages/server/src/integrations/microsoftSqlServer.ts

@@ -509,8 +509,8 @@ class SqlServerIntegration extends Sql implements DatasourcePlus {
   async query(json: EnrichedQueryJson): Promise<DatasourcePlusQueryResponse> {
     const schema = this.config.schema
     await this.connect()
-    if (schema && schema !== DEFAULT_SCHEMA && json?.endpoint) {
+    if (schema && schema !== DEFAULT_SCHEMA) {
-      json.endpoint.schema = schema
+      json.schema = schema
     }
     const operation = this._operation(json)
     const queryFn = (query: any, op: string) => this.internalQuery(query, op)

packages/server/src/integrations/oracle.ts

@@ -572,11 +572,7 @@ class OracleIntegration extends Sql implements DatasourcePlus {
         return response.rows as Row[]
       } else {
         // get the last row that was updated
-        if (
+        if (response.lastRowid && operation !== Operation.DELETE) {
-          response.lastRowid &&
-          json.endpoint?.entityId &&
-          operation !== Operation.DELETE
-        ) {
           const lastRow = await this.internalQuery({
             sql: `SELECT * FROM "${json.table.name}" WHERE ROWID = '${response.lastRowid}'`,
           })

packages/server/src/integrations/tests/sqlAlias.spec.ts

@@ -269,7 +269,7 @@ describe("Captures of real examples", () => {
       fields: string[] = ["a"]
     ): EnrichedQueryJson {
       return {
-        endpoint: { datasourceId: "", entityId: "", operation: op },
+        operation: op,
         resource: {
           fields,
         },

packages/server/src/tests/utilities/api/datasource.ts

@@ -4,7 +4,6 @@ import {
   Datasource,
   FetchDatasourceInfoResponse,
   FieldType,
-  QueryJsonRequest,
   RelationshipType,
   UpdateDatasourceRequest,
   UpdateDatasourceResponse,