From f72f3f88f7a8dff5749d4e2156c900af7114b02e Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Wed, 23 Aug 2023 10:49:48 +0100
Subject: [PATCH] Improve UX when resizing screen/component lists

---
 packages/builder/src/builderStore/index.js    |  4 +-
 .../_components/ScreenList/index.svelte       | 49 +++++++++++++++----
 2 files changed, 42 insertions(+), 11 deletions(-)

diff --git a/packages/builder/src/builderStore/index.js b/packages/builder/src/builderStore/index.js
index 3cd387fe95..dfb8609e65 100644
--- a/packages/builder/src/builderStore/index.js
+++ b/packages/builder/src/builderStore/index.js
@@ -4,7 +4,7 @@ import { getTemporalStore } from "./store/temporal"
 import { getThemeStore } from "./store/theme"
 import { getUserStore } from "./store/users"
 import { getDeploymentStore } from "./store/deployments"
-import { derived } from "svelte/store"
+import { derived, writable } from "svelte/store"
 import { findComponent, findComponentPath } from "./componentUtils"
 import { RoleUtils } from "@budibase/frontend-core"
 import { createHistoryStore } from "builderStore/store/history"
@@ -147,3 +147,5 @@ export const userSelectedResourceMap = derived(userStore, $userStore => {
 export const isOnlyUser = derived(userStore, $userStore => {
   return $userStore.length < 2
 })
+
+export const screensHeight = writable("210px")
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/ScreenList/index.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/ScreenList/index.svelte
index 9324b2073d..0ecc9b76bf 100644
--- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/ScreenList/index.svelte
+++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/_components/ScreenList/index.svelte
@@ -1,20 +1,25 @@
 <script>
   import { Icon, Layout, Body } from "@budibase/bbui"
-  import { store, sortedScreens, userSelectedResourceMap } from "builderStore"
+  import {
+    store,
+    sortedScreens,
+    userSelectedResourceMap,
+    screensHeight,
+  } from "builderStore"
   import NavItem from "components/common/NavItem.svelte"
   import RoleIndicator from "./RoleIndicator.svelte"
   import DropdownMenu from "./DropdownMenu.svelte"
   import NewScreen from "components/design/NewScreen/index.svelte"
-  import { tick } from "svelte"
+  import { onMount, tick } from "svelte"
 
   let newScreen = false
   let search = false
   let resizing = false
   let searchValue = ""
   let searchInput
+  let container
   let screensContainer
   let scrolling = false
-  let height = "210px"
   let previousHeight = null
   let dragOffset
 
@@ -27,14 +32,14 @@
     await tick()
     searchInput.focus()
     screensContainer.scroll({ top: 0, behavior: "smooth" })
-    previousHeight = height
-    height = "calc(100% + 1px)"
+    previousHeight = $screensHeight
+    $screensHeight = "calc(100% + 1px)"
   }
 
   const closeSearch = async () => {
     if (previousHeight) {
       // Restore previous height and wait for animation
-      height = previousHeight
+      $screensHeight = previousHeight
       previousHeight = null
       await sleep(300)
     }
@@ -71,28 +76,48 @@
   }
 
   const startResizing = e => {
+    // Reset the height store to match the true height
+    $screensHeight = `${container.getBoundingClientRect().height}px`
+
+    // Store an offset to easily compute new height when moving the mouse
+    dragOffset = parseInt($screensHeight) - e.clientY
+
+    // Add event listeners
     resizing = true
-    dragOffset = parseInt(height) - e.clientY
     document.addEventListener("mousemove", resize)
     document.addEventListener("mouseup", stopResizing)
   }
 
   const resize = e => {
+    // Prevent negative heights as this screws with layout
     const newHeight = Math.max(0, e.clientY + dragOffset)
     if (newHeight == null || isNaN(newHeight)) {
       return
     }
-    height = `${newHeight}px`
+    $screensHeight = `${newHeight}px`
   }
 
   const stopResizing = () => {
     resizing = false
     document.removeEventListener("mousemove", resize)
   }
+
+  onMount(() => {
+    // Ensure we aren't stuck at 100% height from leaving while searching
+    if ($screensHeight == null || isNaN(parseInt($screensHeight))) {
+      $screensHeight = "210px"
+    }
+  })
 </script>
 
 <svelte:window on:keydown={onKeyDown} />
-<div class="screens" class:search class:resizing style={`height:${height};`}>
+<div
+  class="screens"
+  class:search
+  class:resizing
+  style={`height:${$screensHeight};`}
+  bind:this={container}
+>
   <div class="header" class:scrolling>
     <input
       readonly={!search}
@@ -143,7 +168,11 @@
     {/if}
   </div>
 
-  <div class="divider" on:mousedown={startResizing} />
+  <div
+    class="divider"
+    on:mousedown={startResizing}
+    on:dblclick={() => screensHeight.set("210px")}
+  />
 </div>
 
 <div class="newScreen" class:newScreenVisible={newScreen}>