From 1d0a42b59fb2c1482e55c466703e6470028f75b7 Mon Sep 17 00:00:00 2001 From: Martin McKeaveney Date: Tue, 12 Sep 2023 11:26:26 +0100 Subject: [PATCH 1/2] pin version of postgres in QA core tests so it works with pg dump --- .../integrations/external-schema/postgres.integration.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa-core/src/integrations/external-schema/postgres.integration.spec.ts b/qa-core/src/integrations/external-schema/postgres.integration.spec.ts index 762a16b221..bb7c8de932 100644 --- a/qa-core/src/integrations/external-schema/postgres.integration.spec.ts +++ b/qa-core/src/integrations/external-schema/postgres.integration.spec.ts @@ -18,7 +18,7 @@ describe("getExternalSchema", () => { beforeAll(async () => { // This is left on propose without a tag, so if a new version introduces a breaking change we will be notified - const container = await new GenericContainer("postgres") + const container = await new GenericContainer("postgres:13.12") .withExposedPorts(5432) .withEnv("POSTGRES_PASSWORD", "password") .start() From 9fc1811b0c2b7a72c8e6ae5e575c922efaff6085 Mon Sep 17 00:00:00 2001 From: Martin McKeaveney Date: Tue, 12 Sep 2023 11:26:38 +0100 Subject: [PATCH 2/2] remove comment --- .../integrations/external-schema/postgres.integration.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/qa-core/src/integrations/external-schema/postgres.integration.spec.ts b/qa-core/src/integrations/external-schema/postgres.integration.spec.ts index bb7c8de932..a0812c9677 100644 --- a/qa-core/src/integrations/external-schema/postgres.integration.spec.ts +++ b/qa-core/src/integrations/external-schema/postgres.integration.spec.ts @@ -17,7 +17,6 @@ describe("getExternalSchema", () => { } beforeAll(async () => { - // This is left on propose without a tag, so if a new version introduces a breaking change we will be notified const container = await new GenericContainer("postgres:13.12") .withExposedPorts(5432) .withEnv("POSTGRES_PASSWORD", "password")