From b44a7fb2881a7a7a54bd2e966bd842d22b904a00 Mon Sep 17 00:00:00 2001 From: Dean Date: Thu, 1 Jun 2023 14:44:03 +0100 Subject: [PATCH 1/2] Restored the default behaviour for tab switching when no switch checking fn is provided --- packages/bbui/src/Tabs/Tabs.svelte | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/bbui/src/Tabs/Tabs.svelte b/packages/bbui/src/Tabs/Tabs.svelte index 4cc22b226e..7cb77bc976 100644 --- a/packages/bbui/src/Tabs/Tabs.svelte +++ b/packages/bbui/src/Tabs/Tabs.svelte @@ -37,6 +37,10 @@ dispatch("select", thisSelected) } } + } else { + thisSelected = $tab.title + selected = $tab.title + dispatch("select", thisSelected) } if ($tab.title !== thisSelected) { tab.update(state => { From 3a70426e3eb5c21b1fc85e94875139d86deb322c Mon Sep 17 00:00:00 2001 From: Dean Date: Thu, 1 Jun 2023 14:51:50 +0100 Subject: [PATCH 2/2] Tab switch default behaviour shifted to correct location --- packages/bbui/src/Tabs/Tabs.svelte | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/bbui/src/Tabs/Tabs.svelte b/packages/bbui/src/Tabs/Tabs.svelte index 7cb77bc976..9c3d25a807 100644 --- a/packages/bbui/src/Tabs/Tabs.svelte +++ b/packages/bbui/src/Tabs/Tabs.svelte @@ -36,11 +36,11 @@ selected = $tab.title dispatch("select", thisSelected) } + } else { + thisSelected = $tab.title + selected = $tab.title + dispatch("select", thisSelected) } - } else { - thisSelected = $tab.title - selected = $tab.title - dispatch("select", thisSelected) } if ($tab.title !== thisSelected) { tab.update(state => {