From fac9c35bce61017fdc081383b249449fd2e83e99 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Thu, 11 Jul 2024 10:46:29 +0200
Subject: [PATCH] Simplify tests

---
 .../src/api/routes/tests/rowAction.spec.ts    | 75 +++++++++++--------
 .../src/tests/utilities/api/rowAction.ts      | 19 +++--
 2 files changed, 54 insertions(+), 40 deletions(-)

diff --git a/packages/server/src/api/routes/tests/rowAction.spec.ts b/packages/server/src/api/routes/tests/rowAction.spec.ts
index 6281023991..ebf0e76c09 100644
--- a/packages/server/src/api/routes/tests/rowAction.spec.ts
+++ b/packages/server/src/api/routes/tests/rowAction.spec.ts
@@ -4,6 +4,7 @@ import tk from "timekeeper"
 import { CreateRowActionRequest } from "@budibase/types"
 import * as setup from "./utilities"
 import { generator } from "@budibase/backend-core/tests"
+import { Expectations } from "src/tests/utilities/api/base"
 
 describe("/rowsActions", () => {
   const config = setup.getConfig()
@@ -22,6 +23,23 @@ describe("/rowsActions", () => {
 
   afterAll(setup.afterAll)
 
+  async function createRowAction(
+    tableId: string,
+    rowAction: CreateRowActionRequest,
+    expectations?: Expectations,
+    opts?: { publicUser?: boolean }
+  ) {
+    return await config.api.rowAction.save(
+      tableId,
+      rowAction,
+      {
+        ...expectations,
+        status: expectations?.status || 201,
+      },
+      opts
+    )
+  }
+
   function createRowActionRequest(): CreateRowActionRequest {
     return {
       name: generator.word(),
@@ -30,7 +48,7 @@ describe("/rowsActions", () => {
 
   function unauthorisedTests() {
     it("returns unauthorised (401) for unauthenticated requests", async () => {
-      await config.api.rowAction.save(
+      await createRowAction(
         tableId,
         createRowActionRequest(),
         {
@@ -48,20 +66,16 @@ describe("/rowsActions", () => {
         builder: {},
       })
       await config.withUser(user, async () => {
-        await config.api.rowAction.save(
-          generator.guid(),
-          createRowActionRequest(),
-          { status: 403 }
-        )
+        await createRowAction(generator.guid(), createRowActionRequest(), {
+          status: 403,
+        })
       })
     })
 
     it("rejects (404) for a non-existing table", async () => {
-      await config.api.rowAction.save(
-        generator.guid(),
-        createRowActionRequest(),
-        { status: 404 }
-      )
+      await createRowAction(generator.guid(), createRowActionRequest(), {
+        status: 404,
+      })
     })
   }
 
@@ -71,9 +85,7 @@ describe("/rowsActions", () => {
     it("creates new row actions for tables without existing actions", async () => {
       const rowAction = createRowActionRequest()
 
-      const res = await config.api.rowAction.save(tableId, rowAction, {
-        status: 201,
-      })
+      const res = await createRowAction(tableId, rowAction, { status: 201 })
 
       expect(res).toEqual({
         _id: `${tableId}_row_actions`,
@@ -88,15 +100,9 @@ describe("/rowsActions", () => {
     it("can create multiple row actions for the same table", async () => {
       const rowActions = generator.unique(() => createRowActionRequest(), 3)
 
-      await config.api.rowAction.save(tableId, rowActions[0], {
-        status: 201,
-      })
-      await config.api.rowAction.save(tableId, rowActions[1], {
-        status: 201,
-      })
-      const res = await config.api.rowAction.save(tableId, rowActions[2], {
-        status: 201,
-      })
+      await createRowAction(tableId, rowActions[0])
+      await createRowAction(tableId, rowActions[1])
+      const res = await createRowAction(tableId, rowActions[2])
 
       expect(res).toEqual({
         _id: `${tableId}_row_actions`,
@@ -117,12 +123,8 @@ describe("/rowsActions", () => {
       const rowAction1 = createRowActionRequest()
       const rowAction2 = createRowActionRequest()
 
-      const res1 = await config.api.rowAction.save(tableId, rowAction1, {
-        status: 201,
-      })
-      const res2 = await config.api.rowAction.save(otherTableId, rowAction2, {
-        status: 201,
-      })
+      const res1 = await createRowAction(tableId, rowAction1)
+      const res2 = await createRowAction(otherTableId, rowAction2)
 
       expect(res1).toEqual({
         _id: `${tableId}_row_actions`,
@@ -148,7 +150,7 @@ describe("/rowsActions", () => {
         name: "",
       }
 
-      await config.api.rowAction.save(tableId, rowAction, {
+      await createRowAction(tableId, rowAction, {
         status: 400,
         body: {
           message: 'Invalid body - "name" is not allowed to be empty',
@@ -165,5 +167,18 @@ describe("/rowsActions", () => {
 
       expect(res).toEqual({ tableId, actions: [] })
     })
+
+    it("returns only the", async () => {
+      const rowActions = generator.unique(() => createRowActionRequest(), 5)
+      for (const rowAction of rowActions) {
+        await createRowAction(tableId, rowAction)
+      }
+
+      const otherTable = await config.api.table.save(
+        setup.structures.basicTable()
+      )
+      const otherTableId = otherTable._id!
+      await createRowAction(otherTableId, createRowActionRequest())
+    })
   })
 })
diff --git a/packages/server/src/tests/utilities/api/rowAction.ts b/packages/server/src/tests/utilities/api/rowAction.ts
index a78633681e..583475b666 100644
--- a/packages/server/src/tests/utilities/api/rowAction.ts
+++ b/packages/server/src/tests/utilities/api/rowAction.ts
@@ -1,8 +1,4 @@
-import {
-  CreateRowActionRequest,
-  RowAction,
-  RowActionsResponse,
-} from "@budibase/types"
+import { CreateRowActionRequest, RowActionsResponse } from "@budibase/types"
 import { Expectations, TestAPI } from "./base"
 
 export class RowActionAPI extends TestAPI {
@@ -12,11 +8,14 @@ export class RowActionAPI extends TestAPI {
     expectations?: Expectations,
     config?: { publicUser?: boolean }
   ) => {
-    return await this._post<RowAction>(`/api/tables/${tableId}/actions`, {
-      body: rowAction,
-      expectations,
-      ...config,
-    })
+    return await this._post<RowActionsResponse>(
+      `/api/tables/${tableId}/actions`,
+      {
+        body: rowAction,
+        expectations,
+        ...config,
+      }
+    )
   }
 
   find = async (