From bd908a6e67a96bf26f6e72cd9c2334f74ab10e57 Mon Sep 17 00:00:00 2001 From: Joe <49767913+joebudi@users.noreply.github.com> Date: Tue, 9 Jun 2020 11:06:18 +0100 Subject: [PATCH 1/3] Image Component Image component added to builder --- .../userInterface/temporaryPanelStructure.js | 11 +++++++++++ packages/standard-components/src/Image.svelte | 2 ++ 2 files changed, 13 insertions(+) diff --git a/packages/builder/src/components/userInterface/temporaryPanelStructure.js b/packages/builder/src/components/userInterface/temporaryPanelStructure.js index 603e348e18..a2916ca710 100644 --- a/packages/builder/src/components/userInterface/temporaryPanelStructure.js +++ b/packages/builder/src/components/userInterface/temporaryPanelStructure.js @@ -187,6 +187,17 @@ export default { ], }, }, + { + _component: "@budibase/standard-components/image", + name: "Image", + description: "A basic component for displaying images", + icon: "ri-image-fill", + children: [], + properties: { + design: { ...all }, + settings: [{label: "URL", key: "url", control: Input }], + }, + }, { _component: "@budibase/standard-components/icon", name: "Icon", diff --git a/packages/standard-components/src/Image.svelte b/packages/standard-components/src/Image.svelte index 84f515b287..cd204f5fc2 100644 --- a/packages/standard-components/src/Image.svelte +++ b/packages/standard-components/src/Image.svelte @@ -7,6 +7,8 @@ export let height export let width + export let _bb + $: style = buildStyle({ height, width }) From 67868eb9d3eb43b713fc24c3581339f70506975c Mon Sep 17 00:00:00 2001 From: Joe <49767913+joebudi@users.noreply.github.com> Date: Tue, 9 Jun 2020 11:49:06 +0100 Subject: [PATCH 2/3] formatting --- .../src/components/userInterface/temporaryPanelStructure.js | 2 +- packages/standard-components/src/DataForm.svelte | 1 - packages/standard-components/src/DataTable.svelte | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/builder/src/components/userInterface/temporaryPanelStructure.js b/packages/builder/src/components/userInterface/temporaryPanelStructure.js index a2916ca710..afd3a06694 100644 --- a/packages/builder/src/components/userInterface/temporaryPanelStructure.js +++ b/packages/builder/src/components/userInterface/temporaryPanelStructure.js @@ -195,7 +195,7 @@ export default { children: [], properties: { design: { ...all }, - settings: [{label: "URL", key: "url", control: Input }], + settings: [{ label: "URL", key: "url", control: Input }], }, }, { diff --git a/packages/standard-components/src/DataForm.svelte b/packages/standard-components/src/DataForm.svelte index ab515551dd..6a9788458e 100644 --- a/packages/standard-components/src/DataForm.svelte +++ b/packages/standard-components/src/DataForm.svelte @@ -87,7 +87,6 @@ .form-content { margin-bottom: 20px; - } .input { diff --git a/packages/standard-components/src/DataTable.svelte b/packages/standard-components/src/DataTable.svelte index c0db923d58..90716383da 100644 --- a/packages/standard-components/src/DataTable.svelte +++ b/packages/standard-components/src/DataTable.svelte @@ -65,7 +65,7 @@ } thead { - background: #393C44; + background: #393c44; border: 1px solid #ccc; height: 40px; text-align: left; @@ -87,7 +87,7 @@ tbody tr { border-bottom: 1px solid #ccc; transition: 0.3s background-color; - color: #393C44; + color: #393c44; font-size: 14px; height: 40px; } From 96d52bf6e85d8b794a0b23c78d65e0b9c28ae34a Mon Sep 17 00:00:00 2001 From: Conor_Mack Date: Wed, 10 Jun 2020 10:16:38 +0100 Subject: [PATCH 3/3] Fix - No Page Props on Master Screen Components --- .../components/userInterface/ComponentPropertiesPanel.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/builder/src/components/userInterface/ComponentPropertiesPanel.svelte b/packages/builder/src/components/userInterface/ComponentPropertiesPanel.svelte index caef9eb2fd..71a5c019fc 100644 --- a/packages/builder/src/components/userInterface/ComponentPropertiesPanel.svelte +++ b/packages/builder/src/components/userInterface/ComponentPropertiesPanel.svelte @@ -47,7 +47,7 @@ panelDefinition = componentPropDefinition.properties["design"] }else{ let panelDef = componentPropDefinition.properties["settings"] - if($store.currentFrontEndType === "page") { + if($store.currentFrontEndType === "page" && $store.currentView !== "component") { panelDefinition = [...page,...panelDef] }else if($store.currentFrontEndType === "screen" && $store.currentView !== "component") { panelDefinition = [...screen, ...panelDef]