MirrorSave
/
budibase
mirror of https://github.com/Budibase/budibase.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix tests.

This commit is contained in:
Sam Rose 2024-09-20 11:52:06 +01:00
parent 9588192a52
commit fc44b38fc5
No known key found for this signature in database
2 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/server/src/api/routes/tests/viewV2.spec.ts
View File

@ -37,13 +37,13 @@ import {
import sdk from "../../../sdk" import sdk from "../../../sdk"
describe.each([ describe.each([
// ["lucene", undefined], ["lucene", undefined],
["sqs", undefined], ["sqs", undefined],
// [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)], [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)],
// [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)], [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)],
// [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)], [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)],
// [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)], [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)],
// [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)], [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)],
])("/v2/views (%s)", (name, dsProvider) => { ])("/v2/views (%s)", (name, dsProvider) => {
const config = setup.getConfig() const config = setup.getConfig()
const isSqs = name === "sqs" const isSqs = name === "sqs"
@ -2295,7 +2295,7 @@ describe.each([
) )
}) })
describe("calculations", () => { describe.skip("calculations", () => {
let table: Table let table: Table
let rows: Row[] let rows: Row[]
@ -2325,7 +2325,7 @@ describe.each([
) )
}) })
it.only("should be able to search by calculations", async () => { it("should be able to search by calculations", async () => {
const view = await config.api.viewV2.create({ const view = await config.api.viewV2.create({
tableId: table._id!, tableId: table._id!,
name: generator.guid(), name: generator.guid(),

6
packages/shared-core/src/helpers/views.ts
View File

@ -25,15 +25,9 @@ export function isCalculationView(view: UnsavedViewV2) {
} }
export function calculationFields(view: UnsavedViewV2) { export function calculationFields(view: UnsavedViewV2) {
if (!isCalculationView(view)) {
throw new Error("View is not a calculation view")
}
return pickBy(view.schema || {}, isCalculationField) return pickBy(view.schema || {}, isCalculationField)
} }
export function basicFields(view: UnsavedViewV2) { export function basicFields(view: UnsavedViewV2) {
if (!isCalculationView(view)) {
throw new Error("View is not a calculation view")
}
return pickBy(view.schema || {}, field => !isCalculationField(field)) return pickBy(view.schema || {}, field => !isCalculationField(field))
} }