From 215e35961504c22d56d5f4238e6dd18173690d2c Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Fri, 4 Oct 2024 09:29:41 +0100 Subject: [PATCH 1/3] Add uiMetadata to viewV2 --- packages/server/src/api/controllers/view/viewsV2.ts | 2 ++ packages/types/src/documents/app/view.ts | 1 + 2 files changed, 3 insertions(+) diff --git a/packages/server/src/api/controllers/view/viewsV2.ts b/packages/server/src/api/controllers/view/viewsV2.ts index 0257c86ded..22a9b85c3e 100644 --- a/packages/server/src/api/controllers/view/viewsV2.ts +++ b/packages/server/src/api/controllers/view/viewsV2.ts @@ -107,6 +107,7 @@ export async function create(ctx: Ctx) { sort: view.sort, schema, primaryDisplay: view.primaryDisplay, + uiMetadata: view.uiMetadata, } const result = await sdk.views.create(tableId, parsedView) ctx.status = 201 @@ -143,6 +144,7 @@ export async function update(ctx: Ctx) { sort: view.sort, schema, primaryDisplay: view.primaryDisplay, + uiMetadata: view.uiMetadata, } const result = await sdk.views.update(tableId, parsedView) diff --git a/packages/types/src/documents/app/view.ts b/packages/types/src/documents/app/view.ts index 77bbb3e4d1..f836e18f24 100644 --- a/packages/types/src/documents/app/view.ts +++ b/packages/types/src/documents/app/view.ts @@ -74,6 +74,7 @@ export interface ViewV2 { type?: SortType } schema?: ViewV2Schema + uiMetadata?: Record } export type ViewV2Schema = Record From a563adc2c07e721a96a2c52571decf89e29ba5d3 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Fri, 4 Oct 2024 09:43:23 +0100 Subject: [PATCH 2/3] Update tests --- packages/server/src/api/routes/tests/viewV2.spec.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts index 83b26bc687..7bfa52e0b4 100644 --- a/packages/server/src/api/routes/tests/viewV2.spec.ts +++ b/packages/server/src/api/routes/tests/viewV2.spec.ts @@ -177,6 +177,9 @@ describe.each([ visible: true, }, }, + uiMetadata: { + foo: "bar", + }, } const res = await config.api.viewV2.create(newView) @@ -640,6 +643,9 @@ describe.each([ readonly: true, }, }, + uiMetadata: { + foo: "bar", + }, } await config.api.viewV2.update(updatedData) From de825defcc1ebeb965d706434542bd9af0ea7320 Mon Sep 17 00:00:00 2001 From: Christos Alexiou Date: Fri, 4 Oct 2024 15:12:18 +0300 Subject: [PATCH 3/3] Remove PAYLOAD_DEPLOY to enable invisible license rollouts --- .github/workflows/deploy-featurebranch.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/deploy-featurebranch.yml b/.github/workflows/deploy-featurebranch.yml index 463074e836..d86d301507 100644 --- a/.github/workflows/deploy-featurebranch.yml +++ b/.github/workflows/deploy-featurebranch.yml @@ -23,7 +23,6 @@ jobs: PAYLOAD_BRANCH: ${{ github.head_ref }} PAYLOAD_PR_NUMBER: ${{ github.event.pull_request.number }} PAYLOAD_LICENSE_TYPE: "free" - PAYLOAD_DEPLOY: true with: repository: budibase/budibase-deploys event: featurebranch-qa-deploy