Commit Graph

4193 Commits

Author SHA1 Message Date
mike12345567 9fb1c6b988 When searching by row ID with external DBs/SQS we can get into a situation where the limit of 1 which is applied by the frontend can cause problems, with many to many relationships we need to retrieve multiple rows (all of the joined related rows). This was raised by poirazis, it exhibits itself in one part of the platform, when attempting to a row by ID in a form block that has multiple many to many relationships. The frontend needs to be able to send a limit of 1 incase it is using a form block but hasn't gotten a row ID (this can happen in preview/the builder) and it just wants to populate with a row for display. 2024-07-26 16:23:46 +01:00
Adria Navarro 8421a75328
Merge branch 'master' into BUDI-8441/row-action-run-api 2024-07-26 15:16:21 +02:00
Adria Navarro f2cd589aae
Merge branch 'master' into chore/renames 2024-07-26 14:42:08 +02:00
Adria Navarro ee74a84339 Remove duplicates 2024-07-26 14:36:41 +02:00
Adria Navarro a05ec1498f Allow importing internal tables 2024-07-26 13:27:51 +02:00
Adria Navarro afdf6a8fa5 Change imports 2024-07-25 16:46:37 +02:00
Adria Navarro 7ffe8d4b4a Fix barrelfile issue 2024-07-25 16:40:49 +02:00
Adria Navarro beaabdd64a Allow row actions running for dev apps 2024-07-25 15:54:38 +02:00
Sam Rose 20bad903cc
Merge branch 'master' of github.com:budibase/budibase into test-oracle 2024-07-25 09:38:41 +01:00
Adria Navarro f7a460a1ea Implement run 2024-07-25 08:38:11 +02:00
Adria Navarro 890d573cac Add validators 2024-07-25 08:37:41 +02:00
Adria Navarro 7bad3ad39c Start implementing row action trigger 2024-07-25 08:36:31 +02:00
Adria Navarro e161c998ca
Merge branch 'master' into feat/row-actions 2024-07-24 15:48:38 +02:00
Sam Rose c7c2cb48e8
wip 2024-07-23 14:41:34 +01:00
Adria Navarro 4169842018 Fix get 2024-07-23 15:22:26 +02:00
Adria Navarro 75609b2a9b Move row.find to sdk 2024-07-23 15:16:15 +02:00
Adria Navarro 66a2b29ca2 Clean unnecessary ctx 2024-07-23 15:06:00 +02:00
Adria Navarro 89173be9f4 Remove controller dependency 2024-07-23 15:03:44 +02:00
Adria Navarro 8a12523bcc Add find by usermetadata test 2024-07-23 14:58:21 +02:00
Adria Navarro a03094db33 Use 422 instead of 400 trying to delete row action automations 2024-07-23 12:21:52 +02:00
Adria Navarro b4767cea7c Add checks to shared-core 2024-07-23 12:07:05 +02:00
Adria Navarro 35bbccec67 Return 400 instead of 403 2024-07-23 11:59:14 +02:00
Adria Navarro 8678db18e2 Add tests 2024-07-23 10:46:11 +02:00
Adria Navarro d9029da533 Don't allow deleting row action automations 2024-07-23 10:28:57 +02:00
Adria Navarro b7fc1cddb7 Merge branch 'master' into feat/row-actions 2024-07-23 10:03:41 +02:00
mike12345567 3ed1c43915 PR comments. 2024-07-22 16:47:37 +01:00
mike12345567 3247e13a32 Test case. 2024-07-22 15:17:42 +01:00
Adria Navarro 286883da14 Types 2024-07-22 14:39:26 +02:00
Adria Navarro d6e268d475 Fix tests 2024-07-22 14:31:59 +02:00
Adria Navarro 7574b27b4b Fix tests 2024-07-22 14:31:59 +02:00
Adria Navarro 3c9c988d8c Populate table name 2024-07-22 14:31:59 +02:00
Adria Navarro b7a969280f Display data 2024-07-22 14:31:42 +02:00
Adria Navarro 6221b9320e Enrich 2024-07-22 14:31:00 +02:00
Adria Navarro 67619364b9 Use expectAutomationId() 2024-07-22 14:23:17 +02:00
Adria Navarro 491266c7ba Add more tests 2024-07-22 14:23:17 +02:00
Adria Navarro 292c87350a Check automation creation 2024-07-22 14:23:17 +02:00
Adria Navarro eaa38c5c2d Return automationid from row action api 2024-07-22 14:23:17 +02:00
Adria Navarro 2970bfc48a Fix update and tests 2024-07-22 14:23:16 +02:00
Sam Rose 41bc9b87c3
Fix tests. 2024-07-19 15:46:48 +01:00
Sam Rose 1704d0e69f
Respond to PR comments. 2024-07-19 15:10:02 +01:00
Sam Rose 3c18cf7c34
Fix tests. 2024-07-19 15:08:48 +01:00
Sam Rose ca31add039
Don't allow a column to be both required and have a default value. 2024-07-19 15:08:48 +01:00
Sam Rose 8a49953449
Merge branch 'master' of github.com:budibase/budibase into budi-8434-default-value-row-processing 2024-07-19 15:03:19 +01:00
Sam Rose df765c1dc7
Merge branch 'master' of github.com:budibase/budibase into support-spaces-as-last-char-in-column-sqs 2024-07-18 11:12:25 +01:00
Sam Rose 5bbdcc1298
Remove unused function. 2024-07-18 11:08:42 +01:00
Sam Rose 0b2a5162a4
Fix the problem, and the tests. 2024-07-18 11:00:10 +01:00
Peter Clement 7fd55fe27d
Automation trigger filtering (#14123)
* backend for triggering automation based on filters

* frontend for handling triggering automations on filter / old row

* lint and bug fix

* fix issue with test header

* make test data optional

* improve safety on trigger gate

* add support for running trigger with filter if no change happened but filter matches

* update var naming to actually make sense

* tests

* fix lint

* improve gating for shouldTrigger check

* remove unecessary cast

* unecessary tableId check

* frontend text updates

* resolving comments

* pro

* Update packages/types/src/documents/app/automation.ts

Co-authored-by: Sam Rose <hello@samwho.dev>

* link out to docs for trigger filtering

* fix pro

* more pr comments

* use getAppId

---------

Co-authored-by: Sam Rose <hello@samwho.dev>
2024-07-18 10:38:15 +01:00
Sam Rose aea9cda8f5
wip 2024-07-17 15:45:35 +01:00
Adria Navarro 88aa0fc9cf Fix types 2024-07-17 16:40:19 +02:00
Adria Navarro 812afdb85e Fix tests (breaking because of mutating objects...) 2024-07-17 16:28:46 +02:00
Adria Navarro 53d6219b79 Extract find and fetch 2024-07-17 13:32:45 +02:00
Adria Navarro dc47037dbb Move update and remove 2024-07-17 13:26:40 +02:00
Adria Navarro 373aeac00f Move automation creation to sdk 2024-07-17 13:10:19 +02:00
Adria Navarro 13c6ad9924 More tests 2024-07-17 12:30:31 +02:00
Adria Navarro 371a3ad8ec Ensure unique on updates 2024-07-17 12:26:36 +02:00
Adria Navarro 8297a58270 Ensure unique names 2024-07-17 12:18:09 +02:00
Adria Navarro c51d2cd431 Trims names 2024-07-17 12:16:14 +02:00
Adria Navarro 7fb13b757b Use .string instead of .work 2024-07-17 11:52:29 +02:00
Adria Navarro b1cfdc4f25 Clean code 2024-07-17 11:15:55 +02:00
Adria Navarro 9a7470a943
Merge branch 'master' into BUDI-8428/row-action-crud 2024-07-17 11:08:23 +02:00
Sam Rose dc913385f6
Merge branch 'master' of github.com:budibase/budibase into budi-8434-default-value-row-processing 2024-07-15 16:48:36 +01:00
Sam Rose 9542c497de
Create a test for required column with default value. 2024-07-15 16:46:20 +01:00
Sam Rose e39a5b0d7e
Add test for creating a row through views. 2024-07-15 16:44:43 +01:00
Sam Rose 18acaccfcb
Current User binding and tests. 2024-07-15 16:26:15 +01:00
Sam Rose ee0c4187c8
Better error handling of invalid default values. 2024-07-15 12:09:01 +01:00
Sam Rose 297e9003ca
Support bindings in default values. 2024-07-15 11:10:30 +01:00
Sam Rose 12911db06e
Process primitive default values. 2024-07-15 10:43:58 +01:00
Sam Rose 43de204ca2
Default values failing test. 2024-07-15 09:58:31 +01:00
mike12345567 19ff925dec Adding test cases for less than/greater than or equal to, there was no test cases confirming these definitely work. Also aligning the test cases with how the frontend performs these tests today. 2024-07-12 18:09:29 +01:00
Adria Navarro f06d0a5cd6 Clean 2024-07-12 12:17:37 +02:00
Adria Navarro 50c8449f4b Add extra test 2024-07-12 12:17:37 +02:00
Adria Navarro 99b4aae7de
Merge branch 'master' into BUDI-8428/row-action-crud 2024-07-12 11:53:12 +02:00
Adria Navarro 0e8d216e22 Unify newid 2024-07-12 11:36:18 +02:00
Adria Navarro b44397d027 Dont return couch fields 2024-07-12 11:29:00 +02:00
Adria Navarro c0a0e860fa
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-12 11:07:11 +02:00
Sam Rose 4c4e7c12de
Fix a very rare flake in row.spec.ts. 2024-07-12 09:39:38 +01:00
Adria Navarro 1f2dab71eb
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-12 01:34:17 +02:00
Adria Navarro 2035713b9c Implement delete 2024-07-11 17:33:40 +02:00
Adria Navarro ba2d6fd73b Renames 2024-07-11 17:16:14 +02:00
Adria Navarro 9ff3d8cf77 Add extra tests 2024-07-11 17:14:14 +02:00
Adria Navarro d03a0ebb68 Implement update 2024-07-11 17:08:57 +02:00
Adria Navarro 1be14f5a05
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-11 16:59:34 +02:00
Adria Navarro 17fc605e4f Persist as object instead of array 2024-07-11 16:57:32 +02:00
Sam Rose db9e0e7d38
Fix fun flake in MySQL / MariaDB. 2024-07-11 15:54:52 +01:00
Adria Navarro de04a6f76d Change id 2024-07-11 15:34:48 +02:00
Adria Navarro 3bcbb57baa Add id to each individual action 2024-07-11 15:32:25 +02:00
Adria Navarro 65d7656097 Unify newid 2024-07-11 15:27:48 +02:00
Adria Navarro 55c72c7150 Add tests 2024-07-11 14:12:43 +02:00
Adria Navarro 2d8361d6fd Always return when table exists 2024-07-11 11:06:36 +02:00
Adria Navarro c565e35b53 Implement find 2024-07-11 10:59:11 +02:00
Adria Navarro fac9c35bce Simplify tests 2024-07-11 10:46:29 +02:00
Adria Navarro 645abea2cd Add extra tests 2024-07-11 10:19:11 +02:00
Adria Navarro 0831b7cf3f Add extra tests 2024-07-11 10:13:28 +02:00
Adria Navarro 7dbfcc398e Implement create 2024-07-11 10:04:25 +02:00
Adria Navarro 063eeeb6df Fix 2024-07-10 15:49:13 +02:00
Adria Navarro fe31f88cc8 Add validation 2024-07-10 15:48:16 +02:00
Adria Navarro bf161d9d93 More types 2024-07-10 15:41:55 +02:00
Adria Navarro c1eafe5b28 Fix 2024-07-10 14:05:21 +02:00
Adria Navarro 0c2024bf6a Basic get 2024-07-10 13:56:41 +02:00
Adria Navarro de2938799b Initial test 2024-07-10 13:47:34 +02:00
Adria Navarro 38718968b0 Basic implementation 2024-07-10 13:47:34 +02:00
Adria Navarro dfda2f0f54 Register router 2024-07-10 13:47:34 +02:00
Adria Navarro 107bd08e21 Endpoint scaffolding 2024-07-10 13:47:34 +02:00
Adria Navarro 3f5161aaf7 Fix tests 2024-07-10 13:36:07 +02:00
Michael Drury 55f6610f0d
Merge branch 'master' into fix/correcting-multi-relationships 2024-07-10 12:01:06 +01:00
Sam Rose 551d413900
Merge branch 'master' into sqs-per-tenant 2024-07-10 11:39:31 +01:00
Sam Rose 5069d3f953
Rename db to dbCore in more places. 2024-07-10 11:37:37 +01:00
Sam Rose 76d22dfffd
Respond to PR comments. 2024-07-10 11:32:34 +01:00
mike12345567 d6ad6a4686 Missing internal check. 2024-07-10 11:21:41 +01:00
Sam Rose 5356cfdce5
Fix uses of SearchFilterOperator. 2024-07-10 11:08:11 +01:00
mike12345567 4ab3aef020 PR comments. 2024-07-10 11:05:06 +01:00
Sam Rose b48ea718d3
Merge branch 'master' of github.com:budibase/budibase into budi-8445-is-in-filter-broken 2024-07-10 09:14:34 +01:00
mike12345567 9e8a855d14 Adding test case for separating columns to rows in same table. 2024-07-09 19:09:01 +01:00
Sam Rose 2fa14ab35f
Merge branch 'master' into sqs-per-tenant 2024-07-09 17:30:33 +01:00
mike12345567 396de67aea Merge branch 'master' of github.com:Budibase/budibase into fix/correcting-multi-relationships 2024-07-09 15:46:15 +01:00
mike12345567 cd19202042 Fix external relationships. 2024-07-09 13:39:49 +01:00
Adria Navarro 38f7b88735 Type filters 2024-07-09 14:01:44 +02:00
Sam Rose 4c6f7f25c2
Fix bug in oneOf search. 2024-07-09 11:45:01 +01:00
Adria Navarro 9c6347f7fd Move constants to types 2024-07-09 12:24:59 +02:00
Adria Navarro 5cba1058d4
Merge branch 'master' into budi-7065-csv-export-fails-for-table-with-composite-primary-key 2024-07-09 10:54:18 +02:00
Adria Navarro 62f5790a81 Remove unnecessary cast 2024-07-09 10:49:57 +02:00
Adria Navarro 58bd346885 Fix 2024-07-09 10:43:53 +02:00
Adria Navarro 0f1c8eb788 Disable mssql test 2024-07-09 10:43:53 +02:00
Adria Navarro 5be8882122 Handle composite keys on exports 2024-07-09 10:43:45 +02:00
mike12345567 c0b85c6379 Initial implementation - needs testing. 2024-07-08 18:42:11 +01:00
Sam Rose 72a0364ca0
Fix search tests. 2024-07-08 15:02:26 +01:00
Sam Rose 014ff81841
Remove accidental imports of the aws-sdk SQS (fml) 2024-07-08 14:25:05 +01:00
Sam Rose 69d54b523d
Finish implementation, fix tests. 2024-07-08 14:21:07 +01:00
Sam Rose 1851e11bc0
wip 2024-07-08 13:28:48 +01:00
Michael Drury e8ceed08a5
Merge branch 'master' into fix/default-table-sqs-indexing 2024-07-05 16:32:14 +01:00
mike12345567 eafe66d01e Linting. 2024-07-05 16:26:26 +01:00
mike12345567 39523685d6 Adding test case for searching sample data. 2024-07-05 16:20:27 +01:00
mike12345567 62ca71f00e Merge branch 'master' of github.com:Budibase/budibase into fix/invalid-time-value 2024-07-05 15:02:36 +01:00
Adria Navarro f26a8d410a Add export composite key 2024-07-05 11:19:01 +02:00
mike12345567 77abe6da83 Handling invalid time values when ISO strings are input as filter options. 2024-07-04 18:29:08 +01:00
Dean a4a472b2d8 Squash the oldRow variable to avoid issues when serialising. Added a try/catch when queuing automations in dev 2024-07-04 12:13:58 +01:00
Sam Rose ce406e0c5d
Unfocus test, you numpty. 2024-07-04 11:43:13 +01:00
Sam Rose b318850c7e
Support non-ascii column in SQS. 2024-07-04 11:37:18 +01:00
Adria Navarro 53af94f971 Fix search returning non visible columns 2024-07-02 14:02:16 +02:00
Adria Navarro 882a056cd9 Don't trim any fields on view crud endpoints 2024-07-02 13:58:16 +02:00
mike12345567 c4ffd37caa Adding fix for backwards compat, removing columns (but still filtering on) returns no rows, rather than an error. 2024-07-01 16:37:38 +01:00
Michael Drury f3d8afcc5b
Merge branch 'master' into fix/sqs-internal-columns 2024-07-01 14:07:27 +01:00
Sam Rose 5c09d6f41f
Fix type error. 2024-07-01 11:46:35 +01:00
Sam Rose 11f49c95dc
Fix contains search on multi-user column. 2024-07-01 09:47:58 +01:00
mike12345567 b3d07aa228 Adding parameterised tests. 2024-06-28 15:21:39 +01:00
mike12345567 510baf4f6e Adding test case and updating how prefix updates in filters work. 2024-06-28 14:19:11 +01:00
mike12345567 41f045d8a6 Allow constant internal columns to be duplicated based on being case sensitive. 2024-06-26 13:36:20 +01:00
Michael Drury cfeab17ed8
Revert "Revert "Disallow prohibited columns"" 2024-06-26 12:40:16 +01:00
Sam Rose 314d62bea0
Revert "Disallow prohibited columns" 2024-06-25 14:29:56 +01:00
Peter Clement f3d466f255
fix issue where schema wasn't updating types when a query was run (#14004)
* fix issue where schema wasn't updating types when a query was run

* add tests for schema matching
2024-06-25 08:51:35 +01:00
Sam Rose bb91849976
Merge branch 'master' into budi-8390-receiving-a-column-has-been-specified-more-than-once-in-the 2024-06-24 17:32:26 +01:00
Sam Rose da1eb6f6ac
Fix primary key appearing twice in the SQL ORDER BY clause. 2024-06-24 17:09:27 +01:00
Sam Rose 01b2f69b74
Merge branch 'master' of github.com:budibase/budibase into budi-8220-support-updating-existing-rows-for-external-databases-using-2 2024-06-24 15:51:03 +01:00
Sam Rose 2458259093
Respond to PR feedback. 2024-06-24 15:50:09 +01:00
mike12345567 b597bd3dbe Fixing an issue detected by tests. 2024-06-24 13:30:18 +01:00
mike12345567 75cee3c4fd Quick type improvement. 2024-06-24 13:28:13 +01:00
mike12345567 1402716f5c Some type updates. 2024-06-24 13:10:30 +01:00
mike12345567 965725d022 First PR comments. 2024-06-24 12:43:26 +01:00
mike12345567 05ea231d20 Adding back missing comments. 2024-06-24 11:53:02 +01:00
mike12345567 fcf67f7297 Fixing an issue raised by Poirazis around empty relationships coming back as related to themselves. 2024-06-21 19:29:30 +01:00
mike12345567 6812c21076 Updating test cases. 2024-06-21 16:58:40 +01:00
mike12345567 e5c40c7ecd Moving some stuff around inside ExternalRequests to make it easier to access parts of the full context. 2024-06-21 16:58:27 +01:00
Sam Rose d5481312d0
Fix lint, add new update test. 2024-06-21 15:31:34 +01:00
Sam Rose c9fecbaa77
Fix updating rows in external tables where the primary key is an autocolumn. 2024-06-21 15:12:02 +01:00
Sam Rose f4378bd561
Merge branch 'master' of github.com:budibase/budibase into budi-8220-support-updating-existing-rows-for-external-databases-using-2 2024-06-21 13:08:39 +01:00
mike12345567 b4910043c6 Addressing PR comments. 2024-06-21 11:27:47 +01:00
mike12345567 fead1f436a test case is only for internal. 2024-06-20 18:53:01 +01:00
mike12345567 ae68c561f4 Test case. 2024-06-20 18:51:04 +01:00
mike12345567 86bae92ada Refactoring search test to make it easier to find promises which aren't handled. 2024-06-20 17:13:42 +01:00
mike12345567 66ef0cb79a Adding back SQS - wasn't causing a problem. 2024-06-20 16:05:03 +01:00
mike12345567 b6b05e08b1 Removing SQS from view test to check. 2024-06-20 15:52:56 +01:00
mike12345567 3345364675 Updating test case - not exactly sure what it was testing before, but now it definitely confirms paginated results are stable. 2024-06-20 14:36:08 +01:00
mike12345567 86d9de5a2d Fixing view test cases, adding SQS to it and correcting the default sort order. 2024-06-19 18:57:37 +01:00
Sam Rose 602faf1c67
Add test for composite primary keys for external datasource imports. 2024-06-19 17:52:48 +01:00
mike12345567 58ec7a50b0 Implementing row counting for in-memory, also updating the in memory search function. 2024-06-19 17:51:11 +01:00
mike12345567 a97b24658f Fixing test case, it didn't provide a primary field. 2024-06-19 15:08:22 +01:00
mike12345567 aab100b130 Changing how counting is processed. 2024-06-19 14:28:22 +01:00
Michael Drury 223df424fc
Merge branch 'master' into feature/count-rows-to-return 2024-06-19 14:20:31 +01:00
mike12345567 0e5de7f16d Test updates. 2024-06-19 13:36:34 +01:00
mike12345567 abfab054d7 Addressing comment about datasource being optional. 2024-06-19 12:03:20 +01:00
Sam Rose 80642100fa
Merge branch 'master' into feature/count-rows-to-return 2024-06-19 09:05:56 +01:00
mike12345567 cf75a8a1f3 Updating function name. 2024-06-18 18:49:59 +01:00
mike12345567 e0d8a66fd8 Adding test cases for counting as well as some small fixes. 2024-06-18 18:44:17 +01:00
Sam Rose e288fc8795
Disable upserting for MSSQL in bulkImport for now. 2024-06-18 18:02:20 +01:00
Sam Rose 5ac8a7d514
bulkImport upsert working everywhere excpet mssql 2024-06-18 17:43:25 +01:00
Sam Rose 335c174643
Create a failing test. 2024-06-18 16:39:35 +01:00
Peter Clement 2b96cbcad7
Expose old row binding in automations (#13931)
* expose old row through the emitter

* accidentally added oldRow to step

* fix row fetch in external datasources

* add test for new / old row comparison

* add testing for old row update event

* allow function overloading in test files

* update tests per comments

* handle event race condition

* update test data modal to account for old row output

* switch icon positioning
2024-06-18 13:45:58 +01:00
mike12345567 73013332ae Adding countRows to search validators. 2024-06-18 11:16:21 +01:00
mike12345567 75bf3c78e6 Merge branch 'master' of github.com:Budibase/budibase into feature/count-rows-to-return 2024-06-18 11:07:34 +01:00
Sam Rose 75e79156f7
Merge branch 'master' into budi-8238-rewrite-postgresspects-to-use-knex 2024-06-17 16:45:33 +01:00
Sam Rose 903c3cf84d
Fix flake in generic-sql.spec.ts. 2024-06-17 16:17:00 +01:00
Sam Rose c107ab937d
Remove rawQuery entirely. 2024-06-17 16:15:51 +01:00
mike12345567 c34c219e8f Tidying up one of the weirder things knex can do. 2024-06-14 19:10:52 +01:00
mike12345567 654a417d66 Type checking. 2024-06-14 19:07:50 +01:00
mike12345567 cd1e7c0bad Small re-jig make things easier to read. 2024-06-14 19:04:02 +01:00
mike12345567 1b36d8af51 Getting counting flow working correctly for external datasources. 2024-06-14 19:00:59 +01:00
mike12345567 e402f9c571 Merge branch 'uncomment-search-test-todos' of github.com:Budibase/budibase into feature/count-rows-to-return 2024-06-14 18:16:47 +01:00
mike12345567 77556820bf Bit more work towards row counting, as well as moving external SQL to use row + 1 for working out pagination. 2024-06-14 18:12:36 +01:00
Sam Rose a54048e308
Solve all remaining TODOs in search.spec.ts. 2024-06-14 14:57:31 +01:00
Sam Rose 1161c185e2
Down to 0 failures. 2024-06-13 17:46:03 +01:00