Commit Graph

1125 Commits

Author SHA1 Message Date
Sam Rose a4b66e00e4
Fix bigints. 2024-07-29 14:32:28 +01:00
Sam Rose 50d1972127
wip 2024-07-29 09:57:24 +01:00
Sam Rose c64d76eb84
Respond to PR comments. 2024-07-19 15:07:58 +01:00
Sam Rose 372153bc97
Accommodate time values in datetime coercion. 2024-07-15 17:27:03 +01:00
Sam Rose 18acaccfcb
Current User binding and tests. 2024-07-15 16:26:15 +01:00
Sam Rose ee0c4187c8
Better error handling of invalid default values. 2024-07-15 12:09:01 +01:00
Sam Rose 297e9003ca
Support bindings in default values. 2024-07-15 11:10:30 +01:00
Sam Rose 12911db06e
Process primitive default values. 2024-07-15 10:43:58 +01:00
Dean 77ca85f140 Attachment single does require a mapping. Clearing it to an empty string is invalid. It has been changed to null 2024-06-28 11:07:06 +01:00
Dean 7d274e5a84 Remove unnecessary row mappings. Updated input processing tests to accommodate clearing BB_REFERENCE types by defaulting to an empty array 2024-06-28 10:42:58 +01:00
Dean 23b0f3dfe4 Added missing rowProcessor mapping config for BB_Reference, BB_Reference_Single and Attachment_Single 2024-06-27 14:25:32 +01:00
mike12345567 a7b995e2ad Merge branch 'master' of github.com:Budibase/budibase into sustaining/typescript-5.5.2 2024-06-24 18:05:32 +01:00
mike12345567 ebf8f54bb7 Upgrading to Typescript 5.5.2 2024-06-24 16:41:28 +01:00
Sam Rose d5481312d0
Fix lint, add new update test. 2024-06-21 15:31:34 +01:00
Sam Rose c9fecbaa77
Fix updating rows in external tables where the primary key is an autocolumn. 2024-06-21 15:12:02 +01:00
Adria Navarro 42d60ad95b Fix 2024-06-03 16:56:12 +02:00
Adria Navarro b937d95de2 Move isRequired to shared-core 2024-06-03 16:55:02 +02:00
Adria Navarro ae36a79f8c Add tests 2024-05-27 14:10:20 +02:00
Adria Navarro 65d2aa50c6 Guard readonly fields 2024-05-27 13:39:43 +02:00
Adria Navarro eac426f3c0 Return date only as dates 2024-05-22 12:04:55 +02:00
Adria Navarro 0b01b67661
Merge branch 'master' into budi-8195/unable-to-load-grid-when-using-external-postgres 2024-05-20 17:06:57 +02:00
Adria Navarro 318dd5e628 Fix time and mssql tests 2024-05-20 16:34:22 +02:00
Dean 37dd75823f PR feedback, signature to signature single 2024-05-17 17:04:15 +01:00
Dean 5a5896bd50 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-16 10:58:15 +01:00
Dean 166206f185 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-15 16:35:31 +01:00
Andrew Kingston 3d5795e934 Fix JSON error when editing rows in modal that contain unset attachments 2024-05-15 15:53:47 +01:00
Adria Navarro 74ac68d72d Fix tests 2024-05-14 18:22:55 +02:00
Adria Navarro 092e75ed6c Treat deprecatedSingleUserColumn as single on inputting 2024-05-14 17:48:10 +02:00
Adria Navarro efb02a2c44 Improve message 2024-05-14 17:44:52 +02:00
Dean 55e7ea55f7 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-14 14:48:09 +01:00
mike12345567 5b5e7e47a2 Fixing some issues with updating rows with attachments, there were some UI bugs that had been raised (undefined being displayed) and the uploading from a URL was not working as expected, due to the stream not matching the expected format of the S3 SDK - this has been fixed by converting the stream to a true readable stream with . 2024-05-13 18:11:40 +01:00
Dean a64aec0173 Test fix 2024-05-13 16:39:30 +01:00
Dean b0a65b4699 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-13 16:22:19 +01:00
Dean 0589a6a730 Refactored signature from previous array implementation to the new single approach. Added support for automations 2024-05-13 16:19:02 +01:00
Adria Navarro fa2843b296 Improve tests 2024-05-13 12:35:00 +02:00
Adria Navarro d83e5e21f2
Merge branch 'master' into feat/budi-8123-single-user 2024-05-09 18:05:16 +02:00
deanhannigan b5bf914cd7
Merge branch 'master' into feature/signature-field-and-component 2024-05-09 14:47:14 +01:00
Peter Clement db273bcd36
Support attachment columns in Automations (#13567)
* base work to support attachments in create / update row

* handle single attachment column

* fix tests

* pro

* fix some types

* handle case where file exists in storage

* improve attacment processing

* refactor slightly and ensure correct url is used for existing attachments

* add test

* Fixing a build issue.

* update tests

* some lint

* remove cursed backend-core test util

* addressing pr comments

* refactoring nasty automationUtils upload code

* remove uneeded check

* use basneeame for fallback filename

* add a test to ensure coverage of single attachment column type

* fail early when fetching object metadata

---------

Co-authored-by: mike12345567 <me@michaeldrury.co.uk>
2024-05-09 14:30:56 +01:00
Sam Rose e0bb052138
Fix lint. 2024-05-09 12:02:29 +01:00
Sam Rose 69c8264388
Remove src/sdk/app/rows/tests/internal.spec.ts. 2024-05-09 11:57:17 +01:00
Dean 3712e290b0 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-09 09:19:00 +01:00
Peter Clement 1d300c2577
Remove aws sdk global mock and update tests (#13637)
* Remove aws sdk global mock and update tests

* add awaits

* Minio healthcheck in tests.

* Bind to 127.0.0.1 instead of 0.0.0.0

* Fix port fetching for minio container.

* Actually fix port mapping this time.

* Pull minio container before running tests.

* Enable testcontainers debug logging.

* Promote minio container to always running in tests, like CouchDB.

* Remove testcontainers debug logging.

---------

Co-authored-by: Sam Rose <hello@samwho.dev>
2024-05-08 14:08:34 +01:00
Dean a29301a2fc Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-08 09:43:30 +01:00
Adria Navarro 84cfbf01ea Fix import 2024-05-06 08:06:44 +02:00
Adria Navarro 04ed10b06e Lint 2024-05-06 08:06:44 +02:00
Adria Navarro 9a6e6ed115 Fix data between old and new 2024-05-06 08:06:43 +02:00
Adria Navarro 23d6c0dc3a Fix tests 2024-05-03 16:35:20 +02:00
Adria Navarro d91292f532 Handle null or empty on processor 2024-05-03 16:21:35 +02:00
Sam Rose 703092505d
Respond to PR feedback. 2024-05-03 15:08:21 +01:00
Sam Rose 99ecefaedf
Fix row.spec.ts 2024-05-03 14:37:13 +01:00
Sam Rose af516427fc
Attempt to fix race condition when creating multiple auto ID columns in parallel. 2024-05-03 14:14:10 +01:00
Adria Navarro b3ff417844 Lint 2024-05-03 13:04:44 +02:00
Adria Navarro d259bdbf7b Fix 2024-05-03 09:34:42 +02:00
Adria Navarro 2c5e9ff784 processOutputBBReference vs processOutputBBReferences 2024-05-03 09:31:24 +02:00
Adria Navarro 1767650337 processInputBBReference vs processInputBBReferences 2024-05-02 16:51:48 +01:00
Adria Navarro 2b61172fe8 PR comments 2024-05-02 12:19:19 +01:00
Adria Navarro 2e4b69e381 PR comments 2024-05-02 12:12:48 +01:00
Adria Navarro 24aec6efb1 Clean types 2024-04-26 13:30:08 +02:00
Adria Navarro d45aa9beaf Merge branch 'master' into budi-8123/single-user-column-type 2024-04-26 12:47:35 +02:00
Adria Navarro a422ae43b2 Fix 2024-04-26 12:26:01 +02:00
Adria Navarro 1aad2ee6d2 Fix after renames 2024-04-26 12:23:11 +02:00
Adria Navarro 637f7f514a Remove FieldTypeSubtypes 2024-04-26 12:18:50 +02:00
Adria Navarro 61bb40d0d3 Remove FieldTypeSubtypes 2024-04-26 12:09:32 +02:00
Adria Navarro fe226ae54b Fix test 2024-04-26 11:26:24 +02:00
Adria Navarro d3425a856f Fix test 2024-04-26 10:07:08 +02:00
Adria Navarro ad44b7ab81 Fix types 2024-04-26 09:47:46 +02:00
Adria Navarro 4b0e389526 Lint 2024-04-25 16:40:13 +02:00
Adria Navarro b3e7080215 Fix import single user 2024-04-25 16:31:15 +02:00
Adria Navarro 6e4baf7215 Fix import validation 2024-04-25 15:50:28 +02:00
Adria Navarro 5c93ee3e06 Refactor 2024-04-25 13:38:31 +02:00
Adria Navarro b7688d3a06 Do not store empty arrays 2024-04-25 13:21:00 +02:00
Adria Navarro 35ba5b93b5 Validate single reference not being an array 2024-04-25 13:21:00 +02:00
Adria Navarro 53badf9263 Lint 2024-04-25 13:20:59 +02:00
Adria Navarro b56c86e1b0 Lint 2024-04-25 13:20:59 +02:00
Adria Navarro 808aba0c34 Input processing 2024-04-25 13:20:59 +02:00
Adria Navarro afdbf4cc42 Add BB_REFERENCE_SINGLE type 2024-04-25 13:20:59 +02:00
Peter Clement a4c0328c53
REST file handling and SMTP automation block attachments (#13403)
* handle files in rest connector

* fetch presigned url and return

* further updates to handle files in rest connector

* remove unused important and fix extension bug

* wrong expiry param

* tests

* add const for temp bucket

* handle ttl on bucket

* more bucket ttl work

* split out fileresponse and xmlresponse into utils

* lint

* remove log

* fix tests

* some pr comments

* update function naming and lint

* adding back needed response for frontend

* use fsp

* handle different content-disposition and potential path traversal

* add test container for s3 / minio

* add test case for filename* and ascii filenames

* move tests into separate describe

* remove log

* up timeout

* switch to minio image instead of localstack

* use minio image instead of s3 for testing

* stream file upload instead

* use streamUpload and update signatures

* update bucketcreate return

* throw real error

* tidy up

* pro

* pro ref fix?

* pro fix

* pro fix?

* move minio test provider to backend-core

* update email builder to allow attachments

* testing for sending files via smtp

* use backend-core minio test container in server

* handle different types of url

* fix minio test provider

* test with container host

* lint

* try different hostname?

* Revert "try different hostname?"

This reverts commit cfefdb8ded.

* fix issue with fetching of signed url with test minio

* update autoamtion attachments to take filename and url

* fix tests

* pro ref

* fix parsing of url object

* pr comments and linting

* pro ref

* fix pro again

* fix pro

* account-portal

* fix null issue

* fix ref

* ref

* When sending a file attachment in email fetch it directly from our object store

* add more checks to ensure we're working with a signed url

* update test to account for direct object store read

* formatting

* fix time issues within test

* update bucket and path extraction to regex

* use const in regex

* pro

* Updating TTL handling in upload functions (#13539)

* Updating TTL handling in upload functions

* describe ttl type

* account for ttl creation in existing buckets and update types

* fix tests

* pro

* pro
2024-04-22 15:30:57 +00:00
Dean 9c7fed9eb8 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-04-11 15:06:59 +01:00
Martin McKeaveney 4a6e1b7192 fix all cases of lint rule 2024-04-10 17:39:12 +01:00
Adria Navarro b42cc88180
Merge pull request #13407 from Budibase/BUDI-8122/attachment_cleanup
Handle singleattachment on AttachmentCleanup
2024-04-10 10:41:32 +02:00
Dean 8e62aa8945 Fixes for existing attachment tests and some coverage for signatures 2024-04-08 16:51:43 +01:00
Dean 9b276aa3c1 Add in signature field testing support. Some signature fixes 2024-04-08 12:18:05 +01:00
Dean 203d6484ea Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-04-05 14:15:47 +01:00
Dean 1e5506b8c3 Full support for signature field type and some feedback changes 2024-04-05 12:50:09 +01:00
Adria Navarro 1bc555350a Lint 2024-04-04 21:09:15 +02:00
Adria Navarro 80dfef9c42 Test single attachment on outputProcessing 2024-04-04 21:07:44 +02:00
Adria Navarro b2ab4e022e Handle singleattachment on AttachmentCleanup 2024-04-04 20:39:11 +02:00
Adria Navarro a1a06b5d18 Fix import 2024-04-04 14:14:11 +02:00
Michael Drury 1cfe4da027
Revert "Single attachment column type" 2024-04-03 16:01:45 +01:00
Adria Navarro 7d0090a8e2 Fix import/export 2024-04-03 17:01:36 +02:00
Adria Navarro a4c8fcb2ac Clean and populate url 2024-04-03 16:43:12 +02:00
Adria Navarro a8c3011071 Rename FieldType.ATTACHMENT to FieldType.ATTACHMENTS 2024-04-03 12:54:20 +02:00
Dean ee3462648d Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-03-26 12:07:10 +00:00
Gerard Burns d9033b2636
Un-revert Skeleton Loader PR (#13180)
* wip

* wip

* wip

* client versions init

* wip

* wip

* wip

* wip

* wip

* linting

* remove log

* comment client version script

* lint

* skeleton loader type fix

* fix types

* lint

* fix types again

* fix manifest not being served locally

* remove preinstalled old client version

* add constant for dev client version

* linting

* Dean PR Feedback

* linting

* pr feedback

* wip

* wip

* clientVersions empty array

* delete from git

* empty array again

* fix tests

* pr feedback

---------

Co-authored-by: Andrew Kingston <andrew@kingston.dev>
2024-03-25 16:39:42 +00:00
Dean a773c167d5 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-03-22 15:26:23 +00:00
Dean 6b5938aef6 Merging 2024-03-22 15:26:05 +00:00
Adria Navarro 0859e79b1e Lint 2024-03-20 23:19:42 +01:00
Adria Navarro 0827cc6bda Type everywhere! 2024-03-20 19:33:39 +01:00
Sam Rose 217b39c232
Reenable no-unused-vars 2024-03-20 11:46:39 +00:00
Sam Rose f1278312ab
Reenable no-case-declarations. 2024-03-19 15:58:25 +00:00
Sam Rose 1785f3af7e
Get lint passing. 2024-03-19 10:55:51 +00:00
Sam Rose 1f63f0bddf
Run auto fix. 2024-03-19 09:46:10 +00:00
Andrew Kingston b6eab42c18 Merge branch 'cheeks-lab-day-binding-eval' of github.com:Budibase/budibase into cheeks-snippets-poc 2024-03-14 16:24:16 +00:00
Adria Navarro 625c1dda9f Improve tests 2024-03-13 16:54:39 +01:00
Adria Navarro 940ff5acd2 Fix table changes with empty attachments 2024-03-13 16:48:58 +01:00
Adria Navarro 0420734d97 Add failing test 2024-03-13 16:48:32 +01:00
Andrew Kingston 28d938ba3e Lint 2024-03-12 19:09:32 +00:00
Andrew Kingston 16ce5ac65e Update how snippets are fetched and enriched into context, because HBS helpers can't be async 2024-03-12 17:02:01 +00:00
Adria Navarro 1367cf3636 Use wrappers 2024-02-19 16:18:56 +01:00
melohagan b563fb48c8
Error when deleting selected rows that have attachment (#13063)
* Deprecate selectedRowIds

* Delete selected rows table

* Add selectedRows to table block context

* update account-portal

* update account-portal

* Lowercase deprecated

* Make sure attachment fields are empty arrays not null

* unit test
2024-02-19 11:09:36 +00:00
Sam Rose dd4ea4be95
Nothing to see here, carry on. 2024-02-15 16:44:19 +00:00
mike12345567 32815d8d9b Quick readability enhancement. 2024-02-15 16:28:59 +00:00
Sam Rose c2c0108e4f
Fix build (again). 2024-02-15 16:12:47 +00:00
Sam Rose d04416b7c7
Merge branch 'revert-13047-revert-13043-fix/updating-users-via-public-api' of github.com:budibase/budibase into type-worker-requests 2024-02-15 16:09:35 +00:00
Sam Rose e4b0330866
Simplify the typing of workerRequests.ts 2024-02-15 15:49:30 +00:00
mike12345567 1f4a254ec5 Fix for integration test, make sure to carry auth headers over correctly. 2024-02-15 15:47:56 +00:00
Sam Rose dde8f77877
Type workerRequests.ts 2024-02-15 14:48:47 +00:00
Michael Drury 36e1a20c03
Revert "Revert "Fix updating users via cross-service comms (public API)"" 2024-02-15 13:45:08 +00:00
Michael Drury 74957725dd
Revert "Fix updating users via cross-service comms (public API)" 2024-02-15 13:44:43 +00:00
mike12345567 05d19c92c7 Fixing bug found by test. 2024-02-15 12:59:41 +00:00
mike12345567 d3bb8b2fa4 There was an issue where extra headers were being carried over to the worker instance when performing cross-service comms - these headers were causing the request to be rejected without consideration. Cleaning up to only include the headers Budibase really cares about in request, let fetch work out the generic ones. 2024-02-15 12:49:39 +00:00
Adria Navarro cc715b7722 Revert scriptRunner changes to use vm2 2024-02-09 16:37:37 +01:00
Adria Navarro f7583b2431 Add options 2024-02-09 13:20:21 +01:00
Adria Navarro 10c59e1ff6 Remove events 2024-02-09 13:17:28 +01:00
Adria Navarro 32723d7121 Trace scriptRunner 2024-02-09 12:51:57 +01:00
Adria Navarro 790d8fcf09 Trace scriptRunner.execute 2024-02-09 12:41:00 +01:00
Adria Navarro ce483e8c12
Merge pull request #12964 from Budibase/fix-bson
Fix BSON usage for isolated-vm
2024-02-08 16:33:43 +01:00
Adria Navarro 1e101744de Make timeout per invocation more specific 2024-02-08 16:20:33 +01:00
Adria Navarro a55e75ae18 Merge branch 'isolated-vm-wrapper' into fix-bson 2024-02-08 13:54:25 +01:00
Adria Navarro 57952131ac Replace # for privates 2024-02-08 13:44:07 +01:00
Adria Navarro abe09509f0 Fix bson 2024-02-08 12:32:07 +01:00
Adria Navarro d293abc8e8 Merge branch 'isolated-vm-wrapper' into fix-bson 2024-02-08 10:58:12 +01:00
Adria Navarro 7972f19cd1 Merge isolated-vm-wrapper 2024-02-08 10:45:00 +01:00
Adria Navarro 008b39abf4 Use wrapper for scripts 2024-02-08 09:38:09 +01:00
Adria Navarro e4285e30f1 Use wrapper for queries 2024-02-08 09:38:09 +01:00
Adria Navarro 0ea7a515de Use bson library to parse to json 2024-02-07 16:14:56 +01:00
Adria Navarro b8ebeff71c Add comments 2024-02-07 15:18:17 +01:00
Adria Navarro 6cafbbf036 Instantiate module 2024-02-07 13:47:43 +01:00
Adria Navarro e2a1d8c880 Refactor 2024-02-07 10:58:43 +01:00
Adria Navarro 1ee20b0464 Fields as private 2024-02-07 10:58:43 +01:00
Adria Navarro 599860b558 Use bson only for mongo 2024-02-07 10:58:43 +01:00
Adria Navarro 0b0b6ddb13 Memory limit via env 2024-02-07 10:58:43 +01:00
Adria Navarro 7a9187d4dc Use new loadBundle function 2024-02-07 10:58:42 +01:00
Adria Navarro a273276bd3 Use bson in isolated-vm 2024-02-07 10:58:42 +01:00
Adria Navarro 2c4601440f Merge branch 'master' into revert-12934-revert-12930-revert-12929-revert-12769-isolated-vm 2024-02-06 17:53:22 +01:00
Adria Navarro 75f8b40cc4 Clean code 2024-02-05 10:18:49 +01:00
melohagan be0ff766f3
Chore/fix worker request error message (#12943)
* Revert "Surface email error (#12837)"

This reverts commit 2a24c85378.

* Improve workerRequest error handling

* update account portal

* Fix typing

* lint
2024-02-02 15:25:18 +00:00
Adria Navarro 8dfcc3aeb1
Revert "Revert "Migrate from `vm` to `isolated-vm`"" 2024-02-02 12:02:09 +01:00
Sam Rose 332a201ae7
Revert "Migrate from `vm` to `isolated-vm`" 2024-02-02 09:51:46 +00:00
mike12345567 6cad0e758f Quick fix for automation JS scripting, make sure context is passed through correctly. 2024-02-01 16:00:58 +00:00