Commit Graph

12593 Commits

Author SHA1 Message Date
Sam Rose e62298e199
Record SQS queries in DataDog. 2024-07-31 15:38:26 +01:00
Adria Navarro c0e60e8e3e
Merge branch 'master' into chore/unify-row-format-values 2024-07-31 16:13:02 +02:00
Adria Navarro b74841d99d Fix 2024-07-31 15:20:06 +02:00
Adria Navarro a6beb0fa82 Support no updating existing rows 2024-07-31 15:14:29 +02:00
Adria Navarro f794f84e90 Fix quote count 2024-07-31 15:03:31 +02:00
Adria Navarro 24cdfb3443 Fix re-importing 2024-07-31 15:03:31 +02:00
Adria Navarro b28aaa3a93 Fix 2024-07-31 15:03:31 +02:00
Adria Navarro 9d0fdeff68 Add validateExistingTableImport _id support test 2024-07-31 15:03:31 +02:00
Adria Navarro 5896e94e56 Add basic validateExistingTableImport test 2024-07-31 15:03:31 +02:00
Adria Navarro 4f65306c4f Add basic validateNewTableImport test 2024-07-31 15:03:31 +02:00
Adria Navarro 543d0e1ce6 Add tests 2024-07-31 14:01:38 +02:00
Adria Navarro fe2b2bb097 Don't export couchdb fields 2024-07-31 13:33:20 +02:00
Adria Navarro 62fa05a855 Type 2024-07-31 13:28:28 +02:00
Sam Rose d4ddfb4de2
Merge branch 'test-oracle' of github.com:budibase/budibase into test-oracle 2024-07-31 12:00:59 +01:00
Sam Rose 4b7042be9f
Ignore Oracle on bulk upsert tests. 2024-07-31 12:00:50 +01:00
Adria Navarro 58a47b801a Remove magic strings 2024-07-31 12:23:09 +02:00
Adria Navarro 0202db3efe Unify enums 2024-07-31 12:20:45 +02:00
mike12345567 4d058b7053 Fixing an issue seen when browsing through datadog error logs for app service. 2024-07-31 11:11:52 +01:00
mike12345567 76895174b5 Merge branch 'master' of github.com:Budibase/budibase into test-oracle 2024-07-31 11:03:30 +01:00
mike12345567 8ee2e6d0de Merge branch 'test-oracle' of github.com:Budibase/budibase into test-oracle 2024-07-30 18:22:38 +01:00
mike12345567 7cc000a838 Fixes for not contains in oracle. 2024-07-30 18:22:20 +01:00
Adria Navarro a172a44741 Fix test 2024-07-30 19:08:00 +02:00
Adria Navarro a9a40516db Fix test 2024-07-30 18:58:51 +02:00
Sam Rose ea7a6195bf
Merge branch 'master' of github.com:budibase/budibase into test-oracle 2024-07-30 17:58:44 +01:00
Sam Rose cc1e466db9
Add Oracle to table.spec.ts 2024-07-30 17:57:21 +01:00
Adria Navarro 48349f9ad0 Fix tests 2024-07-30 18:44:00 +02:00
Adria Navarro e41f3ada62
Merge branch 'master' into chore/improve_typings 2024-07-30 18:36:00 +02:00
Sam Rose 383132d06c
Actually fix time zone problems this time. 2024-07-30 17:26:00 +01:00
Adria Navarro 0a35ae012f Prevent test container name conflicts 2024-07-30 18:16:29 +02:00
Adria Navarro 9371f9913e Types 2024-07-30 18:14:54 +02:00
Sam Rose aa7894604f
Fix dates and times for good? maybe? 2024-07-30 16:56:59 +01:00
Adria Navarro 21b9bf36fd Add api types 2024-07-30 17:52:27 +02:00
mike12345567 8a7e0793d4 Linting. 2024-07-30 16:07:09 +01:00
mike12345567 8f7a88ce86 Moving logic to frontend - definitions are returned unless they are deprecated, frontend decides which it can use to create. 2024-07-30 16:04:33 +01:00
Sam Rose c6ec710abe
Solve _some_ date problems. 2024-07-30 16:03:03 +01:00
mike12345567 7a68db4274 Fix test to remove invalid definitions. 2024-07-30 15:33:43 +01:00
mike12345567 76652ddab5 Fixes some issues with row actions which were allowing them to be added from the automation section (which is not allowed) as well as breaking app access once they were added - this hides them properly so they can't be added as well as fixing the issue when they exist. 2024-07-30 15:07:34 +01:00
mike12345567 d06377a25d Merge branch 'master' of github.com:Budibase/budibase into test-oracle 2024-07-30 13:02:22 +01:00
mike12345567 f4afa3270e Removing invalid test. 2024-07-30 12:44:31 +01:00
mike12345567 ff2802873e Fixing an issue with to_char testing in sql.spec.ts. 2024-07-30 12:29:16 +01:00
Sam Rose b6560d1d7b
Fix sorting. 2024-07-30 11:58:28 +01:00
mike12345567 03f9219d1d PR comment. 2024-07-30 11:57:06 +01:00
Sam Rose bc7501f72b
Fix range queries. 2024-07-30 11:54:46 +01:00
Sam Rose 0599257935
Fix time-only columns. 2024-07-30 11:26:16 +01:00
Sam Rose 384466c754
Merge master. 2024-07-30 11:04:47 +01:00
Sam Rose 4b80d7cb91
Merge branch 'test-oracle' of github.com:budibase/budibase into test-oracle 2024-07-30 11:04:06 +01:00
Sam Rose 5bce8e595d
Plumb FieldSchema into parse. 2024-07-30 11:03:54 +01:00
mike12345567 d448f469f1 Updating image names. 2024-07-29 19:00:25 +01:00
mike12345567 c328799488 Merge branch 'test-oracle' of github.com:Budibase/budibase into test-oracle 2024-07-29 18:56:32 +01:00
mike12345567 fe36b76fe9 Getting something working - using a different version and a pre-built image. 2024-07-29 18:56:15 +01:00
Sam Rose 25ab2e2689
Revert schema plumbing, need to revisit. 2024-07-29 18:20:49 +01:00
Sam Rose e1ef66bf56
Refactor InternalBuilder to give me more access to query state. 2024-07-29 18:11:05 +01:00
Sam Rose ad414b982e
Gone some way toward getting time-only fields to work. Still test failures though. 2024-07-29 16:54:59 +01:00
Sam Rose a4b66e00e4
Fix bigints. 2024-07-29 14:32:28 +01:00
Sam Rose 50d1972127
wip 2024-07-29 09:57:24 +01:00
mike12345567 27d4226c6e Shorten column name. 2024-07-26 17:06:04 +01:00
mike12345567 1beae2c040 Fix bug (thanks tests) 2024-07-26 16:57:07 +01:00
mike12345567 9fb1c6b988 When searching by row ID with external DBs/SQS we can get into a situation where the limit of 1 which is applied by the frontend can cause problems, with many to many relationships we need to retrieve multiple rows (all of the joined related rows). This was raised by poirazis, it exhibits itself in one part of the platform, when attempting to a row by ID in a form block that has multiple many to many relationships. The frontend needs to be able to send a limit of 1 incase it is using a form block but hasn't gotten a row ID (this can happen in preview/the builder) and it just wants to populate with a row for display. 2024-07-26 16:23:46 +01:00
Adria Navarro 8421a75328
Merge branch 'master' into BUDI-8441/row-action-run-api 2024-07-26 15:16:21 +02:00
Adria Navarro f2cd589aae
Merge branch 'master' into chore/renames 2024-07-26 14:42:08 +02:00
Adria Navarro f9bfe51c81 Rename external 2024-07-26 14:37:47 +02:00
Adria Navarro ee74a84339 Remove duplicates 2024-07-26 14:36:41 +02:00
Adria Navarro 3a095c5071 Renames 2024-07-26 14:35:36 +02:00
Adria Navarro 4cf3706904 Renamings 2024-07-26 14:29:20 +02:00
Adria Navarro d7e2f0fc0e Fix build 2024-07-26 13:42:33 +02:00
Adria Navarro a05ec1498f Allow importing internal tables 2024-07-26 13:27:51 +02:00
Adria Navarro 5102724f89 Fix conflicting imports in jest 2024-07-25 17:22:09 +02:00
Adria Navarro afdf6a8fa5 Change imports 2024-07-25 16:46:37 +02:00
Adria Navarro 92a26d4272 Undo async import 2024-07-25 16:43:53 +02:00
Adria Navarro 7ffe8d4b4a Fix barrelfile issue 2024-07-25 16:40:49 +02:00
Adria Navarro 0ee0901961 Remove comment 2024-07-25 16:16:18 +02:00
Adria Navarro 173a9cb75a Clean outputs 2024-07-25 16:15:23 +02:00
Adria Navarro b12641e467
Merge branch 'master' into BUDI-8441/row-action-run-api 2024-07-25 16:09:23 +02:00
Adria Navarro db9bc1f373 Fix types 2024-07-25 16:08:51 +02:00
Adria Navarro beaabdd64a Allow row actions running for dev apps 2024-07-25 15:54:38 +02:00
Adria Navarro 297ff58b67 Pass proper params 2024-07-25 15:37:50 +02:00
Adria Navarro 62eaa11ebb Add trigger 2024-07-25 15:37:49 +02:00
Adria Navarro 22f86be34d
Merge branch 'master' into feat/row-actions 2024-07-25 15:26:50 +02:00
Michael Drury 3c9a4595a5
Merge branch 'master' into bulk-remove-utility 2024-07-25 10:25:45 +01:00
Adria Navarro aafe7a2831
Merge branch 'master' into feat/row-actions 2024-07-25 11:13:18 +02:00
Adria Navarro dad27a3399
Merge pull request #14238 from Budibase/BUDI-8441/expose-rowaction-definition
Expose row action definition
2024-07-25 11:12:53 +02:00
Sam Rose 20bad903cc
Merge branch 'master' of github.com:budibase/budibase into test-oracle 2024-07-25 09:38:41 +01:00
Peter Clement 5ab81543e3
Fix issue with trigger filters not saving (#14231)
* Fix issue with trigger filters not saving

* use enum instead of nasty string

---------

Co-authored-by: Michael Drury <me@michaeldrury.co.uk>
2024-07-25 09:30:38 +01:00
melohagan 8b11ad9503
Merge branch 'master' into bulk-remove-utility 2024-07-25 08:47:20 +01:00
Adria Navarro f7a460a1ea Implement run 2024-07-25 08:38:11 +02:00
Adria Navarro 890d573cac Add validators 2024-07-25 08:37:41 +02:00
Adria Navarro 37e237a3a4 Add output properties 2024-07-25 08:37:41 +02:00
Adria Navarro 7bad3ad39c Start implementing row action trigger 2024-07-25 08:36:31 +02:00
Adria Navarro cf4f463da4 Fix barrel file issues 2024-07-25 08:35:01 +02:00
Adria Navarro 8e7c1baabf
Merge branch 'master' into feat/row-actions 2024-07-25 08:21:21 +02:00
mike12345567 7c6c12f325 Adding a small utility to DB layer for bulk removing documents, this is a problem that Mel ran into, the fact it doesn't default to throwing errors, I've updated a few cases and added functionality for it to maintain compatiability with the old way of doing things (errors silenced). 2024-07-24 18:13:27 +01:00
mike12345567 6796caff22 Merge branch 'fix/lock-ci-image-sha' of github.com:Budibase/budibase into fix/lock-ci-image-sha 2024-07-24 17:33:57 +01:00
mike12345567 ea7dffa3d7 PR comment. 2024-07-24 17:33:39 +01:00
Michael Drury b66449c90a
Merge branch 'master' into fix/lock-ci-image-sha 2024-07-24 16:59:42 +01:00
mike12345567 b68697002a Anoter fix. 2024-07-24 16:48:35 +01:00
mike12345567 2e2a61366f Another attempt to fix. 2024-07-24 16:42:31 +01:00
mike12345567 e9d3c48ff4 Fixing images to use a locked SHA, this means that we shouldn't have issues with CI breaking due to using images which are receiving updates (we've experienced two CI breakages due to MariaDB and MS-SQL updates). 2024-07-24 16:31:13 +01:00
Adria Navarro 2e47410979 Reuse trigger 2024-07-24 17:11:03 +02:00
Sam Rose 46cd06bacf
Merge branch 'master' of github.com:budibase/budibase into budi-8483-consolidate-feature-flags-into-a-single-endpoint 2024-07-24 16:10:45 +01:00
Adria Navarro b568c9e592
Merge branch 'master' into feat/row-actions 2024-07-24 16:52:54 +02:00
Sam Rose 26fe887eea
Merge branch 'master' into fix/buffer-in-backend-js 2024-07-24 15:45:20 +01:00
Sam Rose c0cff4b834
Remove spurious import. 2024-07-24 15:17:03 +01:00
Michael Drury a3181d77b5
Merge branch 'master' into fix/buffer-in-backend-js 2024-07-24 15:13:37 +01:00
Sam Rose ac8b759262
Merge branch 'master' of github.com:budibase/budibase into print-line-debugging-baby-hell-yeah 2024-07-24 15:12:34 +01:00
Sam Rose dfa2437f46
console.log the crap out of startup 2024-07-24 15:12:23 +01:00
Adria Navarro e161c998ca
Merge branch 'master' into feat/row-actions 2024-07-24 15:48:38 +02:00
Michael Drury 204ce8f2b7
Merge branch 'master' into fix/buffer-in-backend-js 2024-07-24 14:42:58 +01:00
Adria Navarro 664f0241a9
Merge branch 'master' into BUDI-8441/find-row-to-sdk 2024-07-24 15:35:44 +02:00
Adria Navarro 89b5770155 Change image 2024-07-24 15:22:37 +02:00
Adria Navarro 82c8be5f55 Fix mssql testcontaint wait strategy 2024-07-24 14:52:40 +02:00
Adria Navarro 2d9da6b7d9
Merge branch 'master' into feat/row-actions 2024-07-24 09:51:47 +02:00
mike12345567 5e1dbd974b Adding a polyfill bundle for Buffer which can be used in the isolated-vm. 2024-07-23 19:02:39 +01:00
Sam Rose c7c2cb48e8
wip 2024-07-23 14:41:34 +01:00
Adria Navarro a6af27785f
Merge branch 'master' into BUDI-8441/find-row-to-sdk 2024-07-23 15:30:36 +02:00
Adria Navarro 8a8633b43b Fix throwing 404 2024-07-23 15:27:35 +02:00
Adria Navarro 4169842018 Fix get 2024-07-23 15:22:26 +02:00
Adria Navarro 75609b2a9b Move row.find to sdk 2024-07-23 15:16:15 +02:00
Adria Navarro 66a2b29ca2 Clean unnecessary ctx 2024-07-23 15:06:00 +02:00
Adria Navarro 89173be9f4 Remove controller dependency 2024-07-23 15:03:44 +02:00
Adria Navarro 8a12523bcc Add find by usermetadata test 2024-07-23 14:58:21 +02:00
Martin McKeaveney add8691090
Merge branch 'master' into fix-oracle-parse 2024-07-23 11:55:19 +01:00
Sam Rose b9742fcf8e
Merge branch 'master' of github.com:budibase/budibase into budi-8483-consolidate-feature-flags-into-a-single-endpoint 2024-07-23 11:52:48 +01:00
Adria Navarro fa4629dfb8 Merge branch 'master' into feat/row-actions 2024-07-23 12:47:56 +02:00
Martin McKeaveney a180ffa1a1 update test names 2024-07-23 11:42:21 +01:00
Martin McKeaveney d50c937c68 use oracle coalesce 2024-07-23 11:39:50 +01:00
Adria Navarro a03094db33 Use 422 instead of 400 trying to delete row action automations 2024-07-23 12:21:52 +02:00
Martin McKeaveney 8fbb978cca fix tests 2024-07-23 11:20:14 +01:00
Adria Navarro b4767cea7c Add checks to shared-core 2024-07-23 12:07:05 +02:00
Adria Navarro 35bbccec67 Return 400 instead of 403 2024-07-23 11:59:14 +02:00
Adria Navarro 8678db18e2 Add tests 2024-07-23 10:46:11 +02:00
Adria Navarro d9029da533 Don't allow deleting row action automations 2024-07-23 10:28:57 +02:00
Adria Navarro 703e2c1873 Prevent renaming row actions 2024-07-23 10:15:25 +02:00
Adria Navarro 123a88c086
Merge branch 'master' into fix-oracle-parse 2024-07-23 10:13:25 +02:00
Adria Navarro e29611f2eb Add comment 2024-07-23 10:10:00 +02:00
Adria Navarro cc77cea269 Fix tests 2024-07-23 10:06:43 +02:00
Adria Navarro 3d57a64bab Remove unnecessary spreads 2024-07-23 10:06:43 +02:00
Adria Navarro 5c41b372f3 Fix types 2024-07-23 10:06:43 +02:00
Adria Navarro 2839bd5ece Trim data 2024-07-23 10:06:21 +02:00
Adria Navarro b7fc1cddb7 Merge branch 'master' into feat/row-actions 2024-07-23 10:03:41 +02:00
Martin McKeaveney 12b5fc2a2b add test for notequal 2024-07-22 21:28:44 +01:00
Martin McKeaveney 537c92b371 tidy 2024-07-22 21:23:27 +01:00
Martin McKeaveney 165d5b7325 removing oracle install scripts 2024-07-22 21:17:35 +01:00
Martin McKeaveney 88ea3fdc07 unit tests and logic added to prevent coalesce being used by oracle 2024-07-22 21:00:20 +01:00
Sam Rose adf59e5208
Merge branch 'master' of github.com:budibase/budibase into budi-8483-consolidate-feature-flags-into-a-single-endpoint 2024-07-22 17:48:37 +01:00
Sam Rose f3c73fe4a8
Support primitives in feature flags, make flag types flow, remove some obsolete feature flag systems. 2024-07-22 17:43:53 +01:00
mike12345567 3ed1c43915 PR comments. 2024-07-22 16:47:37 +01:00
Martin McKeaveney c0260b85ff remove all conditional oracle installs 2024-07-22 15:59:40 +01:00
Adria Navarro 6b58549fd9 Fix issues with circular references and barrel files 2024-07-22 16:34:14 +02:00
mike12345567 3247e13a32 Test case. 2024-07-22 15:17:42 +01:00
mike12345567 4f05f33b08 Fixing the issue, making sure if error occurs to re-evaluate. 2024-07-22 15:17:34 +01:00
Adria Navarro 9bd22bbcdf Fix after merge 2024-07-22 14:45:58 +02:00
Adria Navarro 286883da14 Types 2024-07-22 14:39:26 +02:00
Adria Navarro d6e268d475 Fix tests 2024-07-22 14:31:59 +02:00
Adria Navarro 3fa7858712 Fix references 2024-07-22 14:31:59 +02:00
Adria Navarro 7574b27b4b Fix tests 2024-07-22 14:31:59 +02:00
Adria Navarro 3bb3376a82 Format on frontend 2024-07-22 14:31:59 +02:00
Adria Navarro a6f51caa46 Display rowaction 2024-07-22 14:31:59 +02:00
Adria Navarro 3c9c988d8c Populate table name 2024-07-22 14:31:59 +02:00
Adria Navarro b7a969280f Display data 2024-07-22 14:31:42 +02:00
Adria Navarro 6221b9320e Enrich 2024-07-22 14:31:00 +02:00
Adria Navarro 6c67aaf3a0 Undo 2024-07-22 14:23:18 +02:00
Adria Navarro 08a6ac3919 Add extra tests 2024-07-22 14:23:18 +02:00
Adria Navarro f91ec1de21 Guard readonly and test 2024-07-22 14:23:17 +02:00
Adria Navarro a799bc1c71 Change 2024-07-22 14:23:17 +02:00
Adria Navarro b75c8b32e3 Field readonly 2024-07-22 14:23:17 +02:00
Adria Navarro 1843233168 Undefined context checks 2024-07-22 14:23:17 +02:00
Adria Navarro 67619364b9 Use expectAutomationId() 2024-07-22 14:23:17 +02:00
Adria Navarro 491266c7ba Add more tests 2024-07-22 14:23:17 +02:00
Adria Navarro 292c87350a Check automation creation 2024-07-22 14:23:17 +02:00
Adria Navarro eaa38c5c2d Return automationid from row action api 2024-07-22 14:23:17 +02:00
Adria Navarro 4a8f15995c Type sdk couchdb fields 2024-07-22 14:23:17 +02:00
Adria Navarro 2970bfc48a Fix update and tests 2024-07-22 14:23:16 +02:00
Adria Navarro faf1d678fa Create automation 2024-07-22 14:23:16 +02:00
Andrew Kingston 296cea14a5
Merge branch 'master' into fix/error-handling-relationship-updates 2024-07-22 11:26:14 +01:00
Sam Rose 41bc9b87c3
Fix tests. 2024-07-19 15:46:48 +01:00
Sam Rose 1704d0e69f
Respond to PR comments. 2024-07-19 15:10:02 +01:00
Sam Rose 3c18cf7c34
Fix tests. 2024-07-19 15:08:48 +01:00
Sam Rose ca31add039
Don't allow a column to be both required and have a default value. 2024-07-19 15:08:48 +01:00
Sam Rose c64d76eb84
Respond to PR comments. 2024-07-19 15:07:58 +01:00
Sam Rose 8a49953449
Merge branch 'master' of github.com:budibase/budibase into budi-8434-default-value-row-processing 2024-07-19 15:03:19 +01:00
Dean 4da3155374 Minor change to the error messaging 2024-07-18 15:23:10 +01:00
Dean 2f8a6b9b6b Merge remote-tracking branch 'origin/master' into fix/error-handling-relationship-updates 2024-07-18 14:09:53 +01:00
Sam Rose 481bf9a8b8
Fix generic-sql.spec.ts 2024-07-18 11:40:44 +01:00
Sam Rose df765c1dc7
Merge branch 'master' of github.com:budibase/budibase into support-spaces-as-last-char-in-column-sqs 2024-07-18 11:12:25 +01:00
Sam Rose 5bbdcc1298
Remove unused function. 2024-07-18 11:08:42 +01:00
Sam Rose 0b2a5162a4
Fix the problem, and the tests. 2024-07-18 11:00:10 +01:00
Peter Clement 7fd55fe27d
Automation trigger filtering (#14123)
* backend for triggering automation based on filters

* frontend for handling triggering automations on filter / old row

* lint and bug fix

* fix issue with test header

* make test data optional

* improve safety on trigger gate

* add support for running trigger with filter if no change happened but filter matches

* update var naming to actually make sense

* tests

* fix lint

* improve gating for shouldTrigger check

* remove unecessary cast

* unecessary tableId check

* frontend text updates

* resolving comments

* pro

* Update packages/types/src/documents/app/automation.ts

Co-authored-by: Sam Rose <hello@samwho.dev>

* link out to docs for trigger filtering

* fix pro

* more pr comments

* use getAppId

---------

Co-authored-by: Sam Rose <hello@samwho.dev>
2024-07-18 10:38:15 +01:00
Dean 6b1d16420e Improves error handling around grid relationship cell when handling invalid requests 2024-07-18 09:49:35 +01:00
Adria Navarro f57d8a6147 Fix jest circular references 2024-07-17 17:46:48 +02:00
Sam Rose aea9cda8f5
wip 2024-07-17 15:45:35 +01:00
Adria Navarro 88aa0fc9cf Fix types 2024-07-17 16:40:19 +02:00
Adria Navarro 812afdb85e Fix tests (breaking because of mutating objects...) 2024-07-17 16:28:46 +02:00
Adria Navarro 166d8fac5e Use relative paths 2024-07-17 13:43:25 +02:00
Adria Navarro 53d6219b79 Extract find and fetch 2024-07-17 13:32:45 +02:00
Adria Navarro dc47037dbb Move update and remove 2024-07-17 13:26:40 +02:00
Adria Navarro 373aeac00f Move automation creation to sdk 2024-07-17 13:10:19 +02:00
Adria Navarro 13c6ad9924 More tests 2024-07-17 12:30:31 +02:00
Adria Navarro 371a3ad8ec Ensure unique on updates 2024-07-17 12:26:36 +02:00
Adria Navarro 8297a58270 Ensure unique names 2024-07-17 12:18:09 +02:00
Adria Navarro c51d2cd431 Trims names 2024-07-17 12:16:14 +02:00
Adria Navarro 7fb13b757b Use .string instead of .work 2024-07-17 11:52:29 +02:00
Adria Navarro b1cfdc4f25 Clean code 2024-07-17 11:15:55 +02:00
Adria Navarro 9a7470a943
Merge branch 'master' into BUDI-8428/row-action-crud 2024-07-17 11:08:23 +02:00
Sam Rose 372153bc97
Accommodate time values in datetime coercion. 2024-07-15 17:27:03 +01:00
Sam Rose dc913385f6
Merge branch 'master' of github.com:budibase/budibase into budi-8434-default-value-row-processing 2024-07-15 16:48:36 +01:00
Sam Rose 9542c497de
Create a test for required column with default value. 2024-07-15 16:46:20 +01:00
Sam Rose e39a5b0d7e
Add test for creating a row through views. 2024-07-15 16:44:43 +01:00
Sam Rose 18acaccfcb
Current User binding and tests. 2024-07-15 16:26:15 +01:00
Sam Rose ee0c4187c8
Better error handling of invalid default values. 2024-07-15 12:09:01 +01:00
Sam Rose 297e9003ca
Support bindings in default values. 2024-07-15 11:10:30 +01:00
Sam Rose 12911db06e
Process primitive default values. 2024-07-15 10:43:58 +01:00
Sam Rose 43de204ca2
Default values failing test. 2024-07-15 09:58:31 +01:00
mike12345567 19ff925dec Adding test cases for less than/greater than or equal to, there was no test cases confirming these definitely work. Also aligning the test cases with how the frontend performs these tests today. 2024-07-12 18:09:29 +01:00
mike12345567 745a05fe8d Updating how the 'merging' is handled, don't include the in-memory representation if it exists on disk in Couch, prefer that. 2024-07-12 13:54:55 +01:00
mike12345567 79c292538c There is a risk with default tables that the schema may exist in the DB as well as existing in memory - in this case we should merge the schemas to make sure that all possible attributes from the in memory representation, and the on disk version (which may have been updated by the user) have been captured in the SQLite schema. 2024-07-12 13:51:06 +01:00
Adria Navarro f06d0a5cd6 Clean 2024-07-12 12:17:37 +02:00
Adria Navarro 50c8449f4b Add extra test 2024-07-12 12:17:37 +02:00
Adria Navarro 99b4aae7de
Merge branch 'master' into BUDI-8428/row-action-crud 2024-07-12 11:53:12 +02:00
Adria Navarro 0e8d216e22 Unify newid 2024-07-12 11:36:18 +02:00
Adria Navarro b44397d027 Dont return couch fields 2024-07-12 11:29:00 +02:00
Adria Navarro c0a0e860fa
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-12 11:07:11 +02:00
Sam Rose 4c4e7c12de
Fix a very rare flake in row.spec.ts. 2024-07-12 09:39:38 +01:00
Adria Navarro 1f2dab71eb
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-12 01:34:17 +02:00
mike12345567 9129e47dd9 PR comment 2. 2024-07-11 17:09:41 +01:00
mike12345567 5b1850d28f PR comments. 2024-07-11 16:41:12 +01:00
mike12345567 1e189450c0 Switching to regex. 2024-07-11 16:38:30 +01:00
mike12345567 6db0379504 Resync if it is found that a table or column is missing, this was previously done for specific cases but have expanded to cover all, but only retry once (not get into an infinite loop). 2024-07-11 16:35:57 +01:00
Adria Navarro 2035713b9c Implement delete 2024-07-11 17:33:40 +02:00
Adria Navarro ba2d6fd73b Renames 2024-07-11 17:16:14 +02:00
Adria Navarro 9ff3d8cf77 Add extra tests 2024-07-11 17:14:14 +02:00
Adria Navarro d03a0ebb68 Implement update 2024-07-11 17:08:57 +02:00
Adria Navarro 1be14f5a05
Merge branch 'master' into return-unauthorized-instead-of-forbidden 2024-07-11 16:59:34 +02:00
Adria Navarro 17fc605e4f Persist as object instead of array 2024-07-11 16:57:32 +02:00
Sam Rose db9e0e7d38
Fix fun flake in MySQL / MariaDB. 2024-07-11 15:54:52 +01:00
Adria Navarro de04a6f76d Change id 2024-07-11 15:34:48 +02:00
Adria Navarro 3bcbb57baa Add id to each individual action 2024-07-11 15:32:25 +02:00
Adria Navarro 65d7656097 Unify newid 2024-07-11 15:27:48 +02:00
Adria Navarro e3705f1e87
Merge branch 'master' into BUDI-8449/when-return-all-table-rows-is-selected-the-is-in-filter 2024-07-11 14:40:40 +02:00
Adria Navarro 9fb9c08aab Merge duplicated code 2024-07-11 14:36:51 +02:00
Adria Navarro 55c72c7150 Add tests 2024-07-11 14:12:43 +02:00
mike12345567 73881e9895 Only default the CouchDB SQL URL if we are in dev, otherwise attempt to work out what it is based on the main CouchDB URL (as this should work in all default production environments). 2024-07-11 11:11:28 +01:00
Adria Navarro 2d8361d6fd Always return when table exists 2024-07-11 11:06:36 +02:00
Adria Navarro c565e35b53 Implement find 2024-07-11 10:59:11 +02:00
Adria Navarro fac9c35bce Simplify tests 2024-07-11 10:46:29 +02:00
Adria Navarro 645abea2cd Add extra tests 2024-07-11 10:19:11 +02:00
Adria Navarro 0831b7cf3f Add extra tests 2024-07-11 10:13:28 +02:00
Adria Navarro 7dbfcc398e Implement create 2024-07-11 10:04:25 +02:00
Adria Navarro 063eeeb6df Fix 2024-07-10 15:49:13 +02:00
Adria Navarro fe31f88cc8 Add validation 2024-07-10 15:48:16 +02:00
Adria Navarro bf161d9d93 More types 2024-07-10 15:41:55 +02:00
Adria Navarro c1eafe5b28 Fix 2024-07-10 14:05:21 +02:00
Adria Navarro 0c2024bf6a Basic get 2024-07-10 13:56:41 +02:00
Adria Navarro de2938799b Initial test 2024-07-10 13:47:34 +02:00
Adria Navarro 38718968b0 Basic implementation 2024-07-10 13:47:34 +02:00
Adria Navarro dfda2f0f54 Register router 2024-07-10 13:47:34 +02:00
Adria Navarro 107bd08e21 Endpoint scaffolding 2024-07-10 13:47:34 +02:00
Adria Navarro 3f5161aaf7 Fix tests 2024-07-10 13:36:07 +02:00
Adria Navarro 8b40e80750 Return 401 instead of 403 2024-07-10 13:26:02 +02:00
Michael Drury 55f6610f0d
Merge branch 'master' into fix/correcting-multi-relationships 2024-07-10 12:01:06 +01:00
Sam Rose 551d413900
Merge branch 'master' into sqs-per-tenant 2024-07-10 11:39:31 +01:00
Sam Rose 5069d3f953
Rename db to dbCore in more places. 2024-07-10 11:37:37 +01:00
Sam Rose 76d22dfffd
Respond to PR comments. 2024-07-10 11:32:34 +01:00
mike12345567 d6ad6a4686 Missing internal check. 2024-07-10 11:21:41 +01:00
Sam Rose 5356cfdce5
Fix uses of SearchFilterOperator. 2024-07-10 11:08:11 +01:00
mike12345567 4ab3aef020 PR comments. 2024-07-10 11:05:06 +01:00
Sam Rose b48ea718d3
Merge branch 'master' of github.com:budibase/budibase into budi-8445-is-in-filter-broken 2024-07-10 09:14:34 +01:00
mike12345567 9e8a855d14 Adding test case for separating columns to rows in same table. 2024-07-09 19:09:01 +01:00
Sam Rose 2fa14ab35f
Merge branch 'master' into sqs-per-tenant 2024-07-09 17:30:33 +01:00
mike12345567 4cb23759a3 Removing tables and their related table definitions. 2024-07-09 16:33:10 +01:00
mike12345567 6e699a163d Cleaning up how junction fields are added to query. 2024-07-09 16:32:35 +01:00
mike12345567 396de67aea Merge branch 'master' of github.com:Budibase/budibase into fix/correcting-multi-relationships 2024-07-09 15:46:15 +01:00
mike12345567 cd19202042 Fix external relationships. 2024-07-09 13:39:49 +01:00
Adria Navarro 38f7b88735 Type filters 2024-07-09 14:01:44 +02:00
Sam Rose 102bd28980
Fix lint. 2024-07-09 11:52:20 +01:00
Sam Rose 4c6f7f25c2
Fix bug in oneOf search. 2024-07-09 11:45:01 +01:00
Adria Navarro 9c6347f7fd Move constants to types 2024-07-09 12:24:59 +02:00
Adria Navarro 5cba1058d4
Merge branch 'master' into budi-7065-csv-export-fails-for-table-with-composite-primary-key 2024-07-09 10:54:18 +02:00
Adria Navarro 62f5790a81 Remove unnecessary cast 2024-07-09 10:49:57 +02:00
Adria Navarro 58bd346885 Fix 2024-07-09 10:43:53 +02:00
Adria Navarro 0f1c8eb788 Disable mssql test 2024-07-09 10:43:53 +02:00
Adria Navarro 5be8882122 Handle composite keys on exports 2024-07-09 10:43:45 +02:00
mike12345567 c0b85c6379 Initial implementation - needs testing. 2024-07-08 18:42:11 +01:00
Sam Rose b5f0619c89
Fix attachments test. 2024-07-08 17:43:05 +01:00
Sam Rose b9ac15296a
Fix migration test. 2024-07-08 17:00:33 +01:00
Sam Rose 72a0364ca0
Fix search tests. 2024-07-08 15:02:26 +01:00
Sam Rose 014ff81841
Remove accidental imports of the aws-sdk SQS (fml) 2024-07-08 14:25:05 +01:00
Sam Rose 69d54b523d
Finish implementation, fix tests. 2024-07-08 14:21:07 +01:00
Sam Rose 1851e11bc0
wip 2024-07-08 13:28:48 +01:00
Michael Drury e8ceed08a5
Merge branch 'master' into fix/default-table-sqs-indexing 2024-07-05 16:32:14 +01:00
mike12345567 eafe66d01e Linting. 2024-07-05 16:26:26 +01:00
mike12345567 39523685d6 Adding test case for searching sample data. 2024-07-05 16:20:27 +01:00
mike12345567 34d073bcb7 Adding default tables to sync. 2024-07-05 16:03:38 +01:00
mike12345567 5066da2630 Grouping and exporting default tables. 2024-07-05 16:03:03 +01:00
mike12345567 c48f5c6d80 Fixing build issue. 2024-07-05 15:45:00 +01:00
mike12345567 1c94cf415e Merge branch 'master' of github.com:Budibase/budibase into fix/invalid-time-value 2024-07-05 15:44:20 +01:00
mike12345567 e4375c2196 Fixing a build issue uncovered by tests. 2024-07-05 15:27:54 +01:00
mike12345567 5c7bd0f519 Merge branch 'handlebar-helper-lorem' of github.com:Budibase/budibase into handlebar-helper-lorem 2024-07-05 15:04:18 +01:00
mike12345567 c34e6c02e3 Removing pointless test case. 2024-07-05 15:04:01 +01:00
mike12345567 62ca71f00e Merge branch 'master' of github.com:Budibase/budibase into fix/invalid-time-value 2024-07-05 15:02:36 +01:00
Michael Drury ab37fd0d52
Merge branch 'master' into handlebar-helper-lorem 2024-07-05 13:19:28 +01:00
mike12345567 e41f5c6d92 Updating bundle and adding specific test for ipsum 2024-07-05 12:45:19 +01:00
Adria Navarro f26a8d410a Add export composite key 2024-07-05 11:19:01 +02:00
mike12345567 77abe6da83 Handling invalid time values when ISO strings are input as filter options. 2024-07-04 18:29:08 +01:00
Dean 87b53ca452 Removed dupe import 2024-07-04 15:26:15 +01:00
Dean 3a1a600b91 PR feedback 2024-07-04 15:19:56 +01:00
Dean a4a472b2d8 Squash the oldRow variable to avoid issues when serialising. Added a try/catch when queuing automations in dev 2024-07-04 12:13:58 +01:00
Sam Rose 7ed5df1019
Merge branch 'master' of github.com:budibase/budibase into support-non-ascii-in-sqs 2024-07-04 11:44:00 +01:00
Sam Rose ce406e0c5d
Unfocus test, you numpty. 2024-07-04 11:43:13 +01:00
Sam Rose b958eb6e34
Merge branch 'master' of github.com:budibase/budibase into support-non-ascii-in-sqs 2024-07-04 11:39:48 +01:00
Sam Rose b318850c7e
Support non-ascii column in SQS. 2024-07-04 11:37:18 +01:00
Adria Navarro ddcf5598b4
Merge branch 'master' into chore/fix-npm-vulnerabilities 2024-07-04 12:30:40 +02:00
Adria Navarro c4dacfbd71 Undo mssql update (as it breaks some types) 2024-07-04 11:43:54 +02:00
Adria Navarro 8da83dac58 Merge branch 'master' into chore/fix-npm-vulnerabilities 2024-07-04 11:08:51 +02:00
Adria Navarro 9d2385b777 Update jimp 2024-07-04 10:56:55 +02:00
Adria Navarro 8a5925a924 Update mssql 2024-07-04 10:55:39 +02:00
Michael Drury 4933658b98
Merge branch 'master' into fix/couchdb-integration 2024-07-03 17:36:16 +01:00
Dean 3c32c08ca8 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-03 17:17:08 +01:00
Sam Rose 3a74df0a4a
Fix tests. 2024-07-03 17:04:31 +01:00
mike12345567 e83c37263d Further simplification. 2024-07-03 16:59:31 +01:00
Dean e472dc826c Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-03 16:42:02 +01:00
Sam Rose 5fc5524693
Delete unused SendGrid mock. 2024-07-03 16:41:51 +01:00
Sam Rose d14cccb4c6
Remove unused SENDGRID_API_KEY 2024-07-03 16:39:30 +01:00
Sam Rose 901428fc9c
Merge branch 'master' of github.com:budibase/budibase into merge-env-vars 2024-07-03 16:31:18 +01:00
Sam Rose cd98882127
Move secrets into backend-core. 2024-07-03 16:30:23 +01:00
mike12345567 c159ebba1f Updating migration test case to check both env vars. 2024-07-03 15:16:13 +01:00
mike12345567 de9462403c Adding both environment variables. 2024-07-03 15:08:56 +01:00
mike12345567 056d65cb1e Splitting app migrations for SQS into their own environment variable so that they can be enabled separately. 2024-07-03 15:07:35 +01:00
Dean 8741c5a999 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-03 14:42:36 +01:00
mike12345567 f34d731bcc Update MongoDB to 6.7.0 2024-07-03 14:04:47 +01:00
Michael Drury 5ca9caaa69
Revert "Update MongoDB." 2024-07-03 13:48:56 +01:00
mike12345567 378bf6d42f Updating tests. 2024-07-03 13:40:57 +01:00
mike12345567 cb41e4d5a1 Fix for CouchDB integration, the typing in it was very poor and wise hiding issues, I've updated how this is implemented so that static typing can catch issues with it. 2024-07-03 12:50:33 +01:00
Dean da91991cc1 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-03 10:43:20 +01:00
Peter Clement 9809bf1a91
Fix an issue where null values were causing an error in automation loops (#14083)
* fixes an issue where nulls weren't being handled correctly in loops

* remove log

* update recursive gate to be more specific

* use lodash for object check
2024-07-03 09:07:44 +00:00
Sam Rose 2e33680e6b
Update MongoDB. 2024-07-03 09:19:19 +01:00
Dean f44aba763e Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-03 09:05:05 +01:00
mike12345567 ac2b87df9e Quick change. 2024-07-02 16:59:42 +01:00
mike12345567 39392a793d Making sure the app migration queue is created correctly consistently. 2024-07-02 16:57:32 +01:00
Adria Navarro c1520c6bf6 Fix socket.io vulnerability 2024-07-02 15:26:44 +02:00
Adria Navarro e19c9bd66a Remove protobufjs critical vulnerability 2024-07-02 15:21:11 +02:00
Adria Navarro 07d538f6fc Don't trim fields on view enrich schema 2024-07-02 14:02:49 +02:00
Adria Navarro 53af94f971 Fix search returning non visible columns 2024-07-02 14:02:16 +02:00
Adria Navarro 882a056cd9 Don't trim any fields on view crud endpoints 2024-07-02 13:58:16 +02:00
Dean 1177139237 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-02 11:49:51 +01:00
mike12345567 5ac9fe43fc PR comments. 2024-07-01 17:50:34 +01:00
Dean c5b702ab69 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-01 16:48:41 +01:00
mike12345567 c4ffd37caa Adding fix for backwards compat, removing columns (but still filtering on) returns no rows, rather than an error. 2024-07-01 16:37:38 +01:00
Dean dd4519067e Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-07-01 14:15:24 +01:00
Michael Drury f3d8afcc5b
Merge branch 'master' into fix/sqs-internal-columns 2024-07-01 14:07:27 +01:00
Michael Drury 6e57a7b821
Merge branch 'master' into fix/sqs-internal-columns 2024-07-01 13:37:57 +01:00
Michael Drury 0bccfd3e15
Merge branch 'master' into budi-8404-filtering-with-the-contains-operator-throws-an-error-when 2024-07-01 13:37:37 +01:00
mike12345567 c2d5011576 Fixing an issue with a JS testcase that depended on dates, when the month changed to July this broke - making the dates fixed to avoid this in future. 2024-07-01 13:12:20 +01:00
Sam Rose 5c09d6f41f
Fix type error. 2024-07-01 11:46:35 +01:00
Sam Rose 6eb37df92d
Respond to PR feedback. 2024-07-01 11:41:21 +01:00
Sam Rose 11f49c95dc
Fix contains search on multi-user column. 2024-07-01 09:47:58 +01:00
mike12345567 b3d07aa228 Adding parameterised tests. 2024-06-28 15:21:39 +01:00
mike12345567 13ac273c83 Updating how search filters are converted, needs full column metadata to work it out this way. 2024-06-28 14:59:00 +01:00
mike12345567 510baf4f6e Adding test case and updating how prefix updates in filters work. 2024-06-28 14:19:11 +01:00
mike12345567 2d31e327e7 Resolving PR comments. 2024-06-28 13:49:52 +01:00
mike12345567 048d15956b Updating environments which need to re-sync definitions. 2024-06-28 12:47:57 +01:00
Dean 77ca85f140 Attachment single does require a mapping. Clearing it to an empty string is invalid. It has been changed to null 2024-06-28 11:07:06 +01:00
Dean 7d274e5a84 Remove unnecessary row mappings. Updated input processing tests to accommodate clearing BB_REFERENCE types by defaulting to an empty array 2024-06-28 10:42:58 +01:00
Dean a85fd8c393 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-06-27 20:18:02 +01:00
mike12345567 ade514b96f Merge branch 'fix/sqs-internal-columns' of github.com:Budibase/budibase into fix/sqs-internal-columns 2024-06-27 18:30:40 +01:00
mike12345567 6b4852bf3e Updating migration test case. 2024-06-27 18:30:22 +01:00
Michael Drury c1f7561839
Merge branch 'master' into fix/sqs-internal-columns 2024-06-27 18:19:03 +01:00
mike12345567 3394e974d3 Getting casting working again, have to pass down prefix for checking against fields. 2024-06-27 18:18:41 +01:00
mike12345567 b0e6d3e72c Correctly handling overlapping column names. 2024-06-27 17:55:09 +01:00
Dean 23b0f3dfe4 Added missing rowProcessor mapping config for BB_Reference, BB_Reference_Single and Attachment_Single 2024-06-27 14:25:32 +01:00
Michael Drury f092bf46cf
Merge branch 'master' into revert-14020-revert-13993-fix/disallow-prohibited-columns 2024-06-27 13:30:00 +01:00
Dean b6d7715831 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-06-27 12:49:26 +01:00
Peter Clement cf11009e24
Update OpenAI dependency to fix 400 errors (#14033)
* Update OpenAI dependency to fix 400 errors

* add some optional chaining for safety

* add caret

* fix tests
2024-06-27 12:17:48 +01:00
Dean 2243314314 Defaulting to null in the updateRow step causes issues in row mapping. Switching back to empty string 2024-06-27 09:10:28 +01:00
mike12345567 1b9211ee6c Initial implementation of solving SQS issue with case insensitivity. 2024-06-26 16:40:20 +01:00
Dean d10ef7b795 Alter logic for field config checks causing test issues 2024-06-26 15:34:00 +01:00
Dean ca44220bd3 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-06-26 14:30:08 +01:00
Dean 21c335caab Lint and tidying up 2024-06-26 14:29:42 +01:00
mike12345567 41f045d8a6 Allow constant internal columns to be duplicated based on being case sensitive. 2024-06-26 13:36:20 +01:00
Michael Drury cfeab17ed8
Revert "Revert "Disallow prohibited columns"" 2024-06-26 12:40:16 +01:00
Dean 9adae8a9fd If a relationship value is set to null, the row processor will set it to an empty to array an ensure its properly cleared. Previously the empty value would be an empty string, which was then set to an empty array in the rowProcessor 2024-06-26 11:12:25 +01:00
Dean ed0f60d5d7 Added an app trigger update parser that will clean the testdata for the automation on save. Old values were not cleaned out. Added some padding to the PropField labels. General fixes 2024-06-26 11:10:15 +01:00
Michael Drury 9c92b8eff9
Merge branch 'master' into sustaining/typescript-5.5.2 2024-06-26 11:03:01 +01:00
Dean 1db1b638e6 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-06-26 09:08:11 +01:00
Sam Rose 314d62bea0
Revert "Disallow prohibited columns" 2024-06-25 14:29:56 +01:00
Dean 5ff8b03378 Merge remote-tracking branch 'origin/master' into feature/automation-row-ux-update 2024-06-25 12:05:31 +01:00
Dean e9985adcd4 Updates and refactoring of Automation flows 2024-06-25 11:52:11 +01:00
Peter Clement 1fa18ccfce
Some automation fixes and refactoring (#13870)
* fix issue where booleans were being parsed to null

* refactor looping out of automations

* clean out execute function in orchestrator of looping code

* re-add accidentally deleted file

* remove spec file

* remove log

* move code back into main automation thread

* account portal update

---------

Co-authored-by: Adria Navarro <adria@budibase.com>
Co-authored-by: Michael Drury <me@michaeldrury.co.uk>
Co-authored-by: Sam Rose <hello@samwho.dev>
2024-06-25 11:17:14 +01:00
Peter Clement f3d466f255
fix issue where schema wasn't updating types when a query was run (#14004)
* fix issue where schema wasn't updating types when a query was run

* add tests for schema matching
2024-06-25 08:51:35 +01:00
mike12345567 a7b995e2ad Merge branch 'master' of github.com:Budibase/budibase into sustaining/typescript-5.5.2 2024-06-24 18:05:32 +01:00
Sam Rose bb91849976
Merge branch 'master' into budi-8390-receiving-a-column-has-been-specified-more-than-once-in-the 2024-06-24 17:32:26 +01:00
Sam Rose da1eb6f6ac
Fix primary key appearing twice in the SQL ORDER BY clause. 2024-06-24 17:09:27 +01:00
mike12345567 ebf8f54bb7 Upgrading to Typescript 5.5.2 2024-06-24 16:41:28 +01:00
Sam Rose 01b2f69b74
Merge branch 'master' of github.com:budibase/budibase into budi-8220-support-updating-existing-rows-for-external-databases-using-2 2024-06-24 15:51:03 +01:00
Sam Rose 2458259093
Respond to PR feedback. 2024-06-24 15:50:09 +01:00
mike12345567 b597bd3dbe Fixing an issue detected by tests. 2024-06-24 13:30:18 +01:00
mike12345567 75cee3c4fd Quick type improvement. 2024-06-24 13:28:13 +01:00
mike12345567 1402716f5c Some type updates. 2024-06-24 13:10:30 +01:00
mike12345567 965725d022 First PR comments. 2024-06-24 12:43:26 +01:00
mike12345567 05ea231d20 Adding back missing comments. 2024-06-24 11:53:02 +01:00
mike12345567 fcf67f7297 Fixing an issue raised by Poirazis around empty relationships coming back as related to themselves. 2024-06-21 19:29:30 +01:00