MirrorSave
/
nodemcu-firmware
mirror of https://github.com/nodemcu/nodemcu-firmware.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce runtime memory overhead; prevent overflow of data array.

This commit is contained in:
Pat Wood 2015-06-26 11:00:03 -04:00
parent e7c7dc2b55
commit bdae6fdf55
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/modules/dht.c
View File

@ -58,7 +58,7 @@ static bool DHTRead(int pin, signed short *temp, signed short *hum, DHT_TYPE typ
int i = 0; int i = 0;
int j = 0; int j = 0;
int checksum = 0; int checksum = 0;
unsigned char data[100]; unsigned char data[5];
data[0] = data[1] = data[2] = data[3] = data[4] = 0; data[0] = data[1] = data[2] = data[3] = data[4] = 0;
uint8_t platform_pin = GPIO_ID_PIN(pin_num[pin]); uint8_t platform_pin = GPIO_ID_PIN(pin_num[pin]);
@ -101,10 +101,10 @@ static bool DHTRead(int pin, signed short *temp, signed short *hum, DHT_TYPE typ
break; break;
} }
laststate = GPIO_INPUT_GET(platform_pin); laststate = GPIO_INPUT_GET(platform_pin);
if (counter == 1000 || j >= sizeof(data) * 8) if (counter == 1000)
break; break;
// store data after 3 reads // store data after 3 reads
if ((i>3) && (i%2 == 0)) { if ((i>3) && (i%2 == 0) && j < sizeof(data) * 8) {
// shove each bit into the storage bytes // shove each bit into the storage bytes
data[j/8] <<= 1; data[j/8] <<= 1;
if (counter > DHT_BREAKTIME) if (counter > DHT_BREAKTIME)