From eddda24a6f49c90107d69a118a4abb27d12f1ef9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20St=C3=B6r?= Date: Sun, 28 Aug 2016 21:53:59 +0200 Subject: [PATCH] Improve GitHub templates --- .github/ISSUE_TEMPLATE.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index c5ba1d1c..6533c44a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -7,7 +7,7 @@ Use one of the two templates below and delete the rest. ### Actual behavior ### Test code -Provide a minimal and isolated test which will reproduce the problem. +Provide a [Minimal, Complete, and Verifiable example](http://stackoverflow.com/help/mcve) which will reproduce the problem. ```Lua -- add code here ``` diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4201cf65..baaafcba 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,10 +2,9 @@ Fixes #\. Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so. -- [ ] This PR is compliant with the [contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) (if not, please describe why). +- [ ] This PR is for the `dev` branch rather than for `master`. +- [ ] This PR is compliant with the [other contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) as well (if not, please describe why). - [ ] I have thoroughly tested my contribution. - [ ] The code changes are reflected in the documentation at `docs/en/*`. -\ - -Committers supporting this PR: leave blank \ No newline at end of file +\ \ No newline at end of file