MirrorSave
/
pigpio
mirror of https://github.com/joan2937/pigpio
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Run socket interface APIs atomically." 

Locking the socket interface prevents APIs running concurrently.
This is problematic when some API are long runnnig and therefore
effectively block other API threads from running.

This reverts commit 9dcea25d06.
This commit is contained in:
Guy McSwain 2022-01-30 14:15:04 -06:00
parent d5e52bc81e
commit c88c5c9e4e
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
pigpio.c
View File

@ -1240,9 +1240,6 @@ static uint32_t sockNetAddr[MAX_CONNECT_ADDRESSES];
static int numSockNetAddr = 0;
// apiMutex enforces atomic execution of an API on the socket interface
static pthread_mutex_t apiMutex = PTHREAD_MUTEX_INITIALIZER;
static uint32_t reportedLevel = 0;
static int waveClockInited = 0;
@ -1873,26 +1870,6 @@ static int myDoCommand(uintptr_t *p, unsigned bufSize, char *buf)
bsc_xfer_t xfer;
int masked;
res = 0;
int protectedAPI;
switch (p[0])
{
/* Script APIs cannot be protected or they will deadlock. */
case PI_CMD_PROC:
case PI_CMD_PROCP:
case PI_CMD_PROCR:
case PI_CMD_PROCS:
case PI_CMD_PROCD:
case PI_CMD_PROCU:
protectedAPI = 0;
break;
default:
protectedAPI = 1;
}
if (protectedAPI)
pthread_mutex_lock(&apiMutex);
switch (p[0])
{
@ -2540,10 +2517,6 @@ static int myDoCommand(uintptr_t *p, unsigned bufSize, char *buf)
break;
}
if (protectedAPI)
pthread_mutex_unlock(&apiMutex);
return res;
}