MirrorSave
/
rclone
mirror of https://github.com/rclone/rclone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: clarify behaviour of Put() and Upload() for unknown-sized objects

This commit is contained in:
Cnly 2019-01-19 21:51:34 +08:00 committed by Nick Craig-Wood
parent b8b53901e8
commit 318d1bb6f9
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/fs.go
View File

@ -227,6 +227,10 @@ type Fs interface {
// Put in to the remote path with the modTime given of the given size // Put in to the remote path with the modTime given of the given size
// //
// When called from outside a Fs by rclone, src.Size() will always be >= 0.
// But for unknown-sized objects (indicated by src.Size() == -1), Put should either
// return an error or upload it properly (rather than e.g. calling panic).
//
// May create the object even if it returns an error - if so // May create the object even if it returns an error - if so
// will return the object and the error, otherwise will return // will return the object and the error, otherwise will return
// nil and the error // nil and the error
@ -275,6 +279,10 @@ type Object interface {
Open(options ...OpenOption) (io.ReadCloser, error) Open(options ...OpenOption) (io.ReadCloser, error)
// Update in to the object with the modTime given of the given size // Update in to the object with the modTime given of the given size
//
// When called from outside a Fs by rclone, src.Size() will always be >= 0.
// But for unknown-sized objects (indicated by src.Size() == -1), Upload should either
// return an error or update the object properly (rather than e.g. calling panic).
Update(in io.Reader, src ObjectInfo, options ...OpenOption) error Update(in io.Reader, src ObjectInfo, options ...OpenOption) error
// Removes this object // Removes this object