From 31f21551bfc56038a91726c85c965329cadb6e8b Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Sun, 19 Jan 2020 14:54:55 +0000 Subject: [PATCH] mount: change maximum leaf name length to 1024 bytes - fixes #3884 This limit was previously 4k set in 59026c4761e3926f however leaf names above 1k now produce an IO error. WinFSP seems to have its own method for dropping too long file names above 255 long. --- cmd/mount/dir.go | 2 +- cmd/mountlib/mount.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/mount/dir.go b/cmd/mount/dir.go index 013bee7c6..7be77c77f 100644 --- a/cmd/mount/dir.go +++ b/cmd/mount/dir.go @@ -108,7 +108,7 @@ func (d *Dir) ReadDirAll(ctx context.Context) (dirents []fuse.Dirent, err error) } for _, node := range items { name := node.Name() - if len(name) >= mountlib.MaxLeafSize { + if len(name) > mountlib.MaxLeafSize { fs.Errorf(d, "Name too long (%d bytes) for FUSE, skipping: %s", len(name), name) continue } diff --git a/cmd/mountlib/mount.go b/cmd/mountlib/mount.go index 1d8f193b0..b5b6991bc 100644 --- a/cmd/mountlib/mount.go +++ b/cmd/mountlib/mount.go @@ -48,7 +48,7 @@ type ( // Global constants const ( - MaxLeafSize = 4095 // don't pass file names longer than this + MaxLeafSize = 1024 // don't pass file names longer than this ) func init() {