DELETE requests respond with 200 on successful deletes

This commit is contained in:
andreimarcu 2015-10-04 02:25:00 -04:00
parent adf77c642f
commit 7f2db43108
2 changed files with 6 additions and 5 deletions

View File

@ -1,6 +1,7 @@
package main package main
import ( import (
"fmt"
"net/http" "net/http"
"os" "os"
"path" "path"
@ -38,7 +39,7 @@ func deleteHandler(c web.C, w http.ResponseWriter, r *http.Request) {
return return
} }
notFoundHandler(c, w, r) // 404 - file deleted fmt.Fprintf(w, "DELETED")
return return
} else { } else {

View File

@ -278,8 +278,8 @@ func TestPutAndDelete(t *testing.T) {
req.Header.Set("X-Delete-Key", myjson.Delete_Key) req.Header.Set("X-Delete-Key", myjson.Delete_Key)
goji.DefaultMux.ServeHTTP(w, req) goji.DefaultMux.ServeHTTP(w, req)
if w.Code != 404 { if w.Code != 200 {
t.Fatal("Status code was not 404, but " + strconv.Itoa(w.Code)) t.Fatal("Status code was not 200, but " + strconv.Itoa(w.Code))
} }
// Make sure it's actually gone // Make sure it's actually gone
@ -334,8 +334,8 @@ func TestPutAndSpecificDelete(t *testing.T) {
req.Header.Set("X-Delete-Key", "supersecret") req.Header.Set("X-Delete-Key", "supersecret")
goji.DefaultMux.ServeHTTP(w, req) goji.DefaultMux.ServeHTTP(w, req)
if w.Code != 404 { if w.Code != 200 {
t.Fatal("Status code was not 404, but " + strconv.Itoa(w.Code)) t.Fatal("Status code was not 200, but " + strconv.Itoa(w.Code))
} }
// Make sure it's actually gone // Make sure it's actually gone