From 4a711b1cb42531286528873315a49e0d053e7779 Mon Sep 17 00:00:00 2001 From: Florian Festi Date: Sat, 14 Dec 2019 12:32:01 +0100 Subject: [PATCH] boxesserver: Improve error handling during rendering Especially don't print messages for out of bound parameters into the log/stdout --- scripts/boxesserver | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/boxesserver b/scripts/boxesserver index aa53751..e6564a9 100755 --- a/scripts/boxesserver +++ b/scripts/boxesserver @@ -497,10 +497,11 @@ class BServer: box.render() box.close() except Exception as e: - traceback.print_exc() + if not isinstance(e, ValueError): + traceback.print_exc() start_response("500 Internal Server Error", - [('Content-type', 'text/plain; charset=utf-8')]) - return([b"Server Error\n\n", str(e).encode("utf-8")]) + headers) + return self.errorMessage(name, e, _) http_headers = box.formats.http_headers.get( box.format,