Commit Graph

294 Commits

Author SHA1 Message Date
Peter Clement db273bcd36
Support attachment columns in Automations (#13567)
* base work to support attachments in create / update row

* handle single attachment column

* fix tests

* pro

* fix some types

* handle case where file exists in storage

* improve attacment processing

* refactor slightly and ensure correct url is used for existing attachments

* add test

* Fixing a build issue.

* update tests

* some lint

* remove cursed backend-core test util

* addressing pr comments

* refactoring nasty automationUtils upload code

* remove uneeded check

* use basneeame for fallback filename

* add a test to ensure coverage of single attachment column type

* fail early when fetching object metadata

---------

Co-authored-by: mike12345567 <me@michaeldrury.co.uk>
2024-05-09 14:30:56 +01:00
Sam Rose e0bb052138
Fix lint. 2024-05-09 12:02:29 +01:00
Sam Rose 69c8264388
Remove src/sdk/app/rows/tests/internal.spec.ts. 2024-05-09 11:57:17 +01:00
Dean 3712e290b0 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-09 09:19:00 +01:00
Peter Clement 1d300c2577
Remove aws sdk global mock and update tests (#13637)
* Remove aws sdk global mock and update tests

* add awaits

* Minio healthcheck in tests.

* Bind to 127.0.0.1 instead of 0.0.0.0

* Fix port fetching for minio container.

* Actually fix port mapping this time.

* Pull minio container before running tests.

* Enable testcontainers debug logging.

* Promote minio container to always running in tests, like CouchDB.

* Remove testcontainers debug logging.

---------

Co-authored-by: Sam Rose <hello@samwho.dev>
2024-05-08 14:08:34 +01:00
Dean a29301a2fc Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-05-08 09:43:30 +01:00
Adria Navarro 23d6c0dc3a Fix tests 2024-05-03 16:35:20 +02:00
Adria Navarro d91292f532 Handle null or empty on processor 2024-05-03 16:21:35 +02:00
Sam Rose 703092505d
Respond to PR feedback. 2024-05-03 15:08:21 +01:00
Sam Rose 99ecefaedf
Fix row.spec.ts 2024-05-03 14:37:13 +01:00
Sam Rose af516427fc
Attempt to fix race condition when creating multiple auto ID columns in parallel. 2024-05-03 14:14:10 +01:00
Adria Navarro b3ff417844 Lint 2024-05-03 13:04:44 +02:00
Adria Navarro d259bdbf7b Fix 2024-05-03 09:34:42 +02:00
Adria Navarro 2c5e9ff784 processOutputBBReference vs processOutputBBReferences 2024-05-03 09:31:24 +02:00
Adria Navarro 1767650337 processInputBBReference vs processInputBBReferences 2024-05-02 16:51:48 +01:00
Adria Navarro 2e4b69e381 PR comments 2024-05-02 12:12:48 +01:00
Adria Navarro 24aec6efb1 Clean types 2024-04-26 13:30:08 +02:00
Adria Navarro d45aa9beaf Merge branch 'master' into budi-8123/single-user-column-type 2024-04-26 12:47:35 +02:00
Adria Navarro a422ae43b2 Fix 2024-04-26 12:26:01 +02:00
Adria Navarro 1aad2ee6d2 Fix after renames 2024-04-26 12:23:11 +02:00
Adria Navarro 637f7f514a Remove FieldTypeSubtypes 2024-04-26 12:18:50 +02:00
Adria Navarro 61bb40d0d3 Remove FieldTypeSubtypes 2024-04-26 12:09:32 +02:00
Adria Navarro fe226ae54b Fix test 2024-04-26 11:26:24 +02:00
Adria Navarro d3425a856f Fix test 2024-04-26 10:07:08 +02:00
Adria Navarro ad44b7ab81 Fix types 2024-04-26 09:47:46 +02:00
Adria Navarro 4b0e389526 Lint 2024-04-25 16:40:13 +02:00
Adria Navarro 6e4baf7215 Fix import validation 2024-04-25 15:50:28 +02:00
Adria Navarro 5c93ee3e06 Refactor 2024-04-25 13:38:31 +02:00
Adria Navarro b7688d3a06 Do not store empty arrays 2024-04-25 13:21:00 +02:00
Adria Navarro 35ba5b93b5 Validate single reference not being an array 2024-04-25 13:21:00 +02:00
Adria Navarro 53badf9263 Lint 2024-04-25 13:20:59 +02:00
Adria Navarro b56c86e1b0 Lint 2024-04-25 13:20:59 +02:00
Adria Navarro 808aba0c34 Input processing 2024-04-25 13:20:59 +02:00
Adria Navarro afdbf4cc42 Add BB_REFERENCE_SINGLE type 2024-04-25 13:20:59 +02:00
Dean 9c7fed9eb8 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-04-11 15:06:59 +01:00
Adria Navarro b42cc88180
Merge pull request #13407 from Budibase/BUDI-8122/attachment_cleanup
Handle singleattachment on AttachmentCleanup
2024-04-10 10:41:32 +02:00
Dean 8e62aa8945 Fixes for existing attachment tests and some coverage for signatures 2024-04-08 16:51:43 +01:00
Dean 9b276aa3c1 Add in signature field testing support. Some signature fixes 2024-04-08 12:18:05 +01:00
Dean 1e5506b8c3 Full support for signature field type and some feedback changes 2024-04-05 12:50:09 +01:00
Adria Navarro 1bc555350a Lint 2024-04-04 21:09:15 +02:00
Adria Navarro 80dfef9c42 Test single attachment on outputProcessing 2024-04-04 21:07:44 +02:00
Adria Navarro b2ab4e022e Handle singleattachment on AttachmentCleanup 2024-04-04 20:39:11 +02:00
Adria Navarro a4c8fcb2ac Clean and populate url 2024-04-03 16:43:12 +02:00
Adria Navarro a8c3011071 Rename FieldType.ATTACHMENT to FieldType.ATTACHMENTS 2024-04-03 12:54:20 +02:00
Dean a773c167d5 Merge remote-tracking branch 'origin/master' into feature/signature-field-and-component 2024-03-22 15:26:23 +00:00
Dean 6b5938aef6 Merging 2024-03-22 15:26:05 +00:00
Adria Navarro 0859e79b1e Lint 2024-03-20 23:19:42 +01:00
Adria Navarro 0827cc6bda Type everywhere! 2024-03-20 19:33:39 +01:00
Sam Rose f1278312ab
Reenable no-case-declarations. 2024-03-19 15:58:25 +00:00
Sam Rose 1785f3af7e
Get lint passing. 2024-03-19 10:55:51 +00:00
Sam Rose 1f63f0bddf
Run auto fix. 2024-03-19 09:46:10 +00:00
Andrew Kingston b6eab42c18 Merge branch 'cheeks-lab-day-binding-eval' of github.com:Budibase/budibase into cheeks-snippets-poc 2024-03-14 16:24:16 +00:00
Adria Navarro 625c1dda9f Improve tests 2024-03-13 16:54:39 +01:00
Adria Navarro 940ff5acd2 Fix table changes with empty attachments 2024-03-13 16:48:58 +01:00
Adria Navarro 0420734d97 Add failing test 2024-03-13 16:48:32 +01:00
Andrew Kingston 28d938ba3e Lint 2024-03-12 19:09:32 +00:00
Andrew Kingston 16ce5ac65e Update how snippets are fetched and enriched into context, because HBS helpers can't be async 2024-03-12 17:02:01 +00:00
melohagan b563fb48c8
Error when deleting selected rows that have attachment (#13063)
* Deprecate selectedRowIds

* Delete selected rows table

* Add selectedRows to table block context

* update account-portal

* update account-portal

* Lowercase deprecated

* Make sure attachment fields are empty arrays not null

* unit test
2024-02-19 11:09:36 +00:00
mike12345567 0eb29ef73f PR comments. 2024-01-24 18:00:32 +00:00
mike12345567 ccc751d09c A quick refactor to get rid of the old 'FieldTypes' enumeration, considering how core it is to all data handling in Budibase, the fact we had both 'FieldType' and 'FieldTypes' was confusing - righting this fully. 2024-01-24 16:58:13 +00:00
Sam Rose 642b75e0ae
Revert "Remove all custom tracing to see if it's the cause of the memory leak." 2024-01-02 11:36:32 +00:00
Sam Rose 3c0901f530
Remove all custom tracing to see if it's the cause of the memory leak. 2023-12-21 11:06:05 +00:00
Sam Rose c4f124c78a
Update utils.ts
Co-authored-by: Adria Navarro <adria@budibase.com>
2023-12-15 12:22:37 +00:00
Sam Rose 7a11c5be92
Tweak newly added spans to track formula processing. 2023-12-15 11:10:23 +00:00
Sam Rose a6f03b02f2
Use the right casing for DataDog 2023-12-14 17:27:22 +00:00
Sam Rose 899b6707e7
add the column into the processStringSync span 2023-12-14 17:10:09 +00:00
Sam Rose 0d3ea23301
Instrument formula processing in DataDog. 2023-12-14 16:52:47 +00:00
mike12345567 d4a4bb96f4 PR comments 2023-12-08 13:24:24 +00:00
mike12345567 f6d5db7d61 Adding test cases for attachment cleanup update. 2023-12-08 13:21:08 +00:00
mike12345567 7665d2fd53 Fix for attachment deletion when updating table column name, as well as refactoring to make the code a bit easier to follow. 2023-12-07 16:35:43 +00:00
mike12345567 936ce9fcc2 Adding test to make sure attachments are output correctly. 2023-12-06 12:29:37 +00:00
mike12345567 be6cb0825c Fixing an issue with import and images not displaying correctly. 2023-12-05 18:27:56 +00:00
melohagan 0e93717f1a
Allow null strings (#12298)
* Allow null strings

* Don't update null to blank

* Save empty as null

* Make blank string map to null

* Add mappings for BigInt

* Fix unit tests
2023-11-23 09:53:35 +00:00
Adria Navarro db2c20e3ae eslint import/newline-after-import 2023-11-20 21:52:29 +01:00
Adria Navarro 92f411bf77 Prettier 2023-11-20 21:48:49 +01:00
Adria Navarro 4d27ff1dc0 eslint import/no-duplicates 2023-11-20 21:48:49 +01:00
mike12345567 312415ca7d Enforcing squash for rows which contain circular structures. 2023-11-07 13:47:21 +00:00
mike12345567 49b00ee7ee Fixing build issue. 2023-11-07 11:07:25 +00:00
mike12345567 635af0f76a Getting external rows to be more consistent with the internal API - the formulas should be processed using the outputProcessing as they were being processed, but was causing an overwrite. The problem was that the external system internally processed the formulas/relationships, then squashed the relationships. Once it got to the external API, it would go through normal output processing, which would run over the squashed rows, causing an inconsistent behaviour. 2023-11-06 19:03:37 +00:00
Michael Drury 9643d9c0e2
Merge branch 'master' into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column 2023-10-30 17:41:44 +00:00
Samuel-Martineau 674f40a06e
Fix how attachment URLs are handled 2023-10-30 11:12:16 -04:00
mike12345567 9b1a7bd854 PR comments - updating pickAPI to use a common function. 2023-10-27 11:43:01 +01:00
mike12345567 19eaafd946 Fixing some test cases. 2023-10-26 16:32:34 +01:00
mike12345567 ed0670a008 Major update to make the table.type always 'table' and then adding a new sourceType which states what source the table came from, external or internal. Don't want to keep using a type that should be static as two different things. 2023-10-26 13:19:09 +01:00
mike12345567 455b26bac9 Making sure the source ID is always set when creating a table - the frontend expects this to be set for every table so making the type represent this correctly. 2023-10-25 19:00:25 +01:00
mike12345567 13dadbcc7d Merge branch 'master' of github.com:Budibase/budibase into fix/internal-db-enrich-perf 2023-10-18 15:22:00 +01:00
Sam Rose 767900aec6
Remove type information from JSDoc in .ts files, it's redundant. 2023-10-17 16:46:32 +01:00
Michael Drury a23f918880 Merge branch 'master' into fix/internal-db-enrich-perf 2023-10-12 11:09:17 +01:00
Adria Navarro 5908a791f2 Return email and names on bb reference api output 2023-10-11 19:10:58 +02:00
mike12345567 09ce950e64 Merge branch 'master' of github.com:Budibase/budibase into fix/internal-db-enrich-perf 2023-10-11 17:24:08 +01:00
Adria Navarro 62fd9011f3 Merge branch 'labday/type_schema' into feature/multi-user-type-column 2023-10-11 14:13:55 +02:00
Adria Navarro 715db97436 Clean code 2023-10-11 13:21:51 +02:00
Adria Navarro 9391854f46 Types 2023-10-11 13:21:19 +02:00
Adria Navarro 6fa5727166 Clean 2023-10-11 13:19:05 +02:00
Adria Navarro f57104730e Remove subtype from the base field schema 2023-10-11 12:23:54 +02:00
Adria Navarro a8c814e714 Fixes fixes 2023-10-10 18:54:57 +02:00
Adria Navarro 6c328109b6 Fixes 2023-10-10 18:54:57 +02:00
Adria Navarro 21e2d7ddbe Fix relationship types 2023-10-10 18:54:57 +02:00
Adria Navarro c8ffa98844 Fixes 2023-10-10 18:54:57 +02:00
Adria Navarro c49a16fdac Fix tests 2023-10-10 15:35:00 +02:00
Adria Navarro b966ed221d Fix bulk delete 2023-10-10 13:52:47 +02:00
Adria Navarro 979c2aeb00 Return only id and primary display 2023-10-10 13:52:47 +02:00
Adria Navarro 7d6cd53c29 Add comments 2023-10-09 15:37:42 +02:00
Adria Navarro 0909e0547e Process formulas after processing complex fields 2023-10-09 15:30:07 +02:00
Adria Navarro 047936bcbf Merge branch 'master' into budi-7589/user-column-multi-user-filtering-support 2023-10-09 09:22:55 +02:00
mike12345567 0dc28122fa Adding test case. 2023-10-06 16:38:36 +01:00
mike12345567 d4335bca73 Quick fix for saving current user._id - make sure it is the correct format of ID. 2023-10-06 16:31:48 +01:00
mike12345567 3e2f9dfc4e Further enhancement, client library sends up the column it wants enriched and then we can ignore everything else, makes a big difference for enriching users (with a lot of relationships). 2023-10-05 18:23:18 +01:00
Adria Navarro 46b85ac12c Multiple users column 2023-10-04 17:55:23 +02:00
Adria Navarro 753cb442c2 Allow edit 2023-10-04 17:55:23 +02:00
Adria Navarro 1a00b60088 Fix tests 2023-09-29 16:39:18 +02:00
Adria Navarro 7050c5352a Check external table types 2023-09-29 16:09:08 +02:00
Adria Navarro 9d186df018 Don't modify internal API 2023-09-29 14:58:02 +02:00
mike12345567 5a3ecc3095 Getting create/update response consistent with internal API for external. 2023-09-29 13:40:40 +01:00
Adria Navarro fad4f12e26 Fix test 2023-09-28 10:00:25 +02:00
Adria Navarro fdb6474868 Fix tests 2023-09-28 10:00:25 +02:00
Adria Navarro 9afa334501 Fix deletions 2023-09-28 10:00:25 +02:00
Adria Navarro 38d6fa8b2a Renames 2023-09-22 17:33:13 +02:00
Adria Navarro 8a5270c6ee Fix 2023-09-20 13:19:38 +02:00
Adria Navarro 31b29662d6 Handle delete behaviours 2023-09-20 12:47:47 +02:00
Adria Navarro 244af30b6a Fix tests 2023-09-20 12:47:47 +02:00
Adria Navarro af499412cf Don't return the full user object 2023-09-20 12:47:47 +02:00
Adria Navarro d1cfb64017 Renames 2023-09-20 10:08:47 +02:00
Adria Navarro ed830835a4 use bulk cache in processOutputBBReferences 2023-09-20 10:07:38 +02:00
Adria Navarro 58d9d3e8e8 use bulk cache in processInputBBReferences 2023-09-20 10:05:52 +02:00
Adria Navarro 1314b991c7 Value is always csv 2023-09-19 13:17:07 +02:00
Adria Navarro 89af863c34 Lint 2023-09-19 10:14:25 +02:00
Adria Navarro 256ab3a296 Fix test 2023-09-18 12:22:18 +02:00
Adria Navarro ead2a2795e Fix deletion 2023-09-18 11:58:34 +02:00
Adria Navarro 7f6ef551c9 Return always arrays for bb processor fields 2023-09-18 11:57:27 +02:00
Adria Navarro 60d94e76cf Lint 2023-09-15 13:49:24 +02:00
Adria Navarro 29eaeacc4c Fix deletions 2023-09-15 13:47:08 +02:00
Adria Navarro 385989eca4 Process output 2023-09-15 13:31:56 +02:00
Adria Navarro bebe342b33 Handle output processing 2023-09-15 13:31:22 +02:00
Adria Navarro 9510c37b7a Handle bb ref only if there is a value 2023-09-15 13:04:45 +02:00
Adria Navarro 679f56f32f Error handling 2023-09-15 12:29:57 +02:00
Adria Navarro d62e9a475f Validate objects 2023-09-15 12:10:59 +02:00
Adria Navarro 0d3f9dac8c Validate and return csv 2023-09-15 12:07:25 +02:00
Adria Navarro 1ff3f5db80 Handle ids 2023-09-15 11:21:10 +02:00
Adria Navarro 4c4c2e118b Renames 2023-09-15 10:54:43 +02:00
Adria Navarro 8a9474c2ac Clean test 2023-09-15 10:44:50 +02:00
Adria Navarro e36fd75bc1 Add tests 2023-09-15 10:41:39 +02:00
Adria Navarro 0e3f316eb2 Process bb ref on input processing 2023-09-15 10:33:36 +02:00
Adria Navarro edd8879d04 inputProcessing async 2023-09-15 10:31:54 +02:00
Adria Navarro 1cbfeafe39 Remove context refs in row processor 2023-09-15 09:56:28 +02:00
Adria Navarro c6c1450d06 Fixe types 2023-08-01 12:52:12 +02:00
Adria Navarro 2c6725404f Types 2023-07-26 13:54:35 +02:00
Michael Drury e1741937ae Removing logging of error in coercion - this was creating noise in errors channel. 2023-06-21 12:08:39 +01:00
Andrew Kingston 6f51843875 Fix TS issue 2023-06-02 16:22:07 +01:00
Dean 6ee83e2da8 Reduced log level of parse array attempt 2023-06-01 09:05:22 +01:00