Commit Graph

294 Commits

Author SHA1 Message Date
Sam Rose 1f63f0bddf
Run auto fix. 2024-03-19 09:46:10 +00:00
Andrew Kingston b6eab42c18 Merge branch 'cheeks-lab-day-binding-eval' of github.com:Budibase/budibase into cheeks-snippets-poc 2024-03-14 16:24:16 +00:00
Adria Navarro 625c1dda9f Improve tests 2024-03-13 16:54:39 +01:00
Adria Navarro 940ff5acd2 Fix table changes with empty attachments 2024-03-13 16:48:58 +01:00
Adria Navarro 0420734d97 Add failing test 2024-03-13 16:48:32 +01:00
Andrew Kingston 28d938ba3e Lint 2024-03-12 19:09:32 +00:00
Andrew Kingston 16ce5ac65e Update how snippets are fetched and enriched into context, because HBS helpers can't be async 2024-03-12 17:02:01 +00:00
melohagan b563fb48c8
Error when deleting selected rows that have attachment (#13063)
* Deprecate selectedRowIds

* Delete selected rows table

* Add selectedRows to table block context

* update account-portal

* update account-portal

* Lowercase deprecated

* Make sure attachment fields are empty arrays not null

* unit test
2024-02-19 11:09:36 +00:00
mike12345567 0eb29ef73f PR comments. 2024-01-24 18:00:32 +00:00
mike12345567 ccc751d09c A quick refactor to get rid of the old 'FieldTypes' enumeration, considering how core it is to all data handling in Budibase, the fact we had both 'FieldType' and 'FieldTypes' was confusing - righting this fully. 2024-01-24 16:58:13 +00:00
Sam Rose 642b75e0ae
Revert "Remove all custom tracing to see if it's the cause of the memory leak." 2024-01-02 11:36:32 +00:00
Sam Rose 3c0901f530
Remove all custom tracing to see if it's the cause of the memory leak. 2023-12-21 11:06:05 +00:00
Sam Rose c4f124c78a
Update utils.ts
Co-authored-by: Adria Navarro <adria@budibase.com>
2023-12-15 12:22:37 +00:00
Sam Rose 7a11c5be92
Tweak newly added spans to track formula processing. 2023-12-15 11:10:23 +00:00
Sam Rose a6f03b02f2
Use the right casing for DataDog 2023-12-14 17:27:22 +00:00
Sam Rose 899b6707e7
add the column into the processStringSync span 2023-12-14 17:10:09 +00:00
Sam Rose 0d3ea23301
Instrument formula processing in DataDog. 2023-12-14 16:52:47 +00:00
mike12345567 d4a4bb96f4 PR comments 2023-12-08 13:24:24 +00:00
mike12345567 f6d5db7d61 Adding test cases for attachment cleanup update. 2023-12-08 13:21:08 +00:00
mike12345567 7665d2fd53 Fix for attachment deletion when updating table column name, as well as refactoring to make the code a bit easier to follow. 2023-12-07 16:35:43 +00:00
mike12345567 936ce9fcc2 Adding test to make sure attachments are output correctly. 2023-12-06 12:29:37 +00:00
mike12345567 be6cb0825c Fixing an issue with import and images not displaying correctly. 2023-12-05 18:27:56 +00:00
melohagan 0e93717f1a
Allow null strings (#12298)
* Allow null strings

* Don't update null to blank

* Save empty as null

* Make blank string map to null

* Add mappings for BigInt

* Fix unit tests
2023-11-23 09:53:35 +00:00
Adria Navarro db2c20e3ae eslint import/newline-after-import 2023-11-20 21:52:29 +01:00
Adria Navarro 92f411bf77 Prettier 2023-11-20 21:48:49 +01:00
Adria Navarro 4d27ff1dc0 eslint import/no-duplicates 2023-11-20 21:48:49 +01:00
mike12345567 312415ca7d Enforcing squash for rows which contain circular structures. 2023-11-07 13:47:21 +00:00
mike12345567 49b00ee7ee Fixing build issue. 2023-11-07 11:07:25 +00:00
mike12345567 635af0f76a Getting external rows to be more consistent with the internal API - the formulas should be processed using the outputProcessing as they were being processed, but was causing an overwrite. The problem was that the external system internally processed the formulas/relationships, then squashed the relationships. Once it got to the external API, it would go through normal output processing, which would run over the squashed rows, causing an inconsistent behaviour. 2023-11-06 19:03:37 +00:00
Michael Drury 9643d9c0e2
Merge branch 'master' into feature/budi-7607-migrate-user-relationship-columns-to-the-new-user-column 2023-10-30 17:41:44 +00:00
Samuel-Martineau 674f40a06e
Fix how attachment URLs are handled 2023-10-30 11:12:16 -04:00
mike12345567 9b1a7bd854 PR comments - updating pickAPI to use a common function. 2023-10-27 11:43:01 +01:00
mike12345567 19eaafd946 Fixing some test cases. 2023-10-26 16:32:34 +01:00
mike12345567 ed0670a008 Major update to make the table.type always 'table' and then adding a new sourceType which states what source the table came from, external or internal. Don't want to keep using a type that should be static as two different things. 2023-10-26 13:19:09 +01:00
mike12345567 455b26bac9 Making sure the source ID is always set when creating a table - the frontend expects this to be set for every table so making the type represent this correctly. 2023-10-25 19:00:25 +01:00
mike12345567 13dadbcc7d Merge branch 'master' of github.com:Budibase/budibase into fix/internal-db-enrich-perf 2023-10-18 15:22:00 +01:00
Sam Rose 767900aec6
Remove type information from JSDoc in .ts files, it's redundant. 2023-10-17 16:46:32 +01:00
Michael Drury a23f918880 Merge branch 'master' into fix/internal-db-enrich-perf 2023-10-12 11:09:17 +01:00
Adria Navarro 5908a791f2 Return email and names on bb reference api output 2023-10-11 19:10:58 +02:00
mike12345567 09ce950e64 Merge branch 'master' of github.com:Budibase/budibase into fix/internal-db-enrich-perf 2023-10-11 17:24:08 +01:00
Adria Navarro 62fd9011f3 Merge branch 'labday/type_schema' into feature/multi-user-type-column 2023-10-11 14:13:55 +02:00
Adria Navarro 715db97436 Clean code 2023-10-11 13:21:51 +02:00
Adria Navarro 9391854f46 Types 2023-10-11 13:21:19 +02:00
Adria Navarro 6fa5727166 Clean 2023-10-11 13:19:05 +02:00
Adria Navarro f57104730e Remove subtype from the base field schema 2023-10-11 12:23:54 +02:00
Adria Navarro a8c814e714 Fixes fixes 2023-10-10 18:54:57 +02:00
Adria Navarro 6c328109b6 Fixes 2023-10-10 18:54:57 +02:00
Adria Navarro 21e2d7ddbe Fix relationship types 2023-10-10 18:54:57 +02:00
Adria Navarro c8ffa98844 Fixes 2023-10-10 18:54:57 +02:00
Adria Navarro c49a16fdac Fix tests 2023-10-10 15:35:00 +02:00
Adria Navarro b966ed221d Fix bulk delete 2023-10-10 13:52:47 +02:00
Adria Navarro 979c2aeb00 Return only id and primary display 2023-10-10 13:52:47 +02:00
Adria Navarro 7d6cd53c29 Add comments 2023-10-09 15:37:42 +02:00
Adria Navarro 0909e0547e Process formulas after processing complex fields 2023-10-09 15:30:07 +02:00
Adria Navarro 047936bcbf Merge branch 'master' into budi-7589/user-column-multi-user-filtering-support 2023-10-09 09:22:55 +02:00
mike12345567 0dc28122fa Adding test case. 2023-10-06 16:38:36 +01:00
mike12345567 d4335bca73 Quick fix for saving current user._id - make sure it is the correct format of ID. 2023-10-06 16:31:48 +01:00
mike12345567 3e2f9dfc4e Further enhancement, client library sends up the column it wants enriched and then we can ignore everything else, makes a big difference for enriching users (with a lot of relationships). 2023-10-05 18:23:18 +01:00
Adria Navarro 46b85ac12c Multiple users column 2023-10-04 17:55:23 +02:00
Adria Navarro 753cb442c2 Allow edit 2023-10-04 17:55:23 +02:00
Adria Navarro 1a00b60088 Fix tests 2023-09-29 16:39:18 +02:00
Adria Navarro 7050c5352a Check external table types 2023-09-29 16:09:08 +02:00
Adria Navarro 9d186df018 Don't modify internal API 2023-09-29 14:58:02 +02:00
mike12345567 5a3ecc3095 Getting create/update response consistent with internal API for external. 2023-09-29 13:40:40 +01:00
Adria Navarro fad4f12e26 Fix test 2023-09-28 10:00:25 +02:00
Adria Navarro fdb6474868 Fix tests 2023-09-28 10:00:25 +02:00
Adria Navarro 9afa334501 Fix deletions 2023-09-28 10:00:25 +02:00
Adria Navarro 38d6fa8b2a Renames 2023-09-22 17:33:13 +02:00
Adria Navarro 8a5270c6ee Fix 2023-09-20 13:19:38 +02:00
Adria Navarro 31b29662d6 Handle delete behaviours 2023-09-20 12:47:47 +02:00
Adria Navarro 244af30b6a Fix tests 2023-09-20 12:47:47 +02:00
Adria Navarro af499412cf Don't return the full user object 2023-09-20 12:47:47 +02:00
Adria Navarro d1cfb64017 Renames 2023-09-20 10:08:47 +02:00
Adria Navarro ed830835a4 use bulk cache in processOutputBBReferences 2023-09-20 10:07:38 +02:00
Adria Navarro 58d9d3e8e8 use bulk cache in processInputBBReferences 2023-09-20 10:05:52 +02:00
Adria Navarro 1314b991c7 Value is always csv 2023-09-19 13:17:07 +02:00
Adria Navarro 89af863c34 Lint 2023-09-19 10:14:25 +02:00
Adria Navarro 256ab3a296 Fix test 2023-09-18 12:22:18 +02:00
Adria Navarro ead2a2795e Fix deletion 2023-09-18 11:58:34 +02:00
Adria Navarro 7f6ef551c9 Return always arrays for bb processor fields 2023-09-18 11:57:27 +02:00
Adria Navarro 60d94e76cf Lint 2023-09-15 13:49:24 +02:00
Adria Navarro 29eaeacc4c Fix deletions 2023-09-15 13:47:08 +02:00
Adria Navarro 385989eca4 Process output 2023-09-15 13:31:56 +02:00
Adria Navarro bebe342b33 Handle output processing 2023-09-15 13:31:22 +02:00
Adria Navarro 9510c37b7a Handle bb ref only if there is a value 2023-09-15 13:04:45 +02:00
Adria Navarro 679f56f32f Error handling 2023-09-15 12:29:57 +02:00
Adria Navarro d62e9a475f Validate objects 2023-09-15 12:10:59 +02:00
Adria Navarro 0d3f9dac8c Validate and return csv 2023-09-15 12:07:25 +02:00
Adria Navarro 1ff3f5db80 Handle ids 2023-09-15 11:21:10 +02:00
Adria Navarro 4c4c2e118b Renames 2023-09-15 10:54:43 +02:00
Adria Navarro 8a9474c2ac Clean test 2023-09-15 10:44:50 +02:00
Adria Navarro e36fd75bc1 Add tests 2023-09-15 10:41:39 +02:00
Adria Navarro 0e3f316eb2 Process bb ref on input processing 2023-09-15 10:33:36 +02:00
Adria Navarro edd8879d04 inputProcessing async 2023-09-15 10:31:54 +02:00
Adria Navarro 1cbfeafe39 Remove context refs in row processor 2023-09-15 09:56:28 +02:00
Adria Navarro c6c1450d06 Fixe types 2023-08-01 12:52:12 +02:00
Adria Navarro 2c6725404f Types 2023-07-26 13:54:35 +02:00
Michael Drury e1741937ae Removing logging of error in coercion - this was creating noise in errors channel. 2023-06-21 12:08:39 +01:00
Andrew Kingston 6f51843875 Fix TS issue 2023-06-02 16:22:07 +01:00
Dean 6ee83e2da8 Reduced log level of parse array attempt 2023-06-01 09:05:22 +01:00
Dean 1e6652dc39 Fix for importing exported array/option fields. Fix to ensure lastid and inclusion updates persisted as a result of an import. Test updates for array and option fields 2023-05-10 12:36:01 +01:00
Dean b0ff61c9ec Feedback update. Console.error to logging.logalert 2023-05-05 09:24:57 +01:00
Dean 5498cc86bd Refactor to fix tests and added an extra empty scenario 2023-05-04 12:58:45 +01:00
Dean a1fdff8df8 Linting 2023-05-04 12:25:30 +01:00
Dean 56a1b068cc Added json parse option for row import attachment values 2023-05-04 11:52:20 +01:00
mike12345567 1aca5d6407 Fixing an issue with creating relationships between existing tables, not using the correct type for the primary key in the foreign key relationship. 2023-04-19 17:17:37 +01:00
adrinr 8d45e44e2f Fix types 2023-03-30 11:30:35 +01:00
Rory Powell 786039055e File authentication using presigned URLs (#8883)
* file auth wip

* Private plugin bucket wip

* Add etag to logo request, fix circular dependency

* Resolve cyclic dependency

* Ensure browser doesn't cache custom component

* Global file fixes

* File fixes / remove permaUrl

* Add ctx local storage

* Enable presigned url to work from any host

* Test fix

* Self hosting w/ S3 + other fixes

* Fix for serving dev app in multi tenant

* Fix backup restore and import attachment url processing, never store attachment urls

* Test fixes

* Unit tests WIP

* Replace file path with base64 encoded private key

* Multi tenancy tests for files

* Environment files fixes

* Post-merge build and test fixes

* Add debug conditional to all jest logging and revert/fix prod minio proxy_pass

* Re-add default '/' minio route :(

* Rename iconFile -> iconFileName

* Add cloudfront vars to k8s templates

* Remove public bucket policy

* Remove duplicated test
2022-12-15 11:35:22 +00:00
Peter Clement 9d841bc947 Server and Worker tests (#8928)
* automation unit tests

* row processor tests

* update executeQuery test

* update groups assertion

* some more worker tests

* plugin tests and tidying up

* linting

* temporarily disable group tests

* more tests

* fix import

* fix backup tests

* add pro mocks to worker

* check for app existence in import test

* test new tsconfig

* testing changes

* Pro test utils (#9020)

* Pro test utils changes

* Add test fixes

* Remove ts-ignore

Co-authored-by: mike12345567 <me@michaeldrury.co.uk>
Co-authored-by: Rory Powell <rory.codes@gmail.com>
2022-12-12 22:02:32 +00:00
mike12345567 12d6e60525 One file left in the server, some fixes after converting the internal row controller. 2022-11-26 15:42:53 +00:00
mike12345567 658f12281d Fixes based on server build so far. 2022-11-26 15:10:41 +00:00
mike12345567 7eac8fafd6 Some server typescript re-writes, only automations left and some controllers. 2022-11-25 15:01:46 +00:00
mike12345567 514f9a1210 Some fixes based on test runs. 2022-11-23 11:44:15 +00:00
mike12345567 02ede5d067 Finally removing all usages of backend-core/ type imports from server, including some further typescript conversions. 2022-11-22 19:49:59 +00:00
mike12345567 8c2d9ebec8 Updating all of the route files to typescript, as well as some controllers. 2022-11-22 18:49:19 +00:00
mike12345567 8a4da7d4ce Typescript conversion of the table controllers. 2022-11-22 13:56:01 +00:00
mike12345567 de82eca502 Some typescript conversions, moving a few imports around. 2022-11-21 18:33:34 +00:00
Dean c09154b03e Renamed the 'Scanned Code' field type to 'Barcode/QR'. The component is also now listed as 'Barcode/QR Scanner'. Minor fix to include longform text columns in the table csv import list 2022-10-07 11:00:25 +01:00
Dean e251c914ff Review feedback changes. Changed 'Code' labelling to 'Scanned Code' 2022-10-06 13:02:17 +01:00
Dean 2ec21741d1 Initial commit of QR Reader field 2022-10-05 09:28:07 +01:00
mike12345567 8e56a7a4d9 Fixing an issue with external tables containing time only fields. 2022-09-07 17:57:02 +01:00
mike12345567 2dea5c5614 Some various session fixes based on current data. 2022-08-05 21:35:26 +01:00
Andrew Kingston 72397530ec Apply timezones patch from existing ignore-timezones branch 2022-06-07 08:31:00 +01:00
mike12345567 194b76985c Fix for #5269 - the sub type was being lost in some scenarios related to the user table being updated - making sure it is consistently kept when dealing with either of the related tables. 2022-04-26 14:24:51 +01:00
mike12345567 dbc048b365 Review comments, renaming deployed -> prod in terms of app IDs. 2022-01-31 17:42:51 +00:00
mike12345567 9198439f7f Merge branch 'develop' of github.com:Budibase/budibase into lab-day/refactor-app-db 2022-01-31 17:00:22 +00:00
mike12345567 d2fe119d90 Main body of work, refactoring most usages. 2022-01-27 18:18:31 +00:00
mike12345567 ab5c7766b4 Bit of refactoring, adding in functionality to remove invalid static formula when the elements that the formula depends on are removed. 2022-01-24 18:22:59 +00:00
mike12345567 da26761773 Make sure attachments are deleted when table is deleted, or column is removed. 2022-01-24 16:32:41 +00:00
mike12345567 10a2915bcb Getting relationship re-enrichment working, so that static formulas will update when the value of the relationship changes. 2022-01-21 17:45:24 +00:00
mike12345567 deb4a34c18 Adding the ability to filter using the filter drawer for formula fields, getting them based on the enriched contents of a row - adding functionality to denote to each table which other tables depend on them for formula. 2022-01-21 16:24:24 +00:00
mike12345567 50eff577f9 Getting the static formulas being processed on input, not re-processing on output. 2022-01-20 18:04:44 +00:00
mike12345567 37d0617ace Renaming some variables to core, fixing test cases that referenced auth directly. 2022-01-11 16:18:30 +00:00
mike12345567 c75cc47ad3 Updating to handle prod vs dev apps and deletion of attachments, as well as handling it on update. 2022-01-06 18:45:40 +00:00
mike12345567 f1981220af Removing attachments when row is deleted (always, need to restrict if app is deployed). 2022-01-06 17:59:29 +00:00
mike12345567 003b6424a2 Fixing issue with updating row validation to allow empty objects. 2021-11-29 17:54:09 +00:00
Peter Clement 5cfaa17798 add check for missing _rev 2021-10-18 09:51:13 +01:00
Peter Clement eb957bc94f Potential fix for issues with updating and saving rows and columns 2021-10-17 21:23:30 +01:00
mike12345567 b73fc93cdc Fixing some issues which were causing errors during the cypress test runs, such as not redirect /api/system/ requests to the worker. 2021-10-14 16:16:20 +01:00
mike12345567 8decbc20d5 Fixing issue with created by/updated by on public forms, also fixing a small issue with analytics ping generating a 404. 2021-10-01 15:00:11 +01:00
mike12345567 c8dbf02acf Performance improvements after testing - switching to temporary in memory queries for cloud views. 2021-09-21 15:59:50 +01:00
mike12345567 cf5b7b1a99 Fixing issues with automation steps found during testing. 2021-09-20 19:21:04 +01:00
mike12345567 a92530f170 Fixing issue #2412 - making sure full enriched records are passed along to automations. 2021-09-13 16:28:52 +01:00
mike12345567 8c3eb30ab1 Fixing issues after upgrading to node 14 and circular dependencies causing issues. 2021-09-02 18:33:41 +01:00